Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1667390ybz; Thu, 16 Apr 2020 13:17:39 -0700 (PDT) X-Google-Smtp-Source: APiQypJzPiSpyOYnO+IRAjZVIXMvCKLIYOf4czAeaqmWq/xhLfHukaoQ8uhlpgnw0EARgaGs/Rfs X-Received: by 2002:a17:906:3048:: with SMTP id d8mr11357260ejd.97.1587068258838; Thu, 16 Apr 2020 13:17:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587068258; cv=none; d=google.com; s=arc-20160816; b=oDoBqTOT9K1OnCkulrsQEWX4wmC9ZjFKMyaNUTJDpJkxXUK0TWERI4g7M43HeFqCcB Msxk1MuUs4otMGgkURDJxbvK4zylvFxT4gQeyO+gGrj1j9a+gY+bY0paeYzYkvC3dmtU LgO7yb/GsJmqLTLrfBnOaCReb80UcN7nl66KnVPXGM9S51JzdyMl0XQHJ/Fds65w1Wsb mV4x21ygjxmm5mR3iyXyB4dsrkyiq/J9qRjh4GG7Cux/9fBAOAbaPVDokPVn/8h9bbUw zQo3eRXONnuJ1+oBksjl6Ck1nDGpbsaOPr3/LEsYu4T80Kj/qciVWe2tSt639HSzfevA h19g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jFhVkmgSDcxeDv7k0GHweXHyM1Vd8Y8t6JOBs/hXurw=; b=lQGOWJJRyZk/dWD1sdPdviKxDxyZlvuusM093mMi1bQLHq95dThEh7qBVh1LFJyHyy ZkIeizJEx5XQDWP1Hk5bHhxHznccpJPQdg7rP/Mi0MeLhj+eBDvJlQrfm/nmxesrz1by uOlR+8g/aQN6NB+87shRmaxKdeTtkm8QEUL8fyiICAvNxVDN0+94DFZ2bHfIlLg4Fef7 yAJQR0MN4WI7Ivwi4hubNzN8MHnkJsW2MPXLieFcRJrJlmQCdy8gyGD5CaROxzBcKLjA BuGijAvmgDH2hBJuA4nIN+AGRprMCpIOrnX/W4YbshUlKWUz/2vsm4+bPfxPMQf2VpEH rONQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UsBVNTaz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i8si11654293ejf.197.2020.04.16.13.17.15; Thu, 16 Apr 2020 13:17:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UsBVNTaz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393598AbgDPOLN (ORCPT + 99 others); Thu, 16 Apr 2020 10:11:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:32988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2898641AbgDPNq7 (ORCPT ); Thu, 16 Apr 2020 09:46:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4701521974; Thu, 16 Apr 2020 13:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587044818; bh=wttoton6TEU7iHeRKVPjij7bCAVwDWT6iBkWVBDZgs8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UsBVNTazxCiOfyRKwPgUiS0pmylwg47ggYqZw8+rDo/iy8vDOWEMwyueigPL4sdDx UBSyu5zJ40f4a4hCGzj+gef6HnJmp/22TvcbhENs0Ax5xj9s+5S0m+ZIhessDLRl3c HWTi0rE1a3yme/oI547yMM/Lom6Fjy4v9rqoqEd4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pei Huang , Huacai Chen , Thomas Bogendoerfer Subject: [PATCH 5.4 114/232] MIPS/tlbex: Fix LDDIR usage in setup_pw() for Loongson-3 Date: Thu, 16 Apr 2020 15:23:28 +0200 Message-Id: <20200416131329.401367116@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200416131316.640996080@linuxfoundation.org> References: <20200416131316.640996080@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huacai Chen commit d191aaffe3687d1e73e644c185f5f0550ec242b5 upstream. LDDIR/LDPTE is Loongson-3's acceleration for Page Table Walking. If BD (Base Directory, the 4th page directory) is not enabled, then GDOffset is biased by BadVAddr[63:62]. So, if GDOffset (aka. BadVAddr[47:36] for Loongson-3) is big enough, "0b11(BadVAddr[63:62])|BadVAddr[47:36]|...." can far beyond pg_swapper_dir. This means the pg_swapper_dir may NOT be accessed by LDDIR correctly, so fix it by set PWDirExt in CP0_PWCtl. Cc: Signed-off-by: Pei Huang Signed-off-by: Huacai Chen Signed-off-by: Thomas Bogendoerfer Signed-off-by: Greg Kroah-Hartman --- arch/mips/mm/tlbex.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/arch/mips/mm/tlbex.c +++ b/arch/mips/mm/tlbex.c @@ -1480,6 +1480,7 @@ static void build_r4000_tlb_refill_handl static void setup_pw(void) { + unsigned int pwctl; unsigned long pgd_i, pgd_w; #ifndef __PAGETABLE_PMD_FOLDED unsigned long pmd_i, pmd_w; @@ -1506,6 +1507,7 @@ static void setup_pw(void) pte_i = ilog2(_PAGE_GLOBAL); pte_w = 0; + pwctl = 1 << 30; /* Set PWDirExt */ #ifndef __PAGETABLE_PMD_FOLDED write_c0_pwfield(pgd_i << 24 | pmd_i << 12 | pt_i << 6 | pte_i); @@ -1516,8 +1518,9 @@ static void setup_pw(void) #endif #ifdef CONFIG_MIPS_HUGE_TLB_SUPPORT - write_c0_pwctl(1 << 6 | psn); + pwctl |= (1 << 6 | psn); #endif + write_c0_pwctl(pwctl); write_c0_kpgd((long)swapper_pg_dir); kscratch_used_mask |= (1 << 7); /* KScratch6 is used for KPGD */ }