Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] KVM: SVM: fix compilation with modular PSP and
 non-modular KVM
To:     Tom Lendacky <thomas.lendacky@amd.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc:     ubizjak@gmail.com
References: <20200413075032.5546-1-pbonzini@redhat.com>
 <d8cab90f-8c9c-7f79-0913-ba0d8576206d@amd.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <a2965bb4-42f3-7961-aaba-66f031197dff@redhat.com>
Date:   Thu, 16 Apr 2020 16:14:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <d8cab90f-8c9c-7f79-0913-ba0d8576206d@amd.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 16/04/20 15:57, Tom Lendacky wrote:
> On 4/13/20 2:50 AM, Paolo Bonzini wrote:
>> Use svm_sev_enabled() in order to cull all calls to PSP code.  Otherwise,
>> compilation fails with undefined symbols if the PSP device driver is
>> compiled
>> as a module and KVM is not.
> 
> The Kconfig support will set CONFIG_KVM_AMD_SEV to "n" in this
> situation, so it might be worth seeing if sev.o could be removed from
> the build at that point. I'll try and look at that when I get a chance,
> but I'm currently buried with a ton of other work.

It could be made to work, but you would have to add stubs to sev.h.

Paolo