Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1680345ybz;
        Thu, 16 Apr 2020 13:33:32 -0700 (PDT)
X-Google-Smtp-Source: APiQypJUCzS5fDZdLOWQCA1oqrV+dftiWt8zGTtvqY5xf7TM6Q3Sf09qvFbvilMnmzIiqIP19QZs
X-Received: by 2002:a17:907:11de:: with SMTP id va30mr11385319ejb.121.1587069211924;
        Thu, 16 Apr 2020 13:33:31 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1587069211; cv=none;
        d=google.com; s=arc-20160816;
        b=Do23JrLVzPamnxzpwTUvgYfI1xTt4ruskECiLj3uRq6iqyQpCCFawxnHJmTEEWpeRI
         OzsDdwGhYx/A7vE31syebQdG7FDW/yf+diiw8Y4QNToMJc9S9S3zFXUHtR4sV2uwcVki
         BZjIFZDVRANMMWD0NqsN94wxspg/TTPp7Ump/yq3dq9UFlOJA8TGmXkVDnuiVgqhh4q1
         JQg8bVy/NigybFLk7G2o36W2hz0wD/DeMIzZ1yQ0TkJIm9ggZ8YWApvZ1xr/ef0FTBre
         gHv7fcBMjVknZKTx15rx6pUjtUiJATjubQygS7hTMxFrFKaYteWZTZ3ccCD7XrjEpNzT
         YsIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:references:cc:to:from:subject;
        bh=Fl0om3B9+m0xV2ZjbeTZ3/9u69RbONb/EFDDfM5VqKs=;
        b=TycDu84y4+p8acEcOaNTlzm9MriiE7D23wx6at9HYZaVa71pjuUdDoTlEUA8NEhgWc
         bOepVm0e4uiTveXSLr2H9iJXIeRv5OkO6Xxnvc2Ronu1VThoJoYs2CkzC0RK1Z5heVci
         HjVSYvAqs/LZoo+vEuA9Y9b0v8C7SXRuPVNW7Bm2M4f5tZlDif59UVEKbCSKjDOtaKFm
         RRno4QNRukx33PCeRoraWtG1bpTdbVHk1b9GUfM3HGOLqonaYYNwnDTlnVGFgg301SIc
         GoSKlqBIfs32Md5vswDfJ/Lzd0FUhOiGqBERt1ZJhBQW0VzCNlGm5/MTT7BnmFoUX8Q6
         nSog==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=ch6t49Tf;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id a11si7860584edv.573.2020.04.16.13.33.08;
        Thu, 16 Apr 2020 13:33:31 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=ch6t49Tf;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2442152AbgDPPOQ (ORCPT <rfc822;saikripd@gmail.com> + 99 others);
        Thu, 16 Apr 2020 11:14:16 -0400
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:11981 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2395064AbgDPPMR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Apr 2020 11:12:17 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5e9875950002>; Thu, 16 Apr 2020 08:11:17 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Thu, 16 Apr 2020 08:12:16 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Thu, 16 Apr 2020 08:12:16 -0700
Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 16 Apr
 2020 15:12:15 +0000
Received: from [10.2.171.241] (10.124.1.5) by DRHQMAIL107.nvidia.com
 (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 16 Apr
 2020 15:12:14 +0000
Subject: Re: [RFC PATCH v7 6/9] media: tegra: Add Tegra210 Video input driver
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
To:     Dmitry Osipenko <digetx@gmail.com>
CC:     <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
        <frankc@nvidia.com>, <hverkuil@xs4all.nl>, <sakari.ailus@iki.fi>,
        <helen.koike@collabora.com>, <sboyd@kernel.org>,
        <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-clk@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1586919463-30542-1-git-send-email-skomatineni@nvidia.com>
 <1586919463-30542-7-git-send-email-skomatineni@nvidia.com>
 <4118112f-f865-5460-6319-d71271fd78d1@gmail.com>
 <a69a8b34-beea-3ad0-e08e-f7df8b9e7047@nvidia.com>
 <6afa951e-d904-f3c0-053f-82a02fb18979@nvidia.com>
 <b1c78827-13ea-0c94-a575-97b5afc0ede1@nvidia.com>
 <5954a7e1-910e-7f48-56d3-e671b56ead74@nvidia.com>
 <d6a9e07c-474a-a076-8313-32f5f4ca8d64@nvidia.com>
 <786949a9-8507-7723-f29b-b91a216bfd28@nvidia.com>
 <f831408b-bbf4-3047-20e3-5bebfa9fc1ad@gmail.com>
 <2ad9352f-cb65-1643-e540-a21f9c570266@nvidia.com>
 <31924f2b-8f85-d28d-4f5d-4e232bff94a5@nvidia.com>
 <c95cd2b6-8036-8c0a-25f3-6ea3fe35334a@nvidia.com>
Message-ID: <254a9091-8c90-61fa-6a5a-af5ad6e2133e@nvidia.com>
Date:   Thu, 16 Apr 2020 08:12:13 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <c95cd2b6-8036-8c0a-25f3-6ea3fe35334a@nvidia.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 DRHQMAIL107.nvidia.com (10.27.9.16)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1587049877; bh=Fl0om3B9+m0xV2ZjbeTZ3/9u69RbONb/EFDDfM5VqKs=;
        h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=ch6t49Tf658edmz0fglGVlzhPSSet19nHf/fKo2uG7qcur4fqhwj+ST3F0ICyEgVb
         Kh75bt6Sl+b8xPOMBTcW8fg3wi7BWSvW64xhzma4Wp+NUn7dl2/mBM45K1zFKJgzHx
         nwd8k6dZDLGPamZJAfUgEYcMFhbWEbdvAMtE5S8X4Er6jl22B5C85FRivpF6KX4H/N
         ZoUtkxJjV0uEUJPaHJ0+eTvylQruWS17yBq8fn6eA5moVtoFVC1SuddtCJCoUwGYay
         dmqurfw5ukAkzI6Aky5Yo906YUhgemz1Tvm80u1cvJYz+cgi+x/Qp2eHSYLjTAlmTX
         hdVJbtGKnV1fQ==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tegra-video module unload->load and tegra-video driver unbind->bind are=20
good.

Will have v8 to switch to use devm_kzalloc for vi/csi and will revisit=20
direct host1x client driver unbind->bind later.

Thanks

Sowjanya


On 4/15/20 4:28 PM, Sowjanya Komatineni wrote:
> Sorry please ignore.
>
> We can't free vi during v4l2 device release as when no device nodes=20
> are opened, vi free happens right away during host1x_video_remove.
>
> With this tegra-video driver unbind ->bind will not work as vi memory=20
> allocated during vi_probe gets freed during v4l2 device release so=20
> during bind init() callback execution will crash as vi got freed while=20
> vi driver is still bound to device.
>
> Will wait for Hans/Thierry comments as I see dependency depending on=20
> where unbind/bind happens.
>
>
> On 4/15/20 4:08 PM, Sowjanya Komatineni wrote:
>> With minor change of not using vi reference after=20
>> host1x_client_unregister and freeing vi during v4l2 device release=20
>> works.
>>
>> For csi, we can use devm_kzalloc for now untill we decide later if we=20
>> want to expose async subdev nodes during sensor support.
>>
>> Will have this fix in v8 with a comment in vi_remove to make sure not=20
>> to use vi reference after host1x_client_unregister.
>>
>> Will test more and will release v8 with above fix to allow direct=20
>> host1x client driver unbind.
>>
>> Thanks
>>
>> sowjanya
>>
>>
>> On 4/15/20 12:51 PM, Sowjanya Komatineni wrote:
>>>
>>> On 4/15/20 12:21 PM, Dmitry Osipenko wrote:
>>>> External email: Use caution opening links or attachments
>>>>
>>>>
>>>> 15.04.2020 21:53, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>>> ...
>>>>>>>>>>> Have you tried to test this driver under KASAN? I suspect that
>>>>>>>>>>> you just
>>>>>>>>>>> masked the problem, instead of fixing it.
>>>>> Tested with kmemleak scan and did not see any memory leaks
>>>> You should get use-after-free and not memleak.
>>> I don't see use-after-free bugs during the testing.
>>>
>>> But as mentioned when direct vi/csi client driver unbind happens=20
>>> while video device node is kept opened, vi driver remove will free=20
>>> vi structure memory but actual video device memory which is part of=20
>>> channels remains but list head gets lost when vi structure is freed.
>>>
>>> So, when device node is released and executes release callback as=20
>>> list head is lost it can't free allocated channels which is not good.
>>>
>>> This happens only with direct host1x client vi/csi driver unbind.
>>>
>>> Need to find better place to free host1x client driver data=20
>>> structure to allow direct client driver unbind->bind.
>>>