Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1682089ybz; Thu, 16 Apr 2020 13:35:45 -0700 (PDT) X-Google-Smtp-Source: APiQypJ6rAe2BHIbdfs+htxt5NuWE8pbtrjsFsVSLuG+AtGhBwJHdkLAJeXCxtDDZSmYuOKo6Cov X-Received: by 2002:a50:8b41:: with SMTP id l59mr58366edl.44.1587069345224; Thu, 16 Apr 2020 13:35:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587069345; cv=none; d=google.com; s=arc-20160816; b=gaKWtITyoU/fGTS2W1VposhMtewCC4Pb444tv9C8HpHObScYniqLkMvALZEsQ8u0ui TsmdNcWI6+rlHth9lPjK5Bmg/VX5lvfMvhNeT+uxfJF19/uiVnVyeDXCAHm2rRD61eoW jBfn3cXzhmc575ct6k/yaMvW+MXwAOO/hDhvqnonQ3U6pB5I27E7KJuDTHPD9TGJ249g DCCsqxdJhCzECIOC7vB+5azGEei4RykyYLHskxpSy3NycqS1dQc8W7sQIz5EJpFW9J77 Asrqly8USXD5anoMz7JUlsa3snJ6gYktk4B8AyuC6MiZiP26YzZ7OQ9aOLvCgG4rEl8g ar9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=bgLKTDMc966pLZePK7Gy4v5POGBi54ywnFTq5rJSgzs=; b=mog/2h94DTbchcjUXf6+nhpHn8xJrIg2reypOh0kSzQFSjN3rkawvozClu/y9DJPwE 53xhxOLcpm4jzJAhQayVc6ovaHR1YuGONiPRi8uHAXbT7NF77qGSQa+CdDYvvzAhmQvZ gVE/vUT0V8yLyiYVyAInOdApROGjapNVf1iD8EOcLMjS8FnOAmg/dgmpkDog9pAs8LL3 mn/H0PUm9WZFgCtnqvVsX+2bbc5nkpKtEqIIzzmO2CnvzxoLoZl2Jp0v4xFDDLHJvwyv YlVNETv1RrsLiSBTACFkhto8ah7jsMqm4vp5m8DYCFEkrM8V5RFtg44pixQz7DBF7zLV 8b4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="xig6g/Wf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cm14si6315107edb.546.2020.04.16.13.35.22; Thu, 16 Apr 2020 13:35:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="xig6g/Wf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395282AbgDPPaP (ORCPT + 99 others); Thu, 16 Apr 2020 11:30:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2395276AbgDPPaJ (ORCPT ); Thu, 16 Apr 2020 11:30:09 -0400 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 584AFC061A10 for ; Thu, 16 Apr 2020 08:30:09 -0700 (PDT) Received: by mail-io1-xd2b.google.com with SMTP id w20so21461512iob.2 for ; Thu, 16 Apr 2020 08:30:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bgLKTDMc966pLZePK7Gy4v5POGBi54ywnFTq5rJSgzs=; b=xig6g/WfEF6trkg+0bcPLBXurHgj5BTteF/0bBs3S1SiPTI9eFkmsiah/l6oXRYuc4 zkslZZdVvLAWgF0iEVZIyTeaxPgYk0LncDabFx/Kt7CGJC0/Wcztp1H/XH7BCabWb2Li +3iteA8k8S4RTWplvYBrO8hJ9kQIVhFywXE3gVg2U9sjyHWhwQTswfZut7DE1JL3jYzF okcX8eMj9A7MTPleU1A+uVJD+E8ajXhwpEK/djVcnI5BC9ciULzrr8zoBF6Qi2bWBJLC J92SSWGu9sUk3rF/7qe+Hw+ct6OCLF373Xl5/deOMRiBil0k4xNutPCfd0ZT0SBfF5QU PT/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bgLKTDMc966pLZePK7Gy4v5POGBi54ywnFTq5rJSgzs=; b=EC5R7zqFD/uoObUahDScOo70RaDSP4ykH7MzNqmQwlPK/xwKA2gj3FwgmnCjrLgsP2 6iC+Ap175qbHxMcHwuesM6gyBWc6MHX0bCCgQLpx0yHQeQqSokYtTimwtqiLwFJPu7QE HV9QyHP5XHFAVFsuBmJGmq6V/4p+NEQ0BgOMAgxbQkNQWkSkvv7hXlTDsQnH22yKjtli E4h/jKMvo3JOo3si9vM2nw+NTVPakFYrBT071JfguY+EgrXtRg2hIXejBzAvu+LeY2oC /zboMVJ3PIxnrVZ1Ws6B7nIJkVcl1ZOQjaUj74xBPr7zV90DBUZ/78nRl3ln5tJLZ/ET swWQ== X-Gm-Message-State: AGi0PubA62JAuG/EdWZ4gWoySzuRO0t3pxpFA1jkjHpDWBNC21d8ByZc yrba+e3qpMml6nwgugq4o6QHaq6qjmbczA== X-Received: by 2002:a5d:8f02:: with SMTP id f2mr2254689iof.55.1587051008389; Thu, 16 Apr 2020 08:30:08 -0700 (PDT) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id a19sm5725806ilk.34.2020.04.16.08.30.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Apr 2020 08:30:07 -0700 (PDT) Subject: Re: bdi: fix use-after-free for dev_name(bdi->dev) To: Christoph Hellwig Cc: yuyufen@huawei.com, tj@kernel.org, jack@suse.cz, bvanassche@acm.org, tytso@mit.edu, gregkh@linuxfoundation.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200416071519.807660-1-hch@lst.de> <874d57cb-90f1-db09-8f9d-29527451e241@kernel.dk> <20200416152946.GA10845@lst.de> From: Jens Axboe Message-ID: Date: Thu, 16 Apr 2020 09:30:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200416152946.GA10845@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/16/20 9:29 AM, Christoph Hellwig wrote: > On Thu, Apr 16, 2020 at 09:29:13AM -0600, Jens Axboe wrote: >> On 4/16/20 1:15 AM, Christoph Hellwig wrote: >>> Hi all, >>> >>> the first three patches are my take on the proposal from Yufen Yu >>> to fix the use after free of the device name of the bdi device. >>> >>> The rest is vaguely related cleanups. >> >> Applied, thanks. > > Please hold back, we still have a major issues with it. I will resend > a fixed version tomorrow. OK, will do. -- Jens Axboe