Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1682888ybz; Thu, 16 Apr 2020 13:36:49 -0700 (PDT) X-Google-Smtp-Source: APiQypLLhrmTPd2hQwPVEMSDO8MNQPIwNRstho8RVHwinr83EiZzMrVqfJ+KdzUAsSs3SL0feK89 X-Received: by 2002:a17:906:4f8f:: with SMTP id o15mr11090095eju.175.1587069409037; Thu, 16 Apr 2020 13:36:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587069409; cv=none; d=google.com; s=arc-20160816; b=pizNZYqGfSLdA81WZNr4gCEn1NX0LAoI/KGnXJuRuyTUmB+yEhSf9Swa5J1hCEy2T3 BBAna8VKXfoXpkjSlwI+U2Bg15JqwNWNjqZUT7qicPjFFs4BBPwhUyrz9bpiCbokDzx+ JhqjThwM/FKXhQp9nFYFyTnablr+Pz5FhRXYe9rG8kykPHHSf2gdx52CY+F8XLT1GH31 Fm4pkvwEWghEVZpleTbxb6jjI6xjSjoOXhmqTV0ndryiSfflXuWU7xRrz1Ypxnu5fnqy wv9rpfBgI3Aobkg0WiW4mebAL6BimLApiv9IY80+t3lvbye5K7OMzQOhbaxd+5rfilBA zIsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OYA5f8XRmGlH2wrVe5+xu1rn/lXZhHHw2zFu1QC6G9k=; b=NYjibW+2G/FlivF5DyI3BHJdhmtf3ACr31UcEMNtuDSTyu6FHBvOBJB176OHjpx2tg x5lR3W8PQemLBNwUkBZLIunV2iMu4P3nNC3s6fW6fnev5eU42B2yK5lb3OJzdqvXhtkU a19BYxf8L66nekbCSzH1NKv2pZAszcrcFe8pGiNmG7JZpfD00qyiWZtqvvWkgHsBSqMN JxWvtH0kpEyMJQ7z/Q6Vwyw9HnS5k7hjSukVOXoOfYnO7AaadjofuDkkU7HcUUJfoePR UYQe2X1h44hRySe5QbHDbW+WuiilvOKlh99g6NDunAXAuy0pVkBuO0rPZ6jL87Z5VGQ0 /4ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hJLECXd5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c20si2819619edr.481.2020.04.16.13.36.26; Thu, 16 Apr 2020 13:36:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hJLECXd5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2410307AbgDPP3P (ORCPT + 99 others); Thu, 16 Apr 2020 11:29:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:57248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2898087AbgDPNny (ORCPT ); Thu, 16 Apr 2020 09:43:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F23A214D8; Thu, 16 Apr 2020 13:43:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587044634; bh=rcjh3l3DjFWYTa13HVk4wQSTUrOgmQ2s6RvdNQnB9Cg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hJLECXd52pe7AK0fypno84sg6vrvRXMfZlH+zbz7DALVgNjigl2eo2afdcaGxHq/b g8VLJ63499l2KlP5hpuHMRG+J7IBvSw05fTm8FRCy2pI+6SLLxc8NWTTZMb1zPEWt4 3xoNjNqxzHteeiB96WafyQ3lV9YeaedDD+k0Us64= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paul Menzel , Bob Liu , Konstantin Khlebnikov , Song Liu , Sasha Levin Subject: [PATCH 5.4 038/232] block: keep bdi->io_pages in sync with max_sectors_kb for stacked devices Date: Thu, 16 Apr 2020 15:22:12 +0200 Message-Id: <20200416131320.692007316@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200416131316.640996080@linuxfoundation.org> References: <20200416131316.640996080@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Konstantin Khlebnikov [ Upstream commit e74d93e96d721c4297f2a900ad0191890d2fc2b0 ] Field bdi->io_pages added in commit 9491ae4aade6 ("mm: don't cap request size based on read-ahead setting") removes unneeded split of read requests. Stacked drivers do not call blk_queue_max_hw_sectors(). Instead they set limits of their devices by blk_set_stacking_limits() + disk_stack_limits(). Field bio->io_pages stays zero until user set max_sectors_kb via sysfs. This patch updates io_pages after merging limits in disk_stack_limits(). Commit c6d6e9b0f6b4 ("dm: do not allow readahead to limit IO size") fixed the same problem for device-mapper devices, this one fixes MD RAIDs. Fixes: 9491ae4aade6 ("mm: don't cap request size based on read-ahead setting") Reviewed-by: Paul Menzel Reviewed-by: Bob Liu Signed-off-by: Konstantin Khlebnikov Signed-off-by: Song Liu Signed-off-by: Sasha Levin --- block/blk-settings.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/blk-settings.c b/block/blk-settings.c index c8eda2e7b91e4..be1dca0103a45 100644 --- a/block/blk-settings.c +++ b/block/blk-settings.c @@ -664,6 +664,9 @@ void disk_stack_limits(struct gendisk *disk, struct block_device *bdev, printk(KERN_NOTICE "%s: Warning: Device %s is misaligned\n", top, bottom); } + + t->backing_dev_info->io_pages = + t->limits.max_sectors >> (PAGE_SHIFT - 9); } EXPORT_SYMBOL(disk_stack_limits); -- 2.20.1