Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1686164ybz; Thu, 16 Apr 2020 13:41:10 -0700 (PDT) X-Google-Smtp-Source: APiQypJguwi8ItKyGXOXPFwvT2LPkN2jfpDjKS7vQMZZWdVOTk2SZqEB1nmIHn+hHISHVh9ckh4b X-Received: by 2002:a05:6402:1f6:: with SMTP id i22mr25232edy.271.1587069670615; Thu, 16 Apr 2020 13:41:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587069670; cv=none; d=google.com; s=arc-20160816; b=ajr9DeT9iuRVMq1XUnYki/mzjawqa9wD3shEYHehjUAenx/T6TtA/Cvg1v0uxhSzPV cJHSLa5c9pFGAb2IQm11eY63AAWJsH5qiPkexOyReuJNQAsPwZVOqrhT0VRzc+x09Wsz PHZLFK/NIXmS5G9vxFXDvPWb6lU/bB6WKtChjGleFKEuwmKCjwOQx2c7ZiMKXWltESgP g7QpJ1kYgTpdCXwccPzMmlWth0MyXrZXl6Hb9P1LP46AstCkyLfUQ7f6zZqMpJTl36uC 0ByNrqNPKB1Rb9zlZFCuub7T5QudKJLuG6l82zKdwhqVB7pRkZMhFY4W7j+uIUds/wkH H3+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=KWMV+mhx4ibQwYFyvvIVJnvWsgDS+Bqiq3YI05enaRU=; b=vLufQiyYjIhRKcr4Ye/dlS1FG4pf6S9AWNde8rWrGNXoSuee5hd/LUBFvg+EJ7jxAi THOe4O01WE2a1VKY82zFMc8E9QQUHY5+phF6CIIZ5/wOzW89LBggowBrd5sysWMjlAqV l1vowMcauWaacYxmKnhqaTJrYxnLYTzg38pQi2OxiCFUQNGQMNmDt+8Z/kb5vWxKNbTM hRIsK2uqmIbM/ge+/bi+dvyam89f5b2B7vTAhTA84BsDR/8axk6ZxHF6Q7CbmLFtXWO8 WXyPepJR6gjcqX14M3l50NncN9FZCurdpUcdkSWo80Y+3G/TcuYcNIZy2u6gTVIRAVcT nolw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=UhIfmKrR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g7si3493372edq.580.2020.04.16.13.40.48; Thu, 16 Apr 2020 13:41:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=UhIfmKrR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389906AbgDPRW7 (ORCPT + 99 others); Thu, 16 Apr 2020 13:22:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2388338AbgDPRW4 (ORCPT ); Thu, 16 Apr 2020 13:22:56 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3B72C061A0C for ; Thu, 16 Apr 2020 10:22:56 -0700 (PDT) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3145897D; Thu, 16 Apr 2020 19:22:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1587057775; bh=bTfJZ+75ndQOARxqXeuOxJFXyYt8RzIOrx7gvZeGM5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UhIfmKrRUNzc0klYEFAND1I5BO8RI0zq5GjDoZW2tHzP9cxwLQYneLPVCYJ6bl+02 XVgqihJFaXzbRtD0iNQStH+CzDk+kbln0wVmmiI0D6U496AnHN2pJmiKOEEsagB50g PBTy+E/IcEX3vmXwbUlbFLnp1q9O0VQPqx3NMc+I= Date: Thu, 16 Apr 2020 20:22:43 +0300 From: Laurent Pinchart To: Enric Balletbo i Serra Cc: linux-kernel@vger.kernel.org, Collabora Kernel ML , matthias.bgg@gmail.com, drinkcat@chromium.org, hsinyi@chromium.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 2/7] drm/bridge_connector: Set default status connected for eDP connectors Message-ID: <20200416172243.GL4796@pendragon.ideasonboard.com> References: <20200416155720.2360443-1-enric.balletbo@collabora.com> <20200416155720.2360443-3-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200416155720.2360443-3-enric.balletbo@collabora.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Enric, Thank you for the patch. On Thu, Apr 16, 2020 at 05:57:14PM +0200, Enric Balletbo i Serra wrote: > In an eDP application, HPD is not required and on most bridge chips > useless. If HPD is not used, we need to set initial status as connected, > otherwise the connector created by the drm_bridge_connector API remains > in an unknown state. > > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart > --- > > Changes in v2: None > > drivers/gpu/drm/drm_bridge_connector.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c > index c6994fe673f3..a58cbde59c34 100644 > --- a/drivers/gpu/drm/drm_bridge_connector.c > +++ b/drivers/gpu/drm/drm_bridge_connector.c > @@ -187,6 +187,7 @@ drm_bridge_connector_detect(struct drm_connector *connector, bool force) > case DRM_MODE_CONNECTOR_DPI: > case DRM_MODE_CONNECTOR_LVDS: > case DRM_MODE_CONNECTOR_DSI: > + case DRM_MODE_CONNECTOR_eDP: > status = connector_status_connected; > break; > default: -- Regards, Laurent Pinchart