Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1690182ybz; Thu, 16 Apr 2020 13:46:01 -0700 (PDT) X-Google-Smtp-Source: APiQypJ6Zk3a73XjsictDTgAenD1gChwrv7pxbqNJ6dI2e+Wt4TdyvNDvhMVxnSTOX9qpGMuAevK X-Received: by 2002:a50:d552:: with SMTP id f18mr32882edj.341.1587069960909; Thu, 16 Apr 2020 13:46:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587069960; cv=none; d=google.com; s=arc-20160816; b=RSrjpmIzhrKHU40ZMDZdg14B6o3GHF7aOyUJnKukJtcGoTGRH7eQ3TpC4C0FAppfeb 1tzgWECMZfL5NT/cnbCAJ9Dzg9XwJaSjQkLSO+wpX9plyk/NL0Av5rBBP8GsxrZx/6Q3 I41oQHjdD/C7idTaL66jE2PtigzgLfy4h6nLfl86q3PsW1T1W3hmMnvOmIy65HcX7Yuj RaHKwiafLJt1Xs+cQzjtELFuYDGrwY72EcWBZpYS1yaz9gNAbgjTNE+n+xLovTFkloNI 29+yohKhpK8lmlEqKiZtAy7mlpiBDptSynmmHx/5It0I6ZjnSAxV0i7GiETKmyzpmPQJ ftIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=FlfCnzRGZwsVDz2sKD69Svo0dgnN7pcGb7Sk4Jusy1I=; b=P159O498gRDX3IohnaUcZ+1zrbVXZP43/ouQbA8GjGu8gnRGuPSB/cdD9F/bddwqZF 8nNy/9ckhFBltNR52s7eowcdJZ5zRjdKtOatetHIei9xxc7AAH8OKFLSrdf28DUrMOQx efbKcl9z5RJEG8cDusF7YzXOvDUrMINUO0+wA10HyBMUxhBJefHeKScQa2SDviA1AEOf 530tL7CgVqvxBx5EIQ2gOqbcJ+99GjseSm9ZojNcxMTrxYAAg6ZUHW8PHMuAMHHdgN9C MhTYaf6udVc+4eRNUsct6W5EZMwWS6HSckjBYX+00DbgLH64aquba+s030Q3iKH/2FaI pHGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e15si6420422ejc.208.2020.04.16.13.45.37; Thu, 16 Apr 2020 13:46:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728556AbgDPTpT (ORCPT + 99 others); Thu, 16 Apr 2020 15:45:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726164AbgDPTpS (ORCPT ); Thu, 16 Apr 2020 15:45:18 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20BBAC061A0C; Thu, 16 Apr 2020 12:45:18 -0700 (PDT) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 16AB32A1199; Thu, 16 Apr 2020 20:45:16 +0100 (BST) Date: Thu, 16 Apr 2020 21:45:13 +0200 From: Boris Brezillon To: Christophe Kerello Cc: , , , , , , , marex@denx.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v2 08/12] mtd: rawnand: stm32_fmc2: use FIELD_PREP/FIELD_GET macros Message-ID: <20200416214513.43b7b6e1@collabora.com> In-Reply-To: <1586966256-29548-9-git-send-email-christophe.kerello@st.com> References: <1586966256-29548-1-git-send-email-christophe.kerello@st.com> <1586966256-29548-9-git-send-email-christophe.kerello@st.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Apr 2020 17:57:32 +0200 Christophe Kerello wrote: > This patch removes custom macros and uses FIELD_PREP and FIELD_GET macros. Oh, nice. I didn't know about these macros. This could have saved me from defining a whole bunch of setters/getters in driver code...