Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1690275ybz; Thu, 16 Apr 2020 13:46:06 -0700 (PDT) X-Google-Smtp-Source: APiQypKo18cCNj/NPzGAwHdHKu8CuF9+C8uMgNf6wJhhzrnHbXVDy1sbrFx5BJPCmmu854ERxy7/ X-Received: by 2002:a17:906:5fd2:: with SMTP id k18mr11144074ejv.243.1587069966646; Thu, 16 Apr 2020 13:46:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1587069966; cv=pass; d=google.com; s=arc-20160816; b=KrFGphGSYJnTOvxnvXPybfZOSHgKxojmTTipbzoVVTGJ/bg8z5RYtAdaeDXQc+LS9S LPUqmoRTUVzllQOr6HbKs8oGImWoQTm8Tlqmg54jNAsbYbMtdQO2h5Q98BbAOIZ8GwMY 6UYE0q1+3jJLlCO3owZEfUpHxIxIlRG3nQtY/XidKWyFDbzKepWI7aUvAaGldw9OmA6O 52n8OjhTCqExUq64B+cqLRczY0pA3AMwUd5NjO5gzKzKKLr5T6v75M3WFPfyPygjZB3y eMgNupXQ4+BdO+IjsB7wpCKEu3cSFVLq++N1v30WsdZeeRkC150LQZtL6qF3eFS1d0s0 sxSA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=nUC1s/XNOjLPhGKh77zIdZcv0ikaQzwppB1UpUBH+CU=; b=V/epoz4it/kBU7jOYcXxk2M2MDS0bVX+md241DsGymEvUwpaoly2RGaIAjwJdsj/mu CwiY2u0uCyTr/wii4FnmT3Slzb9f+HZKYSz6PHNTqaaZ8x3WFXcm10R329MyKJCU1Xfy TmCNJXllO556XDXtfZgnLYkO10P7J+2MJXZa8C3pd1TsDTVZwQB4FzE+oltR30e4XKj8 9PiFyWj4K/g8VB38sK5EMNhN3dyeWZru9Fvs47dHeJ5HR7++i/HEDZW+PKq0L4iEUZmQ MpP3r8jPAxgjDkTmbTOyhXSWrcB2A5G8avb4CKuUEqajR9uxrDjJi7ii9HXb1apPlB2r GyCw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@xilinx.onmicrosoft.com header.s=selector2-xilinx-onmicrosoft-com header.b=roL3XP1A; arc=pass (i=1 spf=pass spfdomain=xilinx.com dkim=pass dkdomain=xilinx.com dmarc=pass fromdomain=xilinx.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y12si11811691ejm.386.2020.04.16.13.45.43; Thu, 16 Apr 2020 13:46:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@xilinx.onmicrosoft.com header.s=selector2-xilinx-onmicrosoft-com header.b=roL3XP1A; arc=pass (i=1 spf=pass spfdomain=xilinx.com dkim=pass dkdomain=xilinx.com dmarc=pass fromdomain=xilinx.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390232AbgDPS0t (ORCPT + 99 others); Thu, 16 Apr 2020 14:26:49 -0400 Received: from mail-bn8nam12on2071.outbound.protection.outlook.com ([40.107.237.71]:33582 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727901AbgDPS0q (ORCPT ); Thu, 16 Apr 2020 14:26:46 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JX6/1VXfeWzeHH8snX1A5hVTat7/eoM3u7uNAGOVFlj/TRIrzDiLfHpJgj4OTx6lyqWiGihpRffc1eC/NXg0zE2qr4ZFPyXP8F5gdaWmb0UyoQ78136VOnzS8nCj3xQRKmPNvbZ5ALcRWIWCIkfLmCwM7dMY2kcMrwP15h43N/S2lu/bjXlNhCwUOxc85M7q2N+AOhs2BVW8uLv5SHwWGYaUugWvQx8mJGI0ZHxD4qWpJs/M3D7bpLpbDIAmvAQemWTR/fX65m7eUK360prvYQ+m7CWi7wz9d4Anw5wjTR5Xtau1uRIyeFC9pYI0zS/JF/qQv6yjVkE5spDYEdkjxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nUC1s/XNOjLPhGKh77zIdZcv0ikaQzwppB1UpUBH+CU=; b=bSRLsvCFGuB1Uc8emdC4KIbL+xUX5PMfgLrmrph0g9h0dp2OLNY8EPhzXV9BdAwnSGHdIyIQRWW4AwS+kO1IRuwoZTU6sEaDXWMtXObc4xMpW9bEQqPsTEWg2guEgG7d2zCSYDC196Hqpa2yrA8RGm2Xw/TcvFrHaH8vE3y/aLGb2O5wJFUgXY1tPXtBhpIyqjSJO1hdYg5wSWaAtwW8rcQr7o0JhFWb89rz2cer5zKImPeN7bHH9FjUfJYxI/BpZf7z/JRe62ohdXvwEaZsgqjtNEbT3Ay8iEyMqCzrACII5tRsPA4+Tz7fvWrVyfxHAemx3VLFqdJ7a3XBS/v6sA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nUC1s/XNOjLPhGKh77zIdZcv0ikaQzwppB1UpUBH+CU=; b=roL3XP1AzJvkT5bpq/g67mYHLgb4RpbNrjiJpmoc9QGWBdtrXunWF4QfNHM1PpOHNPahhwV14vGzXaVfiyqtKEmqlVR8yJebBWrEBPF2mdhL36S2FETD/+47G75IIFTsioC02ttlb178vylZ8OD/66C6XscOU5UHGkZ9yHjTKLc= Received: from MW2PR02MB3770.namprd02.prod.outlook.com (2603:10b6:907:4::15) by MW2PR02MB3772.namprd02.prod.outlook.com (2603:10b6:907:3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.24; Thu, 16 Apr 2020 18:26:43 +0000 Received: from MW2PR02MB3770.namprd02.prod.outlook.com ([fe80::1846:3334:1289:1f7d]) by MW2PR02MB3770.namprd02.prod.outlook.com ([fe80::1846:3334:1289:1f7d%5]) with mapi id 15.20.2900.028; Thu, 16 Apr 2020 18:26:43 +0000 From: Harini Katakam To: "nicolas.ferre@microchip.com" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , Claudiu Beznea CC: "linux-kernel@vger.kernel.org" , "David S. Miller" , Alexandre Belloni , "pthombar@cadence.com" , "sergio.prado@e-labworks.com" , "antoine.tenart@bootlin.com" , "f.fainelli@gmail.com" , "linux@armlinux.org.uk" , "andrew@lunn.ch" , Michal Simek , Rafal Ozieblo Subject: RE: [PATCH 1/5] net: macb: fix wakeup test in runtime suspend/resume routines Thread-Topic: [PATCH 1/5] net: macb: fix wakeup test in runtime suspend/resume routines Thread-Index: AQHWFBbHfzHTc4wzLUmw4FeI8KiR0Kh8D02g Date: Thu, 16 Apr 2020 18:26:42 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=harinik@xilinx.com; x-originating-ip: [149.199.50.130] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2b48911d-bcbb-41bc-9ec0-08d7e233b68f x-ms-traffictypediagnostic: MW2PR02MB3772:|MW2PR02MB3772: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0375972289 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR02MB3770.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(346002)(376002)(39860400002)(396003)(136003)(366004)(76116006)(5660300002)(2906002)(26005)(15650500001)(8676002)(9686003)(7416002)(8936002)(33656002)(186003)(4326008)(81156014)(55016002)(316002)(110136005)(54906003)(52536014)(64756008)(66476007)(66946007)(66446008)(66556008)(478600001)(71200400001)(86362001)(53546011)(7696005)(6506007);DIR:OUT;SFP:1101; received-spf: None (protection.outlook.com: xilinx.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: n6oB8HsivFgRC9RAKqYVozDBokyrxxSza462tf4RuCrPsh3jztL3c8pPIaVGtPG34NYVHLknl8/yW0UwnpUKlNtXg5F5dkTndb3ZiZMGiAi7mauFFIcpLtpc7K7AxgHb1exPtpkSEk3IUjHl5Xqhkh1OPDgKSKV1mcvZjDl6aWiAs/dBuduO3bJrVyM6m39ykIQEEB4h2M4H1kk4pIJ4XP5Woh0tG+9bl27zPrMS/993ZWcNUGjNpycl6Dj4N/tBGakXwEN/YFzt7KuEu2Hlfq+avFWmVVge2VEll0ysSElR3YCnUqykK/uxzk4m4vZdFr6U7efn9H9sNQzv2TLJ9DAHUFNRkBtZBXLIyDuKWGrv/QUxAYA8Nkuuy9s4SGRVbHKBNLH3/QGEVLaD1uw3VEdZ2LHBUsd3wx45VxEyVGCb7L7bToiOF1kCloxDqUnp x-ms-exchange-antispam-messagedata: rukRdoh5nrIZrjspW1cS0vzR5wqQ5c3Kku/6lZYVqeRYy6ENycX7KDyuiwcnsifhCRAdSDNUfHHyolbg42bQBfnpWFhPiybtpaFvh/o1SoPdZLCpkccjBEVaYbOQchJdQtAB/zGjSKqWHlc4z3pD8Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b48911d-bcbb-41bc-9ec0-08d7e233b68f X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2020 18:26:42.9260 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1xPp7TqMdz9RFR50fQRYbdKGZPvLuOLUGtrTLMzFtVY53is5QaenzGJfcTI3jDz0lxhFunGv99OeR6d0nadXEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR02MB3772 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nicolas, > -----Original Message----- > From: nicolas.ferre@microchip.com [mailto:nicolas.ferre@microchip.com] > Sent: Thursday, April 16, 2020 11:14 PM > To: linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org; Claudiu > Beznea ; Harini Katakam > > Cc: linux-kernel@vger.kernel.org; David S. Miller ; > Alexandre Belloni ; pthombar@cadence.com; > sergio.prado@e-labworks.com; antoine.tenart@bootlin.com; > f.fainelli@gmail.com; linux@armlinux.org.uk; andrew@lunn.ch; Michal Simek > ; Nicolas Ferre ; Rafal > Ozieblo > Subject: [PATCH 1/5] net: macb: fix wakeup test in runtime suspend/resume > routines >=20 > From: Nicolas Ferre >=20 > Use the proper struct device pointer to check if the wakeup flag and wake= up > source are positioned. > Use the one passed by function call which is equivalent to &bp->dev- > >dev.parent. >=20 > It's preventing the trigger of a spurious interrupt in case the Wake-on-L= an > feature is used. Sorry I have some mail issues; meant to reply earlier. Tested patches 1, 2, 3 in this set and they work for me. I'll try patch 4; it looks similar to what I'm using locally but I'll add w= hatever tie-off queue handling is required on top of your series, thanks. Regards, Harini