Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 16 Apr 2020 22:04:49 +0200
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Tony Lindgren <tony@atomide.com>
Cc:     "H. Nikolaus Schaller" <hns@goldelico.com>,
        Evgeniy Polyakov <zbr@ioremap.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
        Adam Ford <aford173@gmail.com>,
        "Andrew F . Davis" <afd@ti.com>, Vignesh R <vigneshr@ti.com>
Subject: Re: [PATCHv3] w1: omap-hdq: Simplify driver with PM runtime
 autosuspend
Message-ID: <20200416220449.17068b21@aktux>
In-Reply-To: <20200416184638.GI37466@atomide.com>
References: <20191217004048.46298-1-tony@atomide.com>
        <7B8C7DD9-095B-48FC-9642-695D07B79E97@goldelico.com>
        <20200416184638.GI37466@atomide.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 16 Apr 2020 11:46:38 -0700
Tony Lindgren <tony@atomide.com> wrote:

> * H. Nikolaus Schaller <hns@goldelico.com> [200416 15:04]:
> > Hi Tony,
> > it looks as if something with this patch is broken on GTA04. For v5.6 a=
nd v5.7-rc1.
> >=20
> > HDQ battery access times out after ca. 15 seconds and I get temperature=
 of -273.1=C2=B0C...
> >=20
> > Reverting this patch and everything is ok again. =20
>=20
> Hmm OK interesting.
>=20
> > What is "ti,mode" about? Do we have that (indirectly) in gta04.dtsi?
> > Or does this patch need some CONFIGs we do not happen to have? =20
>=20
> Sounds like you have things working though so there should be no
> need for having ti,mode =3D "1w" in the dts.
>=20
> > > 	pm_runtime_enable(&pdev->dev);
> > > +	pm_runtime_use_autosuspend(&pdev->dev);
> > > +	pm_runtime_set_autosuspend_delay(&pdev->dev, 300); =20
>=20
> Care to check if changing pm_runtime_set_autosuspend_delay value
> to -1 in probe makes the issue go away? Or change it manually
> to -1 via sysfs.
>=20
> If that helps, likely we have a missing pm_runtime_get_sync()
> somewhere in the driver.
>=20
I have not tested yet with v5.7-rc1 (it is compiling right now),
but I have not seen any problems with init=3D/bin/bash on v5.6
and only a minimal set of modules loaded on gta04. I have seen that
42 for IDLEST

So might be something a bit more weird.

Regards,
Andreas