Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: /rGaqSomH6JQ5IaYpGBV+w2iwUE5gVD3OvTPRLnQFMEJV6NETE1SBaCWV2BBFf5HGTquhCPx5F
 FDRkn1f4EEHQ==
IronPort-SDR: +8q+macfzoj/N2yw0IIxmAGyRLpsfCjBnl+JlEA8LbLjUnvsb5Yf0/G791k12W+LlekB2AY143
 QV1s76f9+Z8A==
From:   "Huang\, Ying" <ying.huang@intel.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Andrea Righi <andrea.righi@canonical.com>,
        Minchan Kim <minchan@kernel.org>,
        Anchal Agarwal <anchalag@amazon.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] mm: swap: properly update readahead statistics in unuse_pte_range()
References: <20200416180132.GB3352@xps-13>
        <871romvmrh.fsf@yhuang-dev.intel.com>
        <20200416210646.774bae8c321e3a44d6ffa8c3@linux-foundation.org>
Date:   Fri, 17 Apr 2020 13:18:37 +0800
In-Reply-To: <20200416210646.774bae8c321e3a44d6ffa8c3@linux-foundation.org>
        (Andrew Morton's message of "Thu, 16 Apr 2020 21:06:46 -0700")
Message-ID: <87sgh2u1ua.fsf@yhuang-dev.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Andrew Morton <akpm@linux-foundation.org> writes:

> On Fri, 17 Apr 2020 11:01:22 +0800 "Huang\, Ying" <ying.huang@intel.com> wrote:
>
>> Andrea Righi <andrea.righi@canonical.com> writes:
>> 
>> > In unuse_pte_range() we blindly swap-in pages without checking if the
>> > swap entry is already present in the swap cache.
>> >
>> > By doing this, the hit/miss ratio used by the swap readahead heuristic
>> > is not properly updated and this leads to non-optimal performance during
>> > swapoff.
>> 
>> It's more important to describe why we need this patch in the patch
>> description.  So, please add some information about your use case.  And
>> please focus on the technical part instead of the business part.
>
> Confused.  I thought the changelog was quite good.  If "business part"
> means "end user effect of the patch" then that's a very important
> thing.

Previously, Andrea has described their use case in the cloud environment
to hiberate the guest and swapoff after resuming.  So swapoff
performance is important for them.  I think that should be included.
For the business part, I mean something like "Ubuntu used in AWS EC2", I
think that isn't important for the patch description.

>> Thanks!  But you don't need to do this.  You can add my Reviewed-by after
>> we have finished the work on patch description.
>
> Can you be more specific about how you want this changed?

Please use

Reviewed-by: "Huang, Ying" <ying.huang@intel.com>

Best Regards,
Huang, Ying