Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp258947ybz; Fri, 17 Apr 2020 00:15:26 -0700 (PDT) X-Google-Smtp-Source: APiQypJzppgYicIJNemrYzpVsm5A6d1wXu0SnhPjO8Q2gOBCQ61pEmvL1AQXf2svh6iCNsMwMGJW X-Received: by 2002:aa7:cd6a:: with SMTP id ca10mr1640255edb.332.1587107726387; Fri, 17 Apr 2020 00:15:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587107726; cv=none; d=google.com; s=arc-20160816; b=mseMN/8HvXKx6I+S3qnrUk7RFKf+GOc1GqPW0BJxUuhRgkr3iyXRhqL1wcMIJWz4i6 Jbk/yUHSXABHqM1xkvoiJ6Izhqao628N14lMozB+S7yam7FnUjgPpdnBkgwYHWZIrSpS nm5YrLb6t2mLs8fssjy5mNKCK8O8l+J7ISGi6jzhyCtJwJTBTFIFvKEzIlhOyfkBbzua F5qO05RvidLu9Rn+ikmfjZYVCySquO0dMDrllPz2l0vcQFFqJHcDTMEPx5GpkDnr/J0L C50zEyet9DuwpE6NK4rFWhtZ2piY+DJ0hNzxkKFdUutvekAKlD6jDBjKkSX91ApS2+Z8 uADw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=P+hOXlpgPkBZZez2Z6MfwFRrrHCB8TbFlF3LJc07ZEI=; b=E9PgO0SLpo/9M2alm7CC3jfcjfwH1AnYiltFYGwIe8ew78oKhZ9Zfn5VdieLDQiucq twrqJFlJj1bOC8IW42v+0Za0SGx4EGyVaY3D1aBInVdUGCawu8Oal9ndUiK7JqySLIRO 6ANKM4s82GONEF2RVC5styDElozajbzL9aQ71WlcTorwTfs80ZckH7vF7b4OnMmtJPvT FUIgnAiL9TJZXp1HuDnx5v0emeeY0wFxMr55yRddTP/RFZEer/TSVnimEDob2rTfs1Od kESg9Vb3A/13ciCkD+hLX5EXsGhmipyQ5H+DLX4/RBPcO6e1HTmNUBbVwRPWuykibiX3 XMHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u26si13783729ejj.44.2020.04.17.00.15.03; Fri, 17 Apr 2020 00:15:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728663AbgDQHNc (ORCPT + 99 others); Fri, 17 Apr 2020 03:13:32 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2343 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728159AbgDQHNc (ORCPT ); Fri, 17 Apr 2020 03:13:32 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 75200DDCB0D10D3F5917 for ; Fri, 17 Apr 2020 15:13:30 +0800 (CST) Received: from huawei.com (10.175.124.28) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Fri, 17 Apr 2020 15:13:19 +0800 From: Jason Yan To: , CC: Jason Yan , Hulk Robot Subject: [PATCH] locking/static_keys: make old_true_key and old_false_key static Date: Fri, 17 Apr 2020 15:39:45 +0800 Message-ID: <20200417073945.45851-1-yanaijie@huawei.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following sparse warning: lib/test_static_keys.c:15:19: warning: symbol 'old_true_key' was not declared. Should it be static? lib/test_static_keys.c:16:19: warning: symbol 'old_false_key' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Jason Yan --- lib/test_static_keys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/test_static_keys.c b/lib/test_static_keys.c index 42daa74be029..41658c5bf770 100644 --- a/lib/test_static_keys.c +++ b/lib/test_static_keys.c @@ -12,8 +12,8 @@ #include /* old keys */ -struct static_key old_true_key = STATIC_KEY_INIT_TRUE; -struct static_key old_false_key = STATIC_KEY_INIT_FALSE; +static struct static_key old_true_key = STATIC_KEY_INIT_TRUE; +static struct static_key old_false_key = STATIC_KEY_INIT_FALSE; /* new api */ DEFINE_STATIC_KEY_TRUE(true_key); -- 2.21.1