Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp269111ybz; Fri, 17 Apr 2020 00:29:06 -0700 (PDT) X-Google-Smtp-Source: APiQypIARGFPtikTASNQ/+lv4PnHupWb5jBr5eT18yYH8KuSRccqfJkzgJqz/AGXUs3WJm1me54G X-Received: by 2002:a50:a642:: with SMTP id d60mr1669828edc.351.1587108546516; Fri, 17 Apr 2020 00:29:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587108546; cv=none; d=google.com; s=arc-20160816; b=cZL0XBrJDpIxudVE0AukZmTipJKKUt1Sad7/6/gp+wEkhhNIqDtsla356wzthLQMmM O142tlkfqkckhGBR6X+Vkx+ygTlHt5nDQHAYq6lcY2SjRi/WRkN4nonAjvG+jhJuOR8/ SEAg2PENDgRVzgAbHVmtB7bwfL0EIGOcCAhcC1yRhX393OdEFYTS8ne0We7Zwelblpv7 dBvtRldD8C7g7eCuKrziu0neg2hpV/df3ds096ZB0+xeX6MlpTfXVBsm0sWmU8nEFPaP yZi6qPCuA1E+OyeS1ZwlOMZRwu8a1N7vxsC0WxGWMSYyZCXz5/f8p6rWJm62PC71oB4+ zQ0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=xvC0GnFwsJc1BQxggXNfDfi/6shz4/OqiZ1hSdMYKzc=; b=Wi80WQ9g8IqECjtV+xFQ1540tShsYMcQKgOKk85SbGXDkraN5fxQ1RBCItuvtpusbu bR71d6y1oyuowggg1lv4/gbOz04id826V0mBwM7QXPvF5G+LVjwN0rfGcma3CcSztLDO O7GLOyTht7tMXndOpKtWcsLDLCmJJASnQ0/qn3+dOGu1+QLJ8BaKKNGq0op9hZml+5gQ 36Cnmq7feToxbliDHdbYZRwjWFnZQmIQGqh7PqJyW8HsQ1+Of7XA+D+JsTxwSyiE8Nq0 t7x+qOgKT5Bet6PpEfDh4wl/4qqKca/yRqnhXs9yJi/yvR3EZLrA0LYIJ2ILKX5lHxuH 2wPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a9si345524edf.243.2020.04.17.00.28.43; Fri, 17 Apr 2020 00:29:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728981AbgDQHZC (ORCPT + 99 others); Fri, 17 Apr 2020 03:25:02 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:58616 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728419AbgDQHZC (ORCPT ); Fri, 17 Apr 2020 03:25:02 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id CC62B250C67C28D8866C; Fri, 17 Apr 2020 15:25:00 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 17 Apr 2020 15:24:56 +0800 Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix quota_sync failure due to f2fs_lock_op To: Jaegeuk Kim CC: , , References: <20200409173056.229855-1-jaegeuk@kernel.org> <77e9f2e6-f3f3-8ca9-e6b5-3d57c4d2acc5@huawei.com> <20200416213946.GA196168@google.com> From: Chao Yu Message-ID: Date: Fri, 17 Apr 2020 15:24:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200416213946.GA196168@google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/17 5:39, Jaegeuk Kim wrote: > f2fs_quota_sync() uses f2fs_lock_op() before flushing dirty pages, but > f2fs_write_data_page() returns EAGAIN. > Likewise dentry blocks, we can just bypass getting the lock, since quota > blocks are also maintained by checkpoint. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks,