Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 17 Apr 2020 08:31:55 +0100
From:   Will Deacon <will@kernel.org>
To:     Jason Yan <yanaijie@huawei.com>
Cc:     tglx@linutronix.de, linux-kernel@vger.kernel.org,
        Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] samples/hw_breakpoint: make sample_hbp static
Message-ID: <20200417073155.GA10812@willie-the-truck>
References: <20200417073542.42721-1-yanaijie@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200417073542.42721-1-yanaijie@huawei.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Apr 17, 2020 at 03:35:42PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
> 
> samples/hw_breakpoint/data_breakpoint.c:24:19: warning: symbol
> 'sample_hbp' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  samples/hw_breakpoint/data_breakpoint.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/hw_breakpoint/data_breakpoint.c b/samples/hw_breakpoint/data_breakpoint.c
> index 418c46fe5ffc..37c4f0ea8e53 100644
> --- a/samples/hw_breakpoint/data_breakpoint.c
> +++ b/samples/hw_breakpoint/data_breakpoint.c
> @@ -21,7 +21,7 @@
>  #include <linux/perf_event.h>
>  #include <linux/hw_breakpoint.h>
>  
> -struct perf_event * __percpu *sample_hbp;
> +static struct perf_event * __percpu *sample_hbp;
>  
>  static char ksym_name[KSYM_NAME_LEN] = "jiffies";
>  module_param_string(ksym, ksym_name, KSYM_NAME_LEN, S_IRUGO);

Acked-by: Will Deacon <will@kernel.org>

Will