Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp344834ybz; Fri, 17 Apr 2020 02:10:00 -0700 (PDT) X-Google-Smtp-Source: APiQypJwwwJRMyiOsQKdWQ85Sz6vv7Oe2sZsK0yOq5pJBsk+8PkAk4FouNAc3U/mVFumE3Ic2cB4 X-Received: by 2002:a17:906:1603:: with SMTP id m3mr2122464ejd.205.1587114600333; Fri, 17 Apr 2020 02:10:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587114600; cv=none; d=google.com; s=arc-20160816; b=U4ScGqWdyjEhQTdFaAWT0PGv/gRf+jOwsC5nFNX5cDRQG+cjh/mAdnmPWygJgHXigs SFnsvut0FWUUPcCjF+SCtmQ91gTRQY1eEmThuvY84VegXSmQQA8wJLNaIwUYvtaPdt8b JMtswVxB8tKNO0K81s0mE5sEbWJYJ914qvhGooNcPs1uQnpJ0wHtPf+RCFMFjOZqUd50 kej2MWMUXYhNwghVnpUfECCZ0tRg30CIo1lLP9l8zlta8CJd9QDNy87G8oT+hHYxZC5n y/fW3Q1GC00rIY8o8ar381OY3zdFvLFt2mkdAYaw07m9QpaixY4SnLDQr6XU+xUENBs8 50xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=jM02KSArfboqLWyz+YqV3DbUa9k4ur+YUYsDM60s9Ig=; b=kPlM1C5TqLwpr8S0iQobWCPipaek4T9A2FFvqmSrX+57MEY3labJjsnDryySMMEOrS v5xPRjrW2jx/OGQMSIuPT6R8eHIOPyRw8eXfnZqS6Rj1NLAfvtO/hkLaqKzJaL5Q+aEP x27k4wU8yWoFs463DmAWPrSWLLEMSTJQAQsP+gOzTO/gD4Fox1m8npbs7q5o/AbzTgNr GG5po5cZVpd/Imwy5wY3GO0To8a2rqbKWLygWMdzjpC7inW48Rmm3WbGSp4QitiFS0yj oIi3M4Tg92hSF+U9ygL1YRSq2okfoOVGfJSBY936ONehA5aHn51FU3Znxqj/FgBLKjXe UAzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z13si12036418eju.18.2020.04.17.02.09.37; Fri, 17 Apr 2020 02:10:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730138AbgDQJIG (ORCPT + 99 others); Fri, 17 Apr 2020 05:08:06 -0400 Received: from mga06.intel.com ([134.134.136.31]:63669 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729920AbgDQJIG (ORCPT ); Fri, 17 Apr 2020 05:08:06 -0400 IronPort-SDR: 2MPfzQptYq8LiUN6kNNXHRbzpc5vW3YXr06vT86ngSqGe8APKcD4ZgaQXlU8yPaNzVcU+msbiB /8JJOCYyC70w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2020 02:08:05 -0700 IronPort-SDR: jvMrM+Wg0TzZleKwbmoq0OBHeWB9RDLsiHFsRIDtB3wYf3jYPSBKF26C//gewkVl9dNEOF8sqa jyluc0XR7GNg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,394,1580803200"; d="scan'208";a="364275831" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 17 Apr 2020 02:08:00 -0700 Received: by lahna (sSMTP sendmail emulation); Fri, 17 Apr 2020 12:07:59 +0300 Date: Fri, 17 Apr 2020 12:07:59 +0300 From: Mika Westerberg To: "Ronald G. Minnich" Cc: "Ronald G. Minnich" , Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Boris Brezillon , Jethro Beekman , Enrico Weigelt , Thomas Gleixner , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: spi-nor: add cmdlineparts to intel-spi Message-ID: <20200417090759.GN2586@lahna.fi.intel.com> References: <20200416162830.183725-1-rminnich@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200416162830.183725-1-rminnich@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 16, 2020 at 09:28:28AM -0700, Ronald G. Minnich wrote: > On Intel platforms, the usable SPI area is located several > MiB in from the start, to leave room for descriptors and > the Management Engine binary. Further, not all the remaining > space can be used, as the last 16 MiB contains firmware. > > To make the SPI usable for mtdblock and other devices, > it is necessary to enable command line partitions so the > middle usable region can be specified. > > Add a part_probes array which includes only "cmdelineparts", > and change to mtd_device_parse_register to use this part_probes. > > Signed-off-by: Ronald G. Minnich I guess the $subject should be something like: mtd: spi-nor: controllers: intel-spi: Add support for command line partitions The patch itself looks good to me, Reviewed-by: Mika Westerberg