Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp364643ybz; Fri, 17 Apr 2020 02:34:01 -0700 (PDT) X-Google-Smtp-Source: APiQypIFUj7ErPlNoFuyvrbKWfWywOTBdxsjzhs+1GrtEY7m07uJurPH3mHl4ukdoyv8xfOU/3Wx X-Received: by 2002:a50:9e2a:: with SMTP id z39mr2161389ede.178.1587116041101; Fri, 17 Apr 2020 02:34:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587116041; cv=none; d=google.com; s=arc-20160816; b=G6qdLBDQEgTCXEmy4QFiCqHfMugJF85G9GlJpTUzEb6+EcvafMvWRODKqN4Mbm813s +F8yYVWr8J5MDPPtKMx6X46z5Zu0oStj4zieH8HYpdi7xCYNjFqhp8/4ZyfKGTKzxEyy GjSZILusu8BN0evJNfDykaF+yKnZCEzDbpdVvMb6ln0PDTYiI0fcFmh77DjgdR/K355L hLr4K/Bp6SgQWQScUC/0DgipQ+ocp72BStKKDx8XpC+nJuBGb3gR93V4/M9BYmpkhvsM 2Hh8hyBagc/90/jarbdeQ2MTBOT0yRR6YmZKlQxRrVYpAklVq0UHcUjmCBfWpPPLFASF Zrjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=m22HmqiQl7y9h5wARzFeY94ky6MCvLfuROwZp+YEg3M=; b=w5jLncHfrASsVXFU2fpxl1QQR64l6me4Nn/pK3bIrUpdALHiG5YgJtyLSn/kjwACzr DETIQqZbljNcStCw+jKedAW3C1a/MYLgFRqu9Yo9qosHh6vKco9ZoyJja8LBot6JhqUJ ejuHrIUW2HLRyMRt372262kQrQ6Svwb33AtZhzRz7gqKS8wvQ+LkMNaNMrBKf9r+S5Kh eFyiGueiC59HZB5EgiYXyGGKVSSYPwSia862EGDrlYfuXPm4+abH9dj0gvk8dwIPD/64 US5iFr4smH6S0YwfGr5gytGanTSMlqr360j/au1eMx/ZdZdh4nwccF4oef7P+FAMk5Bg VOkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z1si16088440edp.464.2020.04.17.02.33.38; Fri, 17 Apr 2020 02:34:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730317AbgDQJcB convert rfc822-to-8bit (ORCPT + 99 others); Fri, 17 Apr 2020 05:32:01 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:40265 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730233AbgDQJcA (ORCPT ); Fri, 17 Apr 2020 05:32:00 -0400 Received: by mail-oi1-f193.google.com with SMTP id t199so1543589oif.7; Fri, 17 Apr 2020 02:31:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Xdw7qE++WbJcYYYVLLUf8m1JuzUUrBMPMGWetZ3yNmk=; b=umjJwxwdZaZ9suhke1DqinrYaXbobkasW/nYM7VcjfUZssTXIpgDBJ4S7TzzzcCIbU 3pOBuyrUOza3erBxhjDDROKuSmyQnkU5OD5JmUNHoOd4pL7qBKQ1+FE+GD2+X+TJsRg8 GelTKUOF0UwvvI8488HYvh6MqT0c7fiSo7lk+1R9dkCqWBqY2aER34VPCq+oC83SQghm xJ0r9h1Dvr75ISlOkz9zB1v0LmXWmjCDYILCkFyX7bNVuYBXJzHnoKZ5yhJvFiBmsieR 6wETxkCiuNHJPxTWo+uSNN5OURyGsa/uiG8XGy4UdEZX04rMmufBwbLYz/KWTeRRbp1g VN3g== X-Gm-Message-State: AGi0PuZcsWfKsnF4IkGOOuBUPMTYo0QvIQYsJpvuIxG8UA5UG7Yhwgs4 eQk6eM2AQOrNuaItQI7drBO+J+bjDhfPHnERFUA= X-Received: by 2002:a05:6808:8cf:: with SMTP id k15mr1541313oij.54.1587115918339; Fri, 17 Apr 2020 02:31:58 -0700 (PDT) MIME-Version: 1.0 References: <20200417092042.11994-1-yanaijie@huawei.com> In-Reply-To: <20200417092042.11994-1-yanaijie@huawei.com> From: Geert Uytterhoeven Date: Fri, 17 Apr 2020 11:31:46 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: rza1: remove unused 'rza1l_swio_pins' To: Jason Yan Cc: Linus Walleij , Nishka Dasgupta , Linux-Renesas , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Hulk Robot , Chris Brandt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jason, On Fri, Apr 17, 2020 at 10:54 AM Jason Yan wrote: > Fix the following gcc warning: > > drivers/pinctrl/pinctrl-rza1.c:401:35: warning: ‘rza1l_swio_pins’ > defined but not used [-Wunused-const-variable=] > static const struct rza1_swio_pin rza1l_swio_pins[] = { > ^~~~~~~~~~~~~~~ > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Thanks for your patch! > --- a/drivers/pinctrl/pinctrl-rza1.c > +++ b/drivers/pinctrl/pinctrl-rza1.c > @@ -398,15 +398,6 @@ static const struct rza1_bidir_pin rza1l_bidir_pins_p9[] = { > { .pin = 5, .func = 3 }, > }; > > -static const struct rza1_swio_pin rza1l_swio_pins[] = { > - { .port = 2, .pin = 8, .func = 2, .input = 0 }, > - { .port = 5, .pin = 6, .func = 3, .input = 0 }, > - { .port = 6, .pin = 6, .func = 3, .input = 0 }, > - { .port = 6, .pin = 10, .func = 3, .input = 0 }, > - { .port = 7, .pin = 10, .func = 2, .input = 0 }, > - { .port = 8, .pin = 2, .func = 3, .input = 0 }, > -}; > - > static const struct rza1_bidir_entry rza1l_bidir_entries[RZA1_NPORTS] = { > [1] = { ARRAY_SIZE(rza1l_bidir_pins_p1), rza1l_bidir_pins_p1 }, > [3] = { ARRAY_SIZE(rza1l_bidir_pins_p3), rza1l_bidir_pins_p3 }, rza1l_swio_pins[] is unused because rza1l_swio_entries[] refers to the wrong array. So I'd rather see a patch to fix that instead. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds