Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200417092042.11994-1-yanaijie@huawei.com>
In-Reply-To: <20200417092042.11994-1-yanaijie@huawei.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Fri, 17 Apr 2020 11:31:46 +0200
Message-ID: <CAMuHMdUfwbsfLNSxJLqkwTNEQims1RHBn_EwBvBUqEZshHZHdQ@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: rza1: remove unused 'rza1l_swio_pins'
To:     Jason Yan <yanaijie@huawei.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Nishka Dasgupta <nishkadg.linux@gmail.com>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>,
        Chris Brandt <Chris.Brandt@renesas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jason,

On Fri, Apr 17, 2020 at 10:54 AM Jason Yan <yanaijie@huawei.com> wrote:
> Fix the following gcc warning:
>
> drivers/pinctrl/pinctrl-rza1.c:401:35: warning: ‘rza1l_swio_pins’
> defined but not used [-Wunused-const-variable=]
>  static const struct rza1_swio_pin rza1l_swio_pins[] = {
>                                    ^~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Thanks for your patch!

> --- a/drivers/pinctrl/pinctrl-rza1.c
> +++ b/drivers/pinctrl/pinctrl-rza1.c
> @@ -398,15 +398,6 @@ static const struct rza1_bidir_pin rza1l_bidir_pins_p9[] = {
>         { .pin = 5, .func = 3 },
>  };
>
> -static const struct rza1_swio_pin rza1l_swio_pins[] = {
> -       { .port = 2, .pin = 8, .func = 2, .input = 0 },
> -       { .port = 5, .pin = 6, .func = 3, .input = 0 },
> -       { .port = 6, .pin = 6, .func = 3, .input = 0 },
> -       { .port = 6, .pin = 10, .func = 3, .input = 0 },
> -       { .port = 7, .pin = 10, .func = 2, .input = 0 },
> -       { .port = 8, .pin = 2, .func = 3, .input = 0 },
> -};
> -
>  static const struct rza1_bidir_entry rza1l_bidir_entries[RZA1_NPORTS] = {
>         [1] = { ARRAY_SIZE(rza1l_bidir_pins_p1), rza1l_bidir_pins_p1 },
>         [3] = { ARRAY_SIZE(rza1l_bidir_pins_p3), rza1l_bidir_pins_p3 },

rza1l_swio_pins[] is unused because rza1l_swio_entries[] refers to the
wrong array. So I'd rather see a patch to fix that instead.

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds