Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date:   Fri, 17 Apr 2020 12:07:21 +0100
From:   Marc Zyngier <maz@kernel.org>
To:     Jason Yan <yanaijie@huawei.com>
Cc:     Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        f.fainelli@gmail.com, tglx@linutronix.de, jason@lakedaemon.net,
        justinpopo6@gmail.com, bcm-kernel-feedback-list@broadcom.com,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static
In-Reply-To: <b2f6f8cd-557c-3978-f176-e615cba8b458@huawei.com>
References: <20200417074036.46594-1-yanaijie@huawei.com>
 <ecb3e3e1-7761-faa7-10fa-67da69604306@cogentembedded.com>
 <b2f6f8cd-557c-3978-f176-e615cba8b458@huawei.com>
Message-ID: <a71e75e8e391c76bf2f260abbaad4f9d@kernel.org>
User-Agent: Roundcube Webmail/1.3.10
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-04-17 11:56, Jason Yan wrote:
> 在 2020/4/17 18:26, Sergei Shtylyov 写道:
>> Hello!
>> 
>> On 17.04.2020 10:40, Jason Yan wrote:
>> 
>>> Fix the following sparse warning:
>>> 
>>> drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol
>>> 'bcm7038_l1_of_init' was not declared. Should it be static?
>>> 
>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>>> ---
>>>   drivers/irqchip/irq-bcm7038-l1.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/drivers/irqchip/irq-bcm7038-l1.c 
>>> b/drivers/irqchip/irq-bcm7038-l1.c
>>> index eb9bce93cd05..fd7c537fb42a 100644
>>> --- a/drivers/irqchip/irq-bcm7038-l1.c
>>> +++ b/drivers/irqchip/irq-bcm7038-l1.c
>>> @@ -416,7 +416,7 @@ static const struct irq_domain_ops 
>>> bcm7038_l1_domain_ops = {
>>>       .map            = bcm7038_l1_map,
>>>   };
>>> -int __init bcm7038_l1_of_init(struct device_node *dn,
>>> +static int __init bcm7038_l1_of_init(struct device_node *dn,
>>>                     struct device_node *parent)
>> 
>>     Reindent the above line please, it should start under *struct* on 
>> the 1st line.
> 
> OK, will cook a new one.

Please don't bother. I've picked the patch already, and it is on its way 
to Linus.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...