Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200410145643.630b0731@xhacker.debian>
In-Reply-To: <20200410145643.630b0731@xhacker.debian>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Fri, 17 Apr 2020 13:29:08 +0200
Message-ID: <CAPDyKFpmcXt2oikzz8hKCLecctnZo9PLNZgu-FRnO8y2jfc-kA@mail.gmail.com>
Subject: Re: [PATCH] mmc: sd: use HIGH_SPEED_BUS_SPEED in mmc_sd_switch_hs()
To:     Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc:     "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 10 Apr 2020 at 08:57, Jisheng Zhang <Jisheng.Zhang@synaptics.com> wrote:
>
> Use the well defined HIGH_SPEED_BUS_SPEED macro in mmc_sd_switch_hs()
> to make code more readable.
>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/core/sd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> index 76c7add367d5..43de3190d718 100644
> --- a/drivers/mmc/core/sd.c
> +++ b/drivers/mmc/core/sd.c
> @@ -376,11 +376,11 @@ int mmc_sd_switch_hs(struct mmc_card *card)
>         if (!status)
>                 return -ENOMEM;
>
> -       err = mmc_sd_switch(card, 1, 0, 1, status);
> +       err = mmc_sd_switch(card, 1, 0, HIGH_SPEED_BUS_SPEED, status);
>         if (err)
>                 goto out;
>
> -       if ((status[16] & 0xF) != 1) {
> +       if ((status[16] & 0xF) != HIGH_SPEED_BUS_SPEED) {
>                 pr_warn("%s: Problem switching card into high-speed mode!\n",
>                         mmc_hostname(card->host));
>                 err = 0;
> --
> 2.26.0
>