Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp464184ybz; Fri, 17 Apr 2020 04:31:48 -0700 (PDT) X-Google-Smtp-Source: APiQypJqnnpI1iYQkbE+58QIU6IZSjknp3/uRllbQEuK0dNak4KrIJimHiAIY2c2N02L0sdGhR1h X-Received: by 2002:a50:c0ce:: with SMTP id r14mr2417966edf.298.1587123108169; Fri, 17 Apr 2020 04:31:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587123108; cv=none; d=google.com; s=arc-20160816; b=fxbhQId+srez8uFK5g3sJ/HvnwQjD/dwnd/l4npRQzKz0We/kDltSJ/piEylMopoV6 8fmv2L7ukOBtj2bf84TdbB6Z1oBlz2XCBccWgdjvIkt1lUyari13CG9gKL/WgK6IVeQm Jy5EKJVYAcFlhdL+BjkzcQtO+4AyQlhS8hgETKFLZyRR7EkMn0m75N/OZK478f+2XeAt 3CCpU5eB+5+v2+nUZf3+gnCAyJO+F9eprU/mkyBGNT5fTbjzyYwNiewYcPhhK525d/iH bc3UOXI5wlxbE562L/CSfUlOCUxPNfbpueEIFDqBt+kgymi9FbvXAmCEhZySPBxVR4Cf zg8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Nu9WgdeKxKQdkeH1gR18VhD9u3Adn8tTkCVWam9LK94=; b=n3gFYeR7brYJUePK+SmEklXjzCdcI2uyt502V6luhb5gkOitU6lTyi5TnNhQD6E0TZ QxqLgnunf6MR0hJHmt/F2acMAWL08AU7vwfHmPjWn1wqYSiXpEpDB5pvcZ1JT2m1YIMO OMx3QEf9/bqLAok0sBNfPeARhv16TG2hxAlDdhgERcraxS2MrwM4TmA0E8QBYat6B6zb G6JCj8ZqPWI0JmHsOy5yXp12ezUkkLsKHKKBrotXendRMygzhyhyiFIvJmoxkcb3xNNE RBNbnqB9+4JUy95xw4uGJVYDOJt3HhPuk8MElIiHEb0xsXurWlSto7gzMK5vfb8VF+/G k/qA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GtOmtytk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cy3si14205274edb.36.2020.04.17.04.31.24; Fri, 17 Apr 2020 04:31:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GtOmtytk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730394AbgDQL3w (ORCPT + 99 others); Fri, 17 Apr 2020 07:29:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1730324AbgDQL3v (ORCPT ); Fri, 17 Apr 2020 07:29:51 -0400 Received: from mail-ua1-x941.google.com (mail-ua1-x941.google.com [IPv6:2607:f8b0:4864:20::941]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFF61C061A0F for ; Fri, 17 Apr 2020 04:29:50 -0700 (PDT) Received: by mail-ua1-x941.google.com with SMTP id c17so509234uae.12 for ; Fri, 17 Apr 2020 04:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Nu9WgdeKxKQdkeH1gR18VhD9u3Adn8tTkCVWam9LK94=; b=GtOmtytk18kW8KTUJNTrqweEWV6cr1cr3C/OhLizV4J+D5OdrUqwJejcrqB2FP9K8z PYBUxtD/ra0CuRjTRXYgtVHfo19zN25JtaWCwInr9o/VTm9a5UGDMuza4i1fm62ScXS9 rN1UfE+7fOrtV1M57/CovyL0iOHcIkByEFdhx60rxFxssfOvvpNEKzg+qeZ77hKtk4Ox xVt/5BJUoLV64O9x2cO7jFh37MK9xhaDQ72/xf0AE4gyMTDGUKjJ1Y4uzvUspMGAIM2M NyxlwU3fs+7X0QoBLrFQ2Cfq7u4S9qvjghwsf+EDLrQziUAaZuBQiycPE80POwx0JOgZ b4DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Nu9WgdeKxKQdkeH1gR18VhD9u3Adn8tTkCVWam9LK94=; b=PIP7Z9QSmuUAaEGUPa6wJaVdjBaMnrstnj5o6XKB6z1EThqkf80all7VJwk3mQNZMJ aZ9y3KFI8GcqSnx8G13RgoOFiVpfjzqb65EBTGqp/gUQTPs0I2gE2xYAT95JiYu0/rrQ gs8KzqodaCd0VV6eCoM2n7xQhF3ac1V9mQDp1QdGKZ7BeJD+xdhyL1k6Lfup8rRM4fjx 39sQ0bNUvC3YRF8eO5/4jwt+mGO/YqTfelxzpZCFC+pssqqXXIEDRCQtVrnt0LjkHTd+ HYfkzQFCu2aPmaZ0hgeqL8wez29Mzlw9uLlfxOGaF0szDrUmqN7lemcDIBmTMHwhxu7L QHFg== X-Gm-Message-State: AGi0PuYygnTspwA19ikVL0mLDoXW68D6twzFurvh5zZWaCkGxArb2X/7 I6wgoP9Ixh4e2/kZpGisdI/F4rpSfiYve74kx/nMEQ== X-Received: by 2002:a9f:25af:: with SMTP id 44mr1989461uaf.104.1587122990039; Fri, 17 Apr 2020 04:29:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ulf Hansson Date: Fri, 17 Apr 2020 13:29:14 +0200 Message-ID: Subject: Re: [PATCH v5 0/3] Introduce the request_atomic() for the host To: Baolin Wang Cc: Adrian Hunter , Arnd Bergmann , Orson Zhai , Chunyan Zhang , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Apr 2020 at 04:46, Baolin Wang wrote: > > This patch set introduces a new request_atomic() interface for the > MMC host controller, which is used to submit a request to host in > the atomic context, such as in the irq hard handler, to reduce the > request latency. > > Note, this patch set is based on Adrian's patch set: > https://www.spinics.net/lists/linux-mmc/msg58529.html > > Any comments are welcome. Thanks. > > Changes from v4: > - Remove redundant checking when warning the return value of request_atomic(). > - Add acked tag from Adrian for patch 1. > - Re-implement the request_atomic() based on the Adrian's patch set. > > Changes from v3: > - Move patch 3 of V3 patch set into patch 1. > - Add a warning for unexpected return value of request_atomic(). > - Remove redundant checking of ops->request(). > > Changes from v2: > - Return busy flag if encountering unusual card busy state > instead of polling in interrupt context. > - Add a work for HSQ to try again in non-atomic context if the host > returns busy flag. > > Changes from v1: > - Re-split the changes to make them more clear suggested by Ulf. > - Factor out the auto CMD23 checking into a separate function. > > Baolin Wang (3): > mmc: host: Introduce the request_atomic() for the host > mmc: host: sdhci: Implement the request_atomic() API > mmc: host: sdhci-sprd: Implement the request_atomic() API > > drivers/mmc/host/mmc_hsq.c | 29 ++++++++++++++++++++++++++++- > drivers/mmc/host/mmc_hsq.h | 1 + > drivers/mmc/host/sdhci-sprd.c | 23 ++++++++++++++++++++--- > drivers/mmc/host/sdhci.c | 34 ++++++++++++++++++++++++++++++++++ > drivers/mmc/host/sdhci.h | 1 + > include/linux/mmc/host.h | 3 +++ > 6 files changed, 87 insertions(+), 4 deletions(-) > > -- > 2.17.1 > Applied for next, thanks! Kind regards Uffe