Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp477235ybz; Fri, 17 Apr 2020 04:47:39 -0700 (PDT) X-Google-Smtp-Source: APiQypL29qH+zdQLAuGsO3DnL99Qqj4Wlh3v8UhvQ06cFOnfhhcvB6IkvAIP7ZEh5zOCnWkjt0sx X-Received: by 2002:a50:b966:: with SMTP id m93mr2493518ede.346.1587124059479; Fri, 17 Apr 2020 04:47:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587124059; cv=none; d=google.com; s=arc-20160816; b=JC1zF2jM4lIPNK3SxhfHhiFlFnFubMD+3ibk95I7bL7LUasQp5Kj7q1xQadupB8oQa aNUbplB+vvVGAwd920hey9vHwDJgRIkiELCzJHRkMf/ajIteb9+IH2CSdt2/f4GcgVZ4 rgea+TuEVsFjW6GMv9J5LYtomhPqAb46NR9gEPzrU3wP2V5SNATt2+8kOJeXjNChP4GS K+DSblinz7E5cf+LF+6cWnyZy/LAozzjv7bVZF7sjl6IYOacPE/HWC2ClCSC57eCg4yB j4X32sR+OhphT81VGvHAoEhVpOySrmlu8DgWIkrMmZXW2S2mAI3GdOFeXORtSJpIDsCE b6JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=x3xNcjW5cEUnM1T8PUGYs+pLcMFOIuhwL7/hxdohjb4=; b=dIOZM+IIZqsfxTvxBwlaEGLZlxXv2NIxpttZltZw+bSUv/58T4SvMroF3algWJoLqf mjUzOHC9FRyQlRTreiXMilTnM6McmIIrSOLGZeZ6fJGZ8XInisBMlBDDncZ5xyxeA+yV zjImpGeHT8LdnxcbpLhtk3dhxGI2K0QaV7KfpNnJ13lhj11basyNsrf9HW7SR5BY7iGk YsVfQX+bV54OJTcIAPb02fmIbYphdnfoqZAqFQ12F3tO/DLs/hqCoAEyhLRkyIWZv8K8 A/3/5BGbISmeSdXJhDy+5skXfeb8WCNkJP5COSCZQB7QGGUACDbnmLflbIV/oOh3tAyo E3ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=X6yVjy3o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x13si11244856edq.56.2020.04.17.04.47.15; Fri, 17 Apr 2020 04:47:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=X6yVjy3o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730483AbgDQLpO (ORCPT + 99 others); Fri, 17 Apr 2020 07:45:14 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:15516 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730267AbgDQLpO (ORCPT ); Fri, 17 Apr 2020 07:45:14 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 17 Apr 2020 04:44:14 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 17 Apr 2020 04:45:14 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 17 Apr 2020 04:45:14 -0700 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 17 Apr 2020 11:45:13 +0000 Received: from [10.26.73.163] (10.124.1.5) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 17 Apr 2020 11:45:12 +0000 Subject: Re: [PATCH V2 2/3] soc/tegra: fuse: Correct Tegra194 revision To: Thierry Reding CC: , References: <20200331103341.19571-1-jonathanh@nvidia.com> <20200331103341.19571-2-jonathanh@nvidia.com> From: Jon Hunter Message-ID: Date: Fri, 17 Apr 2020 12:45:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200331103341.19571-2-jonathanh@nvidia.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To DRHQMAIL107.nvidia.com (10.27.9.16) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1587123855; bh=x3xNcjW5cEUnM1T8PUGYs+pLcMFOIuhwL7/hxdohjb4=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=X6yVjy3o+monjBvKX1QsjYWouFHKnL7OOjln23s0xB/VaHbYF8dQxHrKeV298YfGo caZgHqkerRxCJ0A3r2S3OmPnRbas0CfcVCoyhFMlUvAPb+sP2g5H44P3a/+lqihM+Q GaogPUGfcRREECkuLAAj7d1LCafGOARicrDPw79JQyKsN0RzRCi1aMy452QHxUkL1F 2apKfqVqZ5fgXFBKiH1fnNmFME/RP/2mUvmaN5gvILNWMPrt0nBYgn/3P9gF11x4EJ N9nsY9E6wy/CAdM3bbVSwrBBiiee/jS+20q4maD9KPRx5wwV+N1H88Nsd46vzYGvpe JOOPtGuCjQi+g== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/03/2020 11:33, Jon Hunter wrote: > Determining the revision for Tegra194 devices is slightly different from > previous generations. For Tegra194, the majorrev field of the HIDREV > register determines if the major revision is A, B, C, etc and the > minorrev field determines if the minorrev is 01, 02, 03, etc. > > For Tegra194, there are two main revisions which are A01 and A02. > Therefore, add a new function to correctly identify the revision for > Tegra194 devices. > > Signed-off-by: Jon Hunter > --- > drivers/soc/tegra/fuse/fuse-tegra20.c | 3 ++- > drivers/soc/tegra/fuse/fuse-tegra30.c | 8 ++++++- > drivers/soc/tegra/fuse/fuse.h | 2 ++ > drivers/soc/tegra/fuse/tegra-apbmisc.c | 29 ++++++++++++++++++++++++++ > 4 files changed, 40 insertions(+), 2 deletions(-) Although there is a slight difference, it turns out that the existing code does work fine for Tegra194 as well and so I will drop this change as it is not needed. Jon -- nvpublic