Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH] arm64: dts: rockchip: add core devicetree for rk3318
To:     Heiko Stuebner <heiko@sntech.de>, Johan Jonker <jbx6244@gmail.com>
Cc:     devicetree@vger.kernel.org, robh+dt@kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org
References: <20200417105739.3718-1-jbx6244@gmail.com>
 <2141402.AJMLQ3pQEO@phil>
From:   Robin Murphy <robin.murphy@arm.com>
Message-ID: <6d5a1d27-8d32-eca2-007c-aa0bed81af46@arm.com>
Date:   Fri, 17 Apr 2020 12:51:15 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <2141402.AJMLQ3pQEO@phil>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-04-17 12:05 pm, Heiko Stuebner wrote:
> Hi Johan,
> 
> Am Freitag, 17. April 2020, 12:57:39 CEST schrieb Johan Jonker:
>> The rk3318 is basically a rk3328 with improved gpu,
>> so add a dtsi based on that.
>>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> 
> Please don't add dangling dtsi files.
> I'd expect at least a board dts to actually use that and
> also the updated gpu node.
> 
>  From a cursory glance it looks like it gets upgraded from
> 450-MP2 to 450MP3 or so, so that would at least mean
> another set of interrupts.

I'm not sure anything's "improved" - as far as the internet can tell 
it's a special low-cost variant of RK3328 for low-end TV box vendors 
that Rockchip don't want to talk about. The DTB for my H96 Max 3318 
shows no appreciable difference from the BSP DT for RK3328, although I 
wouldn't be surprised if some of the unused stuff like the external GMAC 
was actually missing or broken. The board itself is the exact same one 
used in a lot of other cheap RK3328 boxes (and I mean literally, it's 
silkscreened "RK3328_8D4_V1.2").

Thanks to one unexpectedly honest Aliexpress listing I stumbled across, 
the "penta-core GPU" apparently translates from TV-box-marketing-speak 
to mean Mali-450 MP2 (1GP + 2PP) plus the RGA plus the VOP ;)

Robin.

> 
> Heiko
> 
>> ---
>>   arch/arm64/boot/dts/rockchip/rk3318.dtsi | 3 +++
>>   1 file changed, 3 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/rockchip/rk3318.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3318.dtsi b/arch/arm64/boot/dts/rockchip/rk3318.dtsi
>> new file mode 100644
>> index 000000000..a32f771bc
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/rockchip/rk3318.dtsi
>> @@ -0,0 +1,3 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +
>> +#include "rk3328.dtsi"
>>
> 
> 
> 
> 
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>