Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Hyunki Koo" <hyunki00.koo@samsung.com>
To:     "'Greg KH'" <gregkh@linuxfoundation.org>,
        "'Hyunki Koo'" <hyunki00.koo@gmail.com>
Cc:     <robh+dt@kernel.org>, <krzk@kernel.org>,
        "'Kukjin Kim'" <kgene@kernel.org>,
        "'Jiri Slaby'" <jslaby@suse.com>, <linux-serial@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>
In-Reply-To: <20200416135618.GA1295013@kroah.com>
Subject: RE: [PATCH v7 2/2] Support 32-bit access for the TX/RX hold
 registers UTXH and URXH.
Date:   Fri, 17 Apr 2020 21:05:02 +0900
Message-ID: <001501d614b0$6cab3ed0$4601bc70$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQFi1K+6yj7qBWyiWiQvcgMo5OZtFgIiWQf+Anfu/XipPuQQEA==
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <20200411123325.30501-1-hyunki00.koo@gmail.com>
        <CGME20200416140255epcas2p2bf81ac129b7471eb1fe40e545dbd796d@epcas2p2.samsung.com>
        <20200416135618.GA1295013@kroah.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 16, 2020 at 10:56:24PM +0900, Greg KH wrote:
> On Sat, Apr 11, 2020 at 09:33:24PM +0900, Hyunki Koo wrote:
> > From: Hyunki Koo <hyunki00.koo=40samsung.com>
> >
> > This is required for some newer SoCs.
> >
> > Signed-off-by: Hyunki Koo <hyunki00.koo=40samsung.com>
> > Reviewed-by: Krzysztof Kozlowski <krzk=40kernel.org> Tested on Odroid
> > HC1 (Exynos5422):
> > Tested-by: Krzysztof Kozlowski <krzk=40kernel.org>
> > ---
> > v2:
> > line 954 : change rd_regl to rd_reg in for backward compatibility.
> > line 2031: Add init value for ourport->port.iotype  to UPIO_MEM
> > v3:
> > line 2031: remove redundant init value  for ourport->port.iotype
> > v4:
> > correct variable types and change misleading function name
> > v5:
> > add dt-binding and go as first patch in this series.
> > v6:
> > no change in this patch, only chaged in =5BPATCH v6 1/2=5D
> > v7:
> > add reviewed by and tested by
> > ---
>=20
> Your subject line changed for this and patch 2 :(
>=20
> Also, I asked you to split this patch up better in the past, you seem to =
have
> ignored that :(
>=20
> First patch would be to create the new functions and use them, with no
> functional change to the code as-is.  A second patch would add the new
> binding, and a third patch would be to add the new functionality.
>=20
> And you need to describe all of this very well in your changelog, the one
> sentence here is not sufficient at all.
>=20
> Please fix this all up and resend.
>=20
> thanks,
>=20
> greg k-h

Sorry I missed your comment in V4, I will split and update the patch and re=
-send.