Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200417111604.19143-1-yanaijie@huawei.com>
In-Reply-To: <20200417111604.19143-1-yanaijie@huawei.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Fri, 17 Apr 2020 14:37:47 +0200
Message-ID: <CAMuHMdUF-N+TpYHwQTJkOBOoqFVpa_zK2VM-C-qxkvYif-aqrQ@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: rza1: fix wrong array assignment of rza1l_swio_entries
To:     Jason Yan <yanaijie@huawei.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Nishka Dasgupta <nishkadg.linux@gmail.com>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Apr 17, 2020 at 12:50 PM Jason Yan <yanaijie@huawei.com> wrote:
> The rza1l_swio_entries refered to the wrong array rza1h_swio_pins, which
> was intended to be rza1l_swio_pins. So let's fix it.
>
> This is detected by the following gcc warning:
>
> drivers/pinctrl/pinctrl-rza1.c:401:35: warning: ‘rza1l_swio_pins’
> defined but not used [-Wunused-const-variable=]
>  static const struct rza1_swio_pin rza1l_swio_pins[] = {
>                                    ^~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>

Fixes: 039bc58e73b77723 ("pinctrl: rza1: Add support for RZ/A1L")

> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in sh-pfc-for-v5.8.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds