Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp546072ybz; Fri, 17 Apr 2020 05:59:23 -0700 (PDT) X-Google-Smtp-Source: APiQypLXmpe8IT97d5yX1CKH4393Zz/h/T+dS5mzm2BYuAvTjBHOhneLoEBAsk6jzDSoi9W/SWoV X-Received: by 2002:a50:9346:: with SMTP id n6mr3007336eda.320.1587128363324; Fri, 17 Apr 2020 05:59:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587128363; cv=none; d=google.com; s=arc-20160816; b=K7PrYUt3snpl991d5QTXnpPcS1lMsIVsIVtrkTcRm1UFCX+DmkWDkhgMKLI/gzdGk9 m/03Zv6NSeDCUrMwgbp/0w5aOzIc3EVemxzaNZLAF2OR+WfCe83S/T43eNz+JVxXl5lP DWZUqlrm5OZE+m89COu+UclOISEjVnZJiACTUdMgN2tT/t8LIX43Kq74JvE2aGotE4+l oR1gGjqjw/DgG64OsfA2yBPEwQ3dqHlDOhrKTjRAE5L35OIg3R94qAXsZIN+fCitOZqy ozFzyhr+GrFU4AW/yU/jcjq9b0JRXPniPSt4PeWlN2FzLvH0MxmDKw3JIAesZxNr323k TEYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=6j0JY/8l50CMyYxhb/Ea5q7Bkoebtq+w2R0f0Ylt2W8=; b=Z+XpvRsu+P6dxfE8Ifw4SGDE3q5Pmx62scB+OCy/Al3HwbUXm0wSQfkNKO8Q49tae8 RzzmCEkrz5VBl6jCewWHLlEKbB+K9/RlGd6/xg0ZAOt86vPPlPBkEFoRImB5qQ7zs8Bt ionSMBtNfpHOJ4NOPCsF+tbd79U4i/Eh4LcvKEYeGvlOUXGP0/IW4V8FJu2dFRCJVdLX P2h5wUO0EBMLUIYbxjaETYZ+f4dq2ohxjwK7iROmwPQEIADRh2sAuAi2Y8TZxIZ+nhCN uMNmgPUEW/mbq0C3hOWwCrT2C1G1Oxs00Aw9N1/JsP0JZTGaeLBaqESQWiHp1qlCrHnv c0mQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y24si13522495ejr.132.2020.04.17.05.59.00; Fri, 17 Apr 2020 05:59:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729851AbgDQM5Q (ORCPT + 99 others); Fri, 17 Apr 2020 08:57:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729034AbgDQM5Q (ORCPT ); Fri, 17 Apr 2020 08:57:16 -0400 Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E586C061A0C for ; Fri, 17 Apr 2020 05:57:16 -0700 (PDT) Received: from [5.158.153.52] (helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jPQYI-0008LQ-T0; Fri, 17 Apr 2020 14:57:03 +0200 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 871A1104096; Fri, 17 Apr 2020 14:57:02 +0200 (CEST) From: Thomas Gleixner To: Balbir Singh , linux-kernel@vger.kernel.org Cc: jpoimboe@redhat.com, tony.luck@intel.com, keescook@chromium.org, benh@kernel.crashing.org, x86@kernel.org, dave.hansen@intel.com, Balbir Singh Subject: Re: [PATCH v3 1/5] arch/x86/kvm: Refactor l1d flush lifecycle management In-Reply-To: <20200408090229.16467-2-sblbir@amazon.com> References: <20200408090229.16467-1-sblbir@amazon.com> <20200408090229.16467-2-sblbir@amazon.com> Date: Fri, 17 Apr 2020 14:57:02 +0200 Message-ID: <871rommfs1.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Balbir Singh writes: > #include > #include > > +#define L1D_CACHE_ORDER 4 Newline between constants and declarations please > void clflush_cache_range(void *addr, unsigned int size); > +void *alloc_l1d_flush_pages(void); > +void cleanup_l1d_flush_pages(void *l1d_flush_pages); Can we please have a consistent name space prefix? l1d_flush_*() Thanks, tglx