Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp552667ybz; Fri, 17 Apr 2020 06:04:54 -0700 (PDT) X-Google-Smtp-Source: APiQypKnD7ez9BRzjT57Ibs/kYAincU0AZFZeZ3rnANA/PxI0/1cJxKOEcy9dpA/z7SZXBgkT0bF X-Received: by 2002:a50:bc16:: with SMTP id j22mr2966817edh.257.1587128693484; Fri, 17 Apr 2020 06:04:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587128693; cv=none; d=google.com; s=arc-20160816; b=fSerAKaKxWH2WWj57XkhLbQ7vWAWWNr5Doj8uH8F75GA9zqOtaQ3xEP5zK6oG+H6aa YNlGFIDIcZoQrViAN9v6wOI5kFVEmDWZtW+Vu2eb4CsDZV3PK6Wf6LkQAJ9mq77SJiQq 3u31u5EGTi8FAXrGWTW1YXzdyh0D9C1AidVYiYH09aSm/E/Pd3v+si+S53al6hWBL0bb tmZSYW2rmLUwEWiErtohT2p9knM5K95M7OJn3Gc2NxzJBFHAX2wsBzmMnBkCRSseakRo FUptYrFjnqZNGSli9r4rqVfYBz01MCOFDJrYRaCVWqnonmNJ/6HEFlpxxetwk1pgkgiF 6a5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=iiFv0pFtzCZTzfUyWKf9+Cdra0cJU4rFK+AkadmEvq4=; b=SfeLfyNJs8+MlyhGbqTj6BNlcx/uTN9y+ydDhFTlw6kp/8LFkPxwrL9W6AH9CxYGCr od8dDnMMG7/Y29VLU0YRr93bePeMrh2hOiQ0M1u3rPwZF5xN32JBYAGtKlg4gmUemVlI eptAVZNgZ7dzRC8sx3zdTg3xEcRZotv0wfiDa/Imz4lnPMCh8G6CVWTVi63F4mvaU1n0 cRge95xIcZdl4ypGWPc/jjIma1dBjGcmtHVHg7BWtZk+pDW7V6br4vM+9xyxpw9jzkRn rNZcQbTk01UmmfXOEIoHfphpDGm0oOzzNe6CH34O2Xvkkt9Wj5VYI4YgqMw5J9GyoBOb K7ow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ch6si8900597edb.50.2020.04.17.06.04.30; Fri, 17 Apr 2020 06:04:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730645AbgDQM7d (ORCPT + 99 others); Fri, 17 Apr 2020 08:59:33 -0400 Received: from verein.lst.de ([213.95.11.211]:57514 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730166AbgDQM7c (ORCPT ); Fri, 17 Apr 2020 08:59:32 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id A72B768BEB; Fri, 17 Apr 2020 14:59:29 +0200 (CEST) Date: Fri, 17 Apr 2020 14:59:29 +0200 From: Christoph Hellwig To: Kai-Heng Feng Cc: kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me, linux-stable , "open list:NVM EXPRESS DRIVER" , open list Subject: Re: [PATCH] nvme/pci: Use Discard instead of Write Zeroes on SK hynix SC300 Message-ID: <20200417125929.GA5053@lst.de> References: <20200417083641.28205-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200417083641.28205-1-kai.heng.feng@canonical.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 17, 2020 at 04:36:41PM +0800, Kai-Heng Feng wrote: > After commit 6e02318eaea5 ("nvme: add support for the Write Zeroes > command"), SK hynix SC300 becomes very slow with the following error > message: > [ 224.567695] blk_update_request: operation not supported error, dev nvme1n1, sector 499384320 op 0x9:(WRITE_ZEROES) flags 0x1000000 phys_seg 0 prio class 0] > > Use quirk NVME_QUIRK_DEALLOCATE_ZEROES to workaround this issue. Do you have a written guarantee from SK Hynix that it will always zero all blocks discarded?