Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix bridge driver to make connector optional!
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Content-Type: text/plain; charset=us-ascii
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <20200417125840.GB4748@pendragon.ideasonboard.com>
Date:   Fri, 17 Apr 2020 15:53:46 +0200
Cc:     Maxime Ripard <maxime@cerno.tech>,
        Discussions about the Letux Kernel 
        <letux-kernel@openphoenux.org>,
        linux-omap <linux-omap@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <401F61D0-B88C-4BF7-8CB1-907B0C5F7223@goldelico.com>
References: <CB5A5B81-F06C-4CBE-95DE-96C8723D2AC5@goldelico.com> <20200417124422.fl35igitvd7thpr5@gilmour.lan> <20200417125840.GB4748@pendragon.ideasonboard.com>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Laurent,

> Am 17.04.2020 um 14:58 schrieb Laurent Pinchart =
<laurent.pinchart@ideasonboard.com>:
>=20
> Hello,
>=20
> On Fri, Apr 17, 2020 at 02:44:22PM +0200, Maxime Ripard wrote:
>> On Fri, Apr 17, 2020 at 02:18:11PM +0200, H. Nikolaus Schaller wrote:
>>> Hi Maxime,
>>> I have started to test v5.7-rc1 and can't fully boot the GTA04
>>> device any more.
>>>=20
>>> What I see in the log is:
>>>=20
>>> [   28.567840] [drm:simple_bridge_attach [simple_bridge]] *ERROR* =
Fix bridge driver to make connector optional!
>>> [   28.567871] omapdrm omapdrm.0: unable to attach bridge =
/ocp@68000000/dss@48050000/encoder@48050c00
>>> [   28.786529] omapdrm omapdrm.0: omap_modeset_init failed: ret=3D-22
>>> [   28.841552] omapdrm: probe of omapdrm.0 failed with error -22
>>>=20
>>> This device uses the ti,opa362 chip which did have a dedicated
>>> omapdss driver before (which is removed now) and which seems to
>>> be supported by the simple_bridge now.
>>>=20
>>> The opa362 is sitting in the video out path from
>>>=20
>>> 	omapdrm -> venc -> opa362 -> video-out-connector.
>>>=20
>>> What does this error mean? How can it be fixed?
>>=20
>> -22 is usually EINVAL, which can be pretty much anything. A good =
thing to do
>> would be to bisect to see which actual commit broke it, but if I was =
to bet on
>> something I guess it would be
>>=20
>> =
https://lore.kernel.org/dri-devel/20200226112514.12455-1-laurent.pinchart@=
ideasonboard.com/
>=20
> Would "[PATCH 0/2] drm: bridge: simple-bridge: Enable usage with DRM
> bridge connector helper" solve it ?

Yes, seems to magically solve the boot issue!

I'll confirm later if the opa362 is still (or again) working.

BR and thanks,
Nikolaus Schaller