Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200417073219.40320-1-yanaijie@huawei.com>
In-Reply-To: <20200417073219.40320-1-yanaijie@huawei.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 17 Apr 2020 09:58:03 -0400
Message-ID: <CADnq5_OTQEvOFZ3WaOAGQqMpkcsSkQ2fwge2+YUV59URnwLHgw@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/powerplay: remove defined but not used variables
To:     Jason Yan <yanaijie@huawei.com>
Cc:     "Quan, Evan" <evan.quan@amd.com>,
        "Deucher, Alexander" <alexander.deucher@amd.com>,
        Christian Koenig <christian.koenig@amd.com>,
        Chunming Zhou <David1.Zhou@amd.com>,
        Dave Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Apr 17, 2020 at 9:16 AM Jason Yan <yanaijie@huawei.com> wrote:
>
> Fix the following gcc warning:
>
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:710:46:
> warning: =E2=80=98PSMGCEDCThresholdConfig_vega10=E2=80=99 defined but not=
 used
> [-Wunused-const-variable=3D]
>  static const struct vega10_didt_config_reg
> PSMGCEDCThresholdConfig_vega10[] =3D
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:654:46:
> warning: =E2=80=98PSMSEEDCThresholdConfig_Vega10=E2=80=99 defined but not=
 used
> [-Wunused-const-variable=3D]
>  static const struct vega10_didt_config_reg
> PSMSEEDCThresholdConfig_Vega10[] =3D
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Applied.  Thanks!

Alex

> ---
>  .../amd/powerplay/hwmgr/vega10_powertune.c    | 23 -------------------
>  1 file changed, 23 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c b/dri=
vers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c
> index ca9b23b5abc9..9757d47dd6b8 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c
> @@ -651,18 +651,6 @@ static const struct vega10_didt_config_reg   PSMSEED=
CStallDelayConfig_Vega10[] =3D
>         {   0xFFFFFFFF  }  /* End of list */
>  };
>
> -static const struct vega10_didt_config_reg   PSMSEEDCThresholdConfig_Veg=
a10[] =3D
> -{
> -/* ---------------------------------------------------------------------=
---------------------------------------------------------------------------=
---------------------------------
> - *      Offset                             Mask                         =
                        Shift                                              =
    Value
> - * ---------------------------------------------------------------------=
---------------------------------------------------------------------------=
---------------------------------
> - */
> -       /* SQ EDC THRESHOLD */
> -       {   ixDIDT_SQ_EDC_THRESHOLD,           DIDT_SQ_EDC_THRESHOLD__EDC=
_THRESHOLD_MASK,           DIDT_SQ_EDC_THRESHOLD__EDC_THRESHOLD__SHIFT,    =
        0x0000 },
> -
> -       {   0xFFFFFFFF  }  /* End of list */
> -};
> -
>  static const struct vega10_didt_config_reg   PSMSEEDCCtrlResetConfig_Veg=
a10[] =3D
>  {
>  /* ---------------------------------------------------------------------=
---------------------------------------------------------------------------=
---------------------------------
> @@ -707,17 +695,6 @@ static const struct vega10_didt_config_reg   PSMSEED=
CCtrlConfig_Vega10[] =3D
>         {   0xFFFFFFFF  }  /* End of list */
>  };
>
> -static const struct vega10_didt_config_reg   PSMGCEDCThresholdConfig_veg=
a10[] =3D
> -{
> -/* ---------------------------------------------------------------------=
---------------------------------------------------------------------------=
---------------------------------
> - *      Offset                             Mask                         =
                        Shift                                              =
    Value
> - * ---------------------------------------------------------------------=
---------------------------------------------------------------------------=
---------------------------------
> - */
> -       {   mmGC_EDC_THRESHOLD,                GC_EDC_THRESHOLD__EDC_THRE=
SHOLD_MASK,                GC_EDC_THRESHOLD__EDC_THRESHOLD__SHIFT,         =
        0x0000000 },
> -
> -       {   0xFFFFFFFF  }  /* End of list */
> -};
> -
>  static const struct vega10_didt_config_reg   PSMGCEDCDroopCtrlConfig_veg=
a10[] =3D
>  {
>  /* ---------------------------------------------------------------------=
---------------------------------------------------------------------------=
---------------------------------
> --
> 2.21.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx