Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp687431ybz; Fri, 17 Apr 2020 08:16:49 -0700 (PDT) X-Google-Smtp-Source: APiQypJEQOrJ+uwNPus1UnQjiQ+JFpovx+aGaG1aq1bS9iVvrsmxl54ZhSJ6yLjCOYZU9mpX9yk9 X-Received: by 2002:a17:906:2284:: with SMTP id p4mr3285732eja.69.1587136609461; Fri, 17 Apr 2020 08:16:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587136609; cv=none; d=google.com; s=arc-20160816; b=DHzsf74eQ/FiFFbJ2MhczVZhu/OlBYDBWGfyBpWQLg+2UvlihE4hR/pAJc04nGsbq5 6v6+/0ZOxKSK7Yfy6AWxMjJBvW8gveWNapHY/mKbKuvIkVVRvTuq7uDIwS8F9DC+cVP3 1JUPIZhEMTzlfO7UbnnZltKq+FKXquBKrbRM+SiFw82m6rzRDB9tmQbGyjnlFHYoKiBY 3h0tpj4x0Yvbs5Wsb2kb0Is0uj57kHxl6fUcjwH8aos9WKZWAces+O1R4HB7pPcCcJWI s3cVLRYKxsrpF/oUcZI9mlu0wzVmsikQ5zgzfozqAuWldJvTdYmKYX/JRNj+k/IxHKyL IMzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=V6sTeNjLvCdX42CWxu9FemGB+Ga/OTc/wN3k+9+u1yU=; b=HVvBL/d/Vj8EkZ0yNKRbc1tQ2ljBuJGmsjVbeTG1oOgjUbq3Gs89/rIfdxA+qfRzW6 locYDDJyK3O5OsodfsOPKkx5qug1AyigmFhNdmre5LU3wR/YojSuUqbGF9snIo79Y3ZT /xlTnnF6LzgUKDIvD9+Cy1yYfHEu1hNJZXlKHWPb0bySPB9yNVFuLU+TNE5j0dUQKqVc RuUPMKxVN/O0fZUokOAGU3WeaUgZvZuwxMmhEnATtglY3XwCMMLSjX7Bf0Vg3xTMHKQw gSodj2BudAHGpxP801BngE/B1mcjC59k/p2c045xsX2dZtiBDeVmVEgWfXMKQs4L1SFE d9RA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id va12si2445048ejb.227.2020.04.17.08.16.25; Fri, 17 Apr 2020 08:16:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728590AbgDQPOu (ORCPT + 99 others); Fri, 17 Apr 2020 11:14:50 -0400 Received: from muru.com ([72.249.23.125]:49904 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728272AbgDQPOu (ORCPT ); Fri, 17 Apr 2020 11:14:50 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E075B8047; Fri, 17 Apr 2020 15:15:37 +0000 (UTC) Date: Fri, 17 Apr 2020 08:14:47 -0700 From: Tony Lindgren To: "H. Nikolaus Schaller" Cc: Andreas Kemnade , Evgeniy Polyakov , Greg Kroah-Hartman , Linux Kernel Mailing List , linux-omap , Adam Ford , "Andrew F . Davis" , Vignesh R Subject: Re: [PATCHv3] w1: omap-hdq: Simplify driver with PM runtime autosuspend Message-ID: <20200417151447.GM37466@atomide.com> References: <20191217004048.46298-1-tony@atomide.com> <7B8C7DD9-095B-48FC-9642-695D07B79E97@goldelico.com> <20200416184638.GI37466@atomide.com> <3197C3F0-DEB9-4221-AFBD-4F2A08C84C4C@goldelico.com> <20200417164340.3d9043d1@aktux> <6430AF54-849E-456B-8DB0-B4478BBDB78D@goldelico.com> <20200417150721.GL37466@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200417150721.GL37466@atomide.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tony Lindgren [200417 15:08]: > Maybe the PM runtime usecounts get unbalanced somewhere in the > driver where we end up with driver permanently in disabled state? Or it could be that with omap_hdq.c no longer blocking SoC deeper idle states, omap_hdq.c now loses context if you have omap3 off mode enabled during idle? If so, this can easily be fixed by adding a cpu_pm notifier along the lines of what we already have for few drivers: $ git grep -e CLUSTER_PM_ENTER -e CLUSTER_PM_EXIT Regards, Tony