Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v10 3/6] iio: adc: mp2629: Add support for mp2629 ADC
 driver
To:     saravanan sekar <sravanhome@gmail.com>, lee.jones@linaro.org,
        andy.shevchenko@gmail.com, robh+dt@kernel.org, jic23@kernel.org,
        knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, sre@kernel.org
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-iio@vger.kernel.org, linux-pm@vger.kernel.org
References: <20200417085003.6124-1-sravanhome@gmail.com>
 <20200417085003.6124-4-sravanhome@gmail.com>
 <a8da9a3d-93a5-b926-b8c0-84138b59ad4f@infradead.org>
 <2b4c7de2-aa85-65aa-be5e-3daed689c44d@gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <f1e85fcd-e5e5-798c-6093-a195c5cbc08a@infradead.org>
Date:   Fri, 17 Apr 2020 08:14:49 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <2b4c7de2-aa85-65aa-be5e-3daed689c44d@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/17/20 7:51 AM, saravanan sekar wrote:
> Hi Randy,
> 
> On 17/04/20 4:35 pm, Randy Dunlap wrote:
>> Hi--
>>
>> On 4/17/20 1:50 AM, Saravanan Sekar wrote:
>>> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
>>> index 82e33082958c..ef0c0cd31855 100644
>>> --- a/drivers/iio/adc/Kconfig
>>> +++ b/drivers/iio/adc/Kconfig
>>> @@ -680,6 +680,16 @@ config MESON_SARADC
>>>         To compile this driver as a module, choose M here: the
>>>         module will be called meson_saradc.
>>>   +config MP2629_ADC
>>> +    tristate "Monolithic MP2629 ADC driver"
>>> +    depends on MFD_MP2629
>>     depends on I2C
>> ?
> 
> Made "depends on I2C" in MFD_MP2629, hope not needed becomes redundant here
> 
> Thanks,
> Saravanan

I see. Thanks for explaining.

>>> +    help
>>> +      Say yes to have support for battery charger IC MP2629 ADC device
>>> +      accessed over I2C.
>>> +
>>> +      This driver provides ADC conversion of system, input power supply
>>> +      and battery voltage & current information.
>>> +
>>>   config NAU7802
>>>       tristate "Nuvoton NAU7802 ADC driver"
>>>       depends on I2C
>> thanks.


-- 
~Randy