Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 1jEruK9lRC/6OfrUw2b4bEI79hBHGt8DfyNEQ6GRu/BUi7GJrAcpLiYDfkjE7ns647z05t52yu
 oMO+GNGe7/dw==
IronPort-SDR: ZBwe2yhen/Cg4VzUVmdatNxrnAr9gr2mfLpMqbuIjwHNm8+JZZMJryQnFAdgH7o+9ulVtWAxwR
 X5jV6k+GoP8A==
Subject: Re: [PATCH] ASoC: Intel: atom: remove unused 'sst_mix_voip_controls'
To:     Jason Yan <yanaijie@huawei.com>, cezary.rojewski@intel.com,
        liam.r.girdwood@linux.intel.com, yang.jie@linux.intel.com,
        broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
        hdegoede@redhat.com, tglx@linutronix.de,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc:     Hulk Robot <hulkci@huawei.com>
References: <20200417092344.14301-1-yanaijie@huawei.com>
From:   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Message-ID: <8cd0ba8d-138d-d4da-d6fb-d2457ea2db13@linux.intel.com>
Date:   Fri, 17 Apr 2020 08:43:12 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200417092344.14301-1-yanaijie@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4/17/20 4:23 AM, Jason Yan wrote:
> Fix the following gcc warning:
> 
> sound/soc/intel/atom/sst-atom-controls.c:710:30: warning:
> ‘sst_mix_voip_controls’ defined but not used [-Wunused-const-variable=]
>   SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_voip_controls);

I'd prefer it if we didn't change this but only added __maybe_unused in 
the macro.

This is 2013/2014 legacy stuff, some parts were not upstreamed and this 
was used by out-of-tree Android variations, and I don't know the 
consequences of taking this out.

Better just squelch the warning but not change anything, no?

> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>   sound/soc/intel/atom/sst-atom-controls.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/sound/soc/intel/atom/sst-atom-controls.c b/sound/soc/intel/atom/sst-atom-controls.c
> index 69f3af4524ab..541f0059ba7a 100644
> --- a/sound/soc/intel/atom/sst-atom-controls.c
> +++ b/sound/soc/intel/atom/sst-atom-controls.c
> @@ -707,7 +707,6 @@ SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_pcm2_controls);
>   SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_sprot_l0_controls);
>   SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_media_l1_controls);
>   SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_media_l2_controls);
> -SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_voip_controls);
>   SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_codec0_controls);
>   SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_codec1_controls);
>   SST_SBA_DECLARE_MIX_CONTROLS(sst_mix_modem_controls);
>