Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Uwjivzvoj5wIrsPJMQnmh8OIZG1IMiibxXi2pVfuBwu3II9eAc8zOYplTvCSBdMmURrkrxR6xO
 uk7l3VpanCRw==
From:   SeongJae Park <sjpark@amazon.com>
To:     Mel Gorman <mgorman@techsingularity.net>
CC:     SeongJae Park <sjpark@amazon.com>,
        Peter Zijlstra <peterz@infradead.org>,
        "Huang, Ying" <ying.huang@intel.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@surriel.com>,
        Daniel Jordan <daniel.m.jordan@oracle.com>,
        Tejun Heo <tj@kernel.org>, Dave Hansen <dave.hansen@intel.com>,
        Tim Chen <tim.c.chen@intel.com>,
        Aubrey Li <aubrey.li@intel.com>
Subject: Re: Re: Re: Re: [RFC] autonuma: Support to scan page table asynchronously
Date:   Fri, 17 Apr 2020 14:44:37 +0200
Message-ID: <20200417124437.25445-1-sjpark@amazon.com>
In-Reply-To: <20200417121629.GA3758@techsingularity.net> (raw)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 17 Apr 2020 13:16:29 +0100 Mel Gorman <mgorman@techsingularity.net> wrote:

> On Fri, Apr 17, 2020 at 12:21:29PM +0200, SeongJae Park wrote:
> > On Fri, 17 Apr 2020 12:04:17 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
> > 
> > > On Fri, Apr 17, 2020 at 09:05:08AM +0200, SeongJae Park wrote:
> > > > I think the main idea of DAMON[1] might be able to applied here.  Have you
> > > > considered it?
> > > > 
> > > > [1] https://lore.kernel.org/linux-mm/20200406130938.14066-1-sjpark@amazon.com/
> > > 
> > > I've ignored that entire thing after you said the information it
> > > provides was already available through the PMU.
> > 
> > Sorry if my answer made you confused.  What I wanted to say was that the
> > fundamental access checking mechanism that DAMON depends on is PTE Accessed bit
> > for now, but it could be modified to use PMU or other features instead. 
> 
> I would not be inclined to lean towards either approach for NUMA
> balancing. Fiddling with the accessed bit can have consequences for page
> aging and residency -- fine for debugging a problem, not to fine for
> normal usage. I would expect the PMU approach would have high overhead
> as well as taking over a PMU counter that userspace debugging may expect
> to be available.

Good point.  But, isn't it ok to use Accessed bit as long as PG_Idle and
PG_Young is adjusted properly?  Current DAMON implementation does so, as
idle_page_tracking also does.

That said, the core logics of DAMON and the underlying access check primitive
are logically seperated.  I am planning[1] to further entirely seperate those
and let users to be able to use right access check promitive for their needs.

If I'm missing something, please let me know.

[1] https://lore.kernel.org/linux-mm/20200409094232.29680-1-sjpark@amazon.com/


Thanks,
SeongJae Park

> 
> -- 
> Mel Gorman
> SUSE Labs