Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 17 Apr 2020 19:05:06 +0200
From:   Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To:     Kaitao Cheng <pilgrimtao@gmail.com>
Cc:     tglx@linutronix.de, peterz@infradead.org, namit@vmware.com,
        linux-kernel@vger.kernel.org, songmuchun@bytedance.com
Subject: Re: [PATCH RESEND] kernel/smp: Use smp_call_func_t in on_each_cpu()
Message-ID: <20200417170506.ldz2eee4mm4szqij@linutronix.de>
References: <20200417162451.91969-1-pilgrimtao@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200417162451.91969-1-pilgrimtao@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-04-18 00:24:51 [+0800], Kaitao Cheng wrote:
> There is already a typedef smp_call_func_t, so we can just use it,
> maybe better.
> 
> Fixes: 3a5f65df5a0fc ("Typedef SMP call function pointer")
> Signed-off-by: Kaitao Cheng <pilgrimtao@gmail.com>

I would not go as far as the Fixes: tag but otherwise:

  Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

> ---
>  kernel/smp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/smp.c b/kernel/smp.c
> index 786092aabdcd..84303197caf9 100644
> --- a/kernel/smp.c
> +++ b/kernel/smp.c
> @@ -620,7 +620,7 @@ void __init smp_init(void)
>   * early_boot_irqs_disabled is set.  Use local_irq_save/restore() instead
>   * of local_irq_disable/enable().
>   */
> -void on_each_cpu(void (*func) (void *info), void *info, int wait)
> +void on_each_cpu(smp_call_func_t func, void *info, int wait)
>  {
>  	unsigned long flags;
>  

Sebastian