Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Christoph Hellwig'" <hch@infradead.org>
Cc:     <robh@kernel.org>, <devicetree@vger.kernel.org>,
        <linux-scsi@vger.kernel.org>, <linux-samsung-soc@vger.kernel.org>,
        <martin.petersen@oracle.com>, <linux-kernel@vger.kernel.org>,
        <krzk@kernel.org>, <kwmad.kim@samsung.com>, <avri.altman@wdc.com>,
        <cang@codeaurora.org>, "'Seungwon Jeon'" <essuuj@gmail.com>,
        <stanley.chu@mediatek.com>, <linux-arm-kernel@lists.infradead.org>
In-Reply-To: <20200413133926.GA29228@infradead.org>
Subject: RE: [PATCH v5 4/5] scsi: ufs-exynos: add UFS host support for
 Exynos SoCs
Date:   Fri, 17 Apr 2020 23:21:31 +0530
Message-ID: <018c01d614e0$d6f971f0$84ec55d0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQHr+Y8xYXIsvNQeqORDaXjXFCUqCgIAvgGXAbEacNoBTCAGfwGKzB3uAp+278eoAf9z0A==
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <20200412073159.37747-1-alim.akhtar@samsung.com>
        <CGME20200412074218epcas5p3ef7973c8a47533a15a359b069da8003c@epcas5p3.samsung.com>
        <20200412073159.37747-5-alim.akhtar@samsung.com>
        <20200412080947.GA6524@infradead.org>
        <000001d610e6$e8b11450$ba133cf0$@samsung.com>
        <20200413133926.GA29228@infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Christoph,
Thanks for your feedback.

> -----Original Message-----
> From: 'Christoph Hellwig' <hch@infradead.org>
> Sent: 13 April 2020 19:09
> To: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: 'Christoph Hellwig' <hch@infradead.org>; robh@kernel.org;
> devicetree@vger.kernel.org; linux-scsi@vger.kernel.org; linux-samsung-
> soc@vger.kernel.org; martin.petersen@oracle.com; linux-
> kernel@vger.kernel.org; krzk@kernel.org; kwmad.kim@samsung.com;
> avri.altman@wdc.com; cang@codeaurora.org; 'Seungwon Jeon'
> <essuuj@gmail.com>; stanley.chu@mediatek.com; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH v5 4/5] scsi: ufs-exynos: add UFS host support for
Exynos
> SoCs
> 
> On Sun, Apr 12, 2020 at 09:54:53PM +0530, Alim Akhtar wrote:
> > > So this doesn't actually require the various removed or not added
> > > quirks
> > after
> > > all?
> > This driver is actual consumer of those quirks, so those are still
needed.
> > On Martin's 5.7/scsi-queue need to revert " 492001990f64 scsi: ufshcd:
> > remove unused quirks"
> 
> No. You need to include one patch per quirk in your series to add them
back.
Sure, will send the updated version soon.

> Please also follow all proper kernel style guidelines, as the old code
didn't
> always follow the proper style.