Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp881168ybz; Fri, 17 Apr 2020 11:43:09 -0700 (PDT) X-Google-Smtp-Source: APiQypI4GMgUvMeGvKBkLYIjC0shqV+gO2zVzWLKsF4lPWtZOHMYi2qIfN08zAnU1TzURVzLKv30 X-Received: by 2002:a17:906:ecb8:: with SMTP id qh24mr4327749ejb.299.1587148989262; Fri, 17 Apr 2020 11:43:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587148989; cv=none; d=google.com; s=arc-20160816; b=n6lv/qbdqLGRVMKM1jcXpusYcxMX6NX0S8UpQcRNDR3UulLAzzkaoxZnaAWo0ArxAA bmeLBh7w4tS8/2flEIpBKMklA5I8FS9AsAOFAnK1CF2Ewkopic6xCOy1FjIfzPf8xS9Z DH4tNTL1nqK0IquwzS9NDXaOZ522RAu8aSHOi1MlgyQey+K++6eknKwepxxnGNNslUZ0 WSFkZKkhxDTOhzgcKPyQG10L5IvhrSwJSnp2XLNRBBWQydczXllAo2+WTMYnanf1TgKI nM7ScqwPllXAo5G558lgm54W1ONNbM599ai/FskZZgzOnxLzEX6KCW94HU6oW6m/ciZa DW4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oIYf6yLD6cGcNKPjnKZPwHWTMLSS0PgTGD6+kLZWz24=; b=Z5GhKUpm5w086LsJyxkOlrrZSlAvSUIK3TPkPJHggVz4AqpbTZVZB6Rq13NUf8LyRs Z9q8v0rZxwrdo1yJbQ8bWedzjZKcHwV8lpAOMLdg8FimhaLBpCoQ0LmOUFA88bqGWTw2 gJEqfOf300Bo/P4cbcE40RkPxorNTdziIGb22I1iXMqg0AzmA0QAUTIZVpTmLJfrbky3 /TiORWldH1JV3cOjHbTeEbBApHaEg2Fk/Q31mJnupkxy69tWdsnEl4PtaP6Pb9H2VMUR kxJkL3QJbTn0R+VWsO1PvH6mjlOGYc8+9hgrEJ4rNSTFrRcbtQg3BWSIFakqpFHQwicr 6/Ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=qn2RXZm7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v2si14764315ejx.85.2020.04.17.11.42.46; Fri, 17 Apr 2020 11:43:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=qn2RXZm7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729287AbgDQSlp (ORCPT + 99 others); Fri, 17 Apr 2020 14:41:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729029AbgDQSln (ORCPT ); Fri, 17 Apr 2020 14:41:43 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76FE1C061A0F; Fri, 17 Apr 2020 11:41:43 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id z6so4058408wml.2; Fri, 17 Apr 2020 11:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oIYf6yLD6cGcNKPjnKZPwHWTMLSS0PgTGD6+kLZWz24=; b=qn2RXZm7CQEK2b7CVa5xl9uSvLy65ZGWZ0dZZyISbrsJb0LQXt9eCD5+2BKd5jWT68 VCDk+2Q/hdoCN14v015Es9d2FxTKYVxbwNVCpE/Qq+Gi/PdgvV+E2s4jGLDOLZFZvmD6 Y86H7Ly/R5lc8w1vv95JqOXTMV0Z68GhtE14x2IL9owKM9Fbki6GTH3M/aS69WUB9in7 Yl/Elgwq0qrwv+nOpwN9fZIB3ZQJ6+egCW1+yuD+qCod6igLfPrTHd8OR2aRCiFZGzgU lXuZDJCZ5/VBQMHUj2vxUKZLeXkEdTPvjLR3L3gTzks39bsVsBlhOVZzvhH6vPVoWT+s uh+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oIYf6yLD6cGcNKPjnKZPwHWTMLSS0PgTGD6+kLZWz24=; b=nDNPE/IVcWXF4pBm/G0tCYb0dMP8uwWtTneNAlJ7Yf7cS3nPLSCLlZddPYCR+ZbCnv NJ+3x+V0rBE04yqqIj8d3f84KqdyuyW2TWAYFLJMWOHKIi2+HDOYX8eZucFgnFjjqM+/ luOI0O4uPrPksVtHEnfXxVE9LEQorVbC6UtOCv60pl/KoyiHy1W0FkN44MBqvQckD/4+ P73V6va6s8ySu559evJnrKJA0da1Ya/UVbUZIntWRUozI60qs/viaFl8Bi6mHX8ELoUu AjMLPo7jmxFeN+388g7eL/KtBG2vwx0uxKN74WA1ku+7LQWtF7fYZVgTFaEcEMZxuA9A tfqA== X-Gm-Message-State: AGi0PuaqsKq7Ue9Aspp2Kt1axYvrNilvI87/9mrtwduF047Ch3uUpuN9 zo5R0GN67qlKvvFHyDP41mw= X-Received: by 2002:a1c:98c2:: with SMTP id a185mr4892260wme.85.1587148902117; Fri, 17 Apr 2020 11:41:42 -0700 (PDT) Received: from localhost.localdomain (p200300F137142E00428D5CFFFEB99DB8.dip0.t-ipconnect.de. [2003:f1:3714:2e00:428d:5cff:feb9:9db8]) by smtp.googlemail.com with ESMTPSA id c17sm33237391wrp.28.2020.04.17.11.41.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2020 11:41:41 -0700 (PDT) From: Martin Blumenstingl To: jbrunet@baylibre.com, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org Cc: narmstrong@baylibre.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Martin Blumenstingl Subject: [PATCH v2 3/4] clk: meson: meson8b: Fix the vclk_div{1,2,4,6,12}_en gate bits Date: Fri, 17 Apr 2020 20:41:26 +0200 Message-Id: <20200417184127.1319871-4-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200417184127.1319871-1-martin.blumenstingl@googlemail.com> References: <20200417184127.1319871-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The DIV{1,2,4,6,12}_EN bits are actually located in HHI_VID_CLK_CNTL register: - HHI_VID_CLK_CNTL[0] = DIV1_EN - HHI_VID_CLK_CNTL[1] = DIV2_EN - HHI_VID_CLK_CNTL[2] = DIV4_EN - HHI_VID_CLK_CNTL[3] = DIV6_EN - HHI_VID_CLK_CNTL[4] = DIV12_EN Update the bits accordingly so we will enable the bits in the correct register once we switch these clocks to be mutable. Fixes: 6cb57c678bb70e ("clk: meson: meson8b: add the read-only video clock trees") Signed-off-by: Martin Blumenstingl --- drivers/clk/meson/meson8b.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c index 1dec8d5404a1..6d1727e62b55 100644 --- a/drivers/clk/meson/meson8b.c +++ b/drivers/clk/meson/meson8b.c @@ -1213,7 +1213,7 @@ static struct clk_regmap meson8b_vclk_in_en = { static struct clk_regmap meson8b_vclk_div1_gate = { .data = &(struct clk_regmap_gate_data){ - .offset = HHI_VID_CLK_DIV, + .offset = HHI_VID_CLK_CNTL, .bit_idx = 0, }, .hw.init = &(struct clk_init_data){ @@ -1243,7 +1243,7 @@ static struct clk_fixed_factor meson8b_vclk_div2_div = { static struct clk_regmap meson8b_vclk_div2_div_gate = { .data = &(struct clk_regmap_gate_data){ - .offset = HHI_VID_CLK_DIV, + .offset = HHI_VID_CLK_CNTL, .bit_idx = 1, }, .hw.init = &(struct clk_init_data){ @@ -1273,7 +1273,7 @@ static struct clk_fixed_factor meson8b_vclk_div4_div = { static struct clk_regmap meson8b_vclk_div4_div_gate = { .data = &(struct clk_regmap_gate_data){ - .offset = HHI_VID_CLK_DIV, + .offset = HHI_VID_CLK_CNTL, .bit_idx = 2, }, .hw.init = &(struct clk_init_data){ @@ -1303,7 +1303,7 @@ static struct clk_fixed_factor meson8b_vclk_div6_div = { static struct clk_regmap meson8b_vclk_div6_div_gate = { .data = &(struct clk_regmap_gate_data){ - .offset = HHI_VID_CLK_DIV, + .offset = HHI_VID_CLK_CNTL, .bit_idx = 3, }, .hw.init = &(struct clk_init_data){ @@ -1333,7 +1333,7 @@ static struct clk_fixed_factor meson8b_vclk_div12_div = { static struct clk_regmap meson8b_vclk_div12_div_gate = { .data = &(struct clk_regmap_gate_data){ - .offset = HHI_VID_CLK_DIV, + .offset = HHI_VID_CLK_CNTL, .bit_idx = 4, }, .hw.init = &(struct clk_init_data){ -- 2.26.1