Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200417202859.35427-1-contact@artur-rojek.eu>
 <20200417202859.35427-3-contact@artur-rojek.eu> <CAHp75Vcwnu8tw92nMYc_5-x_iX+FY8_OhtaJkSYNehmNUDkHGQ@mail.gmail.com>
 <3KAY8Q.NNI6X4F9QRIX1@crapouillou.net>
In-Reply-To: <3KAY8Q.NNI6X4F9QRIX1@crapouillou.net>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 18 Apr 2020 00:13:20 +0300
Message-ID: <CAHp75VfxQFFnVMhGvv0GCb3gv5jTPLDqLyhihRVc2earY=aYcg@mail.gmail.com>
Subject: Re: [RESEND PATCH v5 3/5] IIO: Ingenic JZ47xx: Add touchscreen mode.
To:     Paul Cercueil <paul@crapouillou.net>
Cc:     Artur Rojek <contact@artur-rojek.eu>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Heiko Stuebner <heiko@sntech.de>,
        linux-input <linux-input@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Apr 18, 2020 at 12:05 AM Paul Cercueil <paul@crapouillou.net> wrote=
:
> Le ven. 17 avril 2020 =C3=A0 23:59, Andy Shevchenko
> <andy.shevchenko@gmail.com> a =C3=A9crit :
> > On Fri, Apr 17, 2020 at 11:21 PM Artur Rojek <contact@artur-rojek.eu>
> > wrote:

...

> >>  +       irq =3D platform_get_irq(pdev, 0);
> >
> > Before it worked w/o IRQ, here is a regression you introduced.
>
> Before it simply did not need the IRQ, which is provided by the
> devicetree anyway. No regression here.

Does it work without IRQ? Or it was a dead code till now?
For me it's clear regression. Otherwise something is really wrong in a
process of development of this driver.

> >>  +       if (irq < 0) {
> >
> >>  +               dev_err(dev, "Failed to get irq: %d\n", irq);
> >
> > Redundant message.
> >
> >>  +               return irq;
> >>  +       }

--=20
With Best Regards,
Andy Shevchenko