Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1088621ybz; Fri, 17 Apr 2020 15:48:57 -0700 (PDT) X-Google-Smtp-Source: APiQypJF80atUOuTMRAbGF7Oyg3R3RLdgXcvLjwM5rlGLvSDvrgCb7KP1Xp+M/rZ3uDzHMAx1cjZ X-Received: by 2002:a17:906:33d4:: with SMTP id w20mr5227607eja.284.1587163737521; Fri, 17 Apr 2020 15:48:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1587163737; cv=pass; d=google.com; s=arc-20160816; b=FFH2qiruwpMvmtCLbNpTnDMybEOD1eGb6IsdEjhDZhHq80Qrb4Hj05bEtKolAUtJ37 GWuwEXfMV9khQCwjiKFicHlFRr58+jDGYIzHcq3Rr6Vq6VhhQio5wkHa+tKq5bRnWt0f CQ83ofxESVs4rDwX2BB/KuxgkOWMrH4+4OPbZwHqu4xrm17kpHxS95eWGmoznlqwV5Sn d9jh9CvaFuVnnUufSjOh1CfEy2VVB17a0dMmgI+TrigxDjlcOoWOL1kDLWHSYWbWUEI8 lFiUqepaCPf/f/gsKspf0uYOZb2JKUALa7KsJc1cgS79FqJWoKvUDmMo0e89UJIjPCoB Zdhw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :msip_labels:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=jRo9cNd8X0MZrxBtPbVzGf0xk7XSRaNn2De4naZ6UGs=; b=dGiG4LwgVZrFk/76zP8qeUcwN476HLc7sfyilvDieotbWGfdnoHs7GUEjEHPjm6ZcJ F20jz3clHXg0nGOxkK+YuYzo83H5baGsMFe3Pogb5xkp7BW3nMqFVhKpJOl3P0joRfD5 FlfEaICbJEoxlhAgaKvJQBp69O7hlAEPRYFWtCcamGrQuqTH0G8hHIBi15Qns1NZgWcQ 1JDk+vEW6MMbgNSIuX4+tfIs40HSc2pVs/WyF0OMX00ZWU+OMZ8+KhivxPCVLSSFEMPr QHnDYEopivydXCCSQr79gAPy4GX+6patDWwiE0cGiDGvYyQrVtTb4uSCLnxAMo3t07tz ekWQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=UfUOU6ds; arc=pass (i=1 spf=pass spfdomain=microsoft.com dkim=pass dkdomain=microsoft.com dmarc=pass fromdomain=microsoft.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ce2si16545163edb.26.2020.04.17.15.48.34; Fri, 17 Apr 2020 15:48:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=UfUOU6ds; arc=pass (i=1 spf=pass spfdomain=microsoft.com dkim=pass dkdomain=microsoft.com dmarc=pass fromdomain=microsoft.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729023AbgDQWpE (ORCPT + 99 others); Fri, 17 Apr 2020 18:45:04 -0400 Received: from mail-eopbgr1300101.outbound.protection.outlook.com ([40.107.130.101]:42570 "EHLO APC01-HK2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728482AbgDQWpD (ORCPT ); Fri, 17 Apr 2020 18:45:03 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=acxgRq0dahnOQuhHBXeAsFRUrjOZfTG7+KVaGsetEFQ1emJajlyw8Dhar57fl3bydfR85dmp9ImKiIIfolZKvUc344am3r8msMWyyiFqf2WWhAWWHiwdruo8zPVmmnyknVuwjbvSa4Cne3q3F+lB/IHGYQlU9x4KqUpVDz+ONEuyvM3glSp6arGhYbeYUM4DPcp9jtwpkzOnofIvPfAR0hiKm6FmxgFhCdMPDEaHPyVOc/FzXP1WyE6l+UflQ8fLGBQf1WdKTe9t0j08nDe6nKXnTTIeZ0ci6/BaMbvBubas9Jw/XkBsWCWkjeSvYqCl2IlLzWfi0HeV4YyFEelhGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jRo9cNd8X0MZrxBtPbVzGf0xk7XSRaNn2De4naZ6UGs=; b=U7XP+/tgb72C3ffj0ztMHYJKtCmaSh5tZHRPXn9g5IFBBCvH4TfxXkQiXRzaYZPLftLFTxgNAbhbNcZZNsM/Wd1igsfqvCK7ekxno1FguKObgljW2WrniXrXL0/jmrWjjGhY4tRiZiX9oOf4ng5ZE8JhB4vot8iHEudjNAHz0SLzJRwj9JA+Ivky9AparWSUD6lC15pKuaaie/4v27xcvWudPo2HHFn3/NYDZ/55cqTRD1o7t4/Wpb+ZsjT2dD23IER0UCBXmJmdYbXU9L/NlPQxDI+VwrpbwrRs2JubZdgAjUR0RWzcrLjMya9gMShkJ7eGKzQwF/3/Q3k1y96mfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jRo9cNd8X0MZrxBtPbVzGf0xk7XSRaNn2De4naZ6UGs=; b=UfUOU6dsJ8imR+JQEVLkw80FCeckafQdB5GEShfWaA0ht8y7OdZXBOum1kNLMjPSzqP5S9v6APP/v8xhkwIKKExOikfwJDYHaM4L/GFoKETjGXdf0JWdUAi6cguk3jCE3QINNL0iWoyLylhTmlsAD0kFS2kEqgI88wMxvGvQsMU= Received: from HK0P153MB0273.APCP153.PROD.OUTLOOK.COM (2603:1096:203:b2::12) by HK0P153MB0257.APCP153.PROD.OUTLOOK.COM (2603:1096:203:b1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.4; Fri, 17 Apr 2020 22:44:39 +0000 Received: from HK0P153MB0273.APCP153.PROD.OUTLOOK.COM ([fe80::2d07:e045:9d5b:898a]) by HK0P153MB0273.APCP153.PROD.OUTLOOK.COM ([fe80::2d07:e045:9d5b:898a%2]) with mapi id 15.20.2937.007; Fri, 17 Apr 2020 22:44:39 +0000 From: Dexuan Cui To: Wei Liu CC: "bp@alien8.de" , Haiyang Zhang , "hpa@zytor.com" , KY Srinivasan , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "mingo@redhat.com" , Stephen Hemminger , "tglx@linutronix.de" , "x86@kernel.org" , Michael Kelley , vkuznets Subject: RE: [PATCH] x86/hyperv: Suspend/resume the VP assist page for hibernation Thread-Topic: [PATCH] x86/hyperv: Suspend/resume the VP assist page for hibernation Thread-Index: AQHWFJewaoKQdpfmdUy/nWpslHqeNah96V2g Date: Fri, 17 Apr 2020 22:44:39 +0000 Message-ID: References: <1587104999-28927-1-git-send-email-decui@microsoft.com> <20200417090748.r2c45se5paqz5766@debian> In-Reply-To: <20200417090748.r2c45se5paqz5766@debian> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=decui@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-04-17T22:44:35.1962023Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=7d610e83-46e3-4c5e-8879-6a54a0f3001c; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic authentication-results: spf=none (sender IP is ) smtp.mailfrom=decui@microsoft.com; x-originating-ip: [2601:600:a280:7f70:6de6:6792:4d71:47c3] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3de2226e-a329-41df-4ce1-08d7e320e9ae x-ms-traffictypediagnostic: HK0P153MB0257:|HK0P153MB0257:|HK0P153MB0257: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0376ECF4DD x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HK0P153MB0273.APCP153.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(376002)(136003)(39860400002)(346002)(396003)(366004)(478600001)(186003)(76116006)(66476007)(10290500003)(64756008)(71200400001)(66556008)(66446008)(66946007)(8936002)(81156014)(8676002)(2906002)(52536014)(82960400001)(82950400001)(86362001)(6506007)(7696005)(9686003)(8990500004)(55016002)(4326008)(4744005)(5660300002)(316002)(6916009)(54906003)(33656002);DIR:OUT;SFP:1102; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dmaSLNJRERY0Bzy6zMxLbdU49kmO8HC9f8wGe0h2kAiV+O1yt/aLZgZeYbu5jwIltanaXSHYWTKDboFdoSg2XXPAGn35sSXN4K+gMtMCLUxWgjYx7dRl+cHpEgC2lfGboPFsIpB0CFrX42GGzOSTPuhMkXePPuvp0R1WNyj3Q1VHSIcm1WHBjgQjbzUURGMUFWyw0JGL+OPCkBBm6IpRr0VxPO0y25joL9NSQ7oUSK6AN6v/rlqNffWb++8qPSEjjyIhUiWaQ0pHgLdABIJPStGmrc4GJGb5K47bUiDPSye/MBEeIyScSMe0Zt53j4BNbWiNjTHa6lD2z4XwQr5kcTf0jNspMk8LVpXV0fItBqdztSlaJSSZmAVGy5sMbXwoywIAwKqbog6qt4C6+NSUzWeqWsHOMvx+kMVr/FDBP2A74Cg2aYLLDys3zai6bNj/ x-ms-exchange-antispam-messagedata: xP2nc1AT9/8eNdL54t48ruYxL+2faTSYtOkM/17zEay5T5t5QNist7apPCLfm7xdYaXZZwR1OWIsxlyGc6rH4Aad1Q7OIEX8iBQe82FjnGP49ona0qpkpA73j9FkZsXOT4et2XbvUb8ww/eStAFFlvUd3Vn//7jvK/bAfQ1FCMJl8DqqTwQZp2e27OOxmyA4cneHt8YmGlHgjp1Ro5T4KkyexYdQV/KCl5gXAY1oKLRPYIdeWrsK8/ZudurmKBsjnVjtsyuStZ2Tco3X+zMo7XUWKj2wjN4FXX3D5nXH0EzxhlQHeq9a0KGqEDeO+3XZfSyeIaHVs7aE7mHxcq8ld4RHuJbfq8fUt9yfheRbItckTZWpW5tAmDhI50E74MdBN0NPlBVYkoTkRLwVtQfOVTdb65YZiJ/CJQ8px78C013ZCys1RHcelaxLyQVsJWYmET2lcVSnpMSQ6Qf6+Lj0hZQnRS07qRU8fyl6d2q/yIuDs638HixRpZFoEY3iMEAA61NtKabArESxuHBQrUuJn/+XMbw5PST2V7rxJl0/ME9TxgzBdfLYtfPRu7KcizhqsjB2WB20VWzM05T+XCH9ldmhf1v/Aerafjbm0RxZ90cwUYcataKhsIt4SPs+MBREsHbfRP6TBQDmCtSv2EJ0HSm0X48qmTFks818vPsAtgT7bjwBsN8yrfZqgqNGEHamSL6erThbwb/rdsY16EjtKqnvJzP+jxUruki0VLBevCTPV0l2Prt9SwkTbecknKIwEiWmTveb3xjzvowQ+Gx02KkAR71C/eqst5dmeaOzFhnHdJMXuGtFuzA28cWA/NK0VQCENpJwReykI2PXJ5CjQJhbZ328bKnR4XT695mPsng= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3de2226e-a329-41df-4ce1-08d7e320e9ae X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2020 22:44:39.1159 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oWt0d/8R1cuQ6QVyomB8s7gbAwKaM3s2ggODSa0iC6m3sAsvW1tBraePWr9iOcgfWJavFALCoBhnYgbA4UmDYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0P153MB0257 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Wei Liu > Sent: Friday, April 17, 2020 2:08 AM > > @@ -72,7 +72,8 @@ static int hv_cpu_init(unsigned int cpu) > > struct page *pg; > > > > input_arg =3D (void **)this_cpu_ptr(hyperv_pcpu_input_arg); > > - pg =3D alloc_page(GFP_KERNEL); > > + /* hv_cpu_init() can be called with IRQs disabled from hv_resume() */ > > + pg =3D alloc_page(GFP_ATOMIC); >=20 > IMHO it would be better to only tap into the reserve pool if so > required, e.g. >=20 > pg =3D alloc_page(irqs_disabled() ? GFP_ATOMIC : GFP_KERNEL); >=20 > Wei. Ok, I'll follow the suggestion. BTW, there are indeed some usages like this, but not a lot: grep irqs_disabled drivers/acpi include/acpi drivers/trace -nr |grep GFP_AT= OMIC | grep GFP_KERNEL Thanks, -- Dexuan