Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1289536ybz; Fri, 17 Apr 2020 20:40:38 -0700 (PDT) X-Google-Smtp-Source: APiQypKt8MALm0to2JO+flCD51YKKFitNksyvZccMyyFB9ZNA/EIFsVIJKLraaZzVYDJPArK/dSD X-Received: by 2002:a17:906:35cd:: with SMTP id p13mr6349323ejb.206.1587181238674; Fri, 17 Apr 2020 20:40:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587181238; cv=none; d=google.com; s=arc-20160816; b=uLoDXhj7dguX1ykVdQXv1gvIVRVP1I8jnxRI/xzzO4CRWZL+GijN3jHzLqLf76NNZE KAi5XzYPdxSHW/6fyetIBbaoPAkKF4wqb66+BN/MbipTS94tIeC0ot6qGCVCG8W4/djE sRzrOhnmhu5tM5MM5yYhRDvrYhGxW6h83imc7kE/kBr6BO4uF7vJ025oArJihhbi/Cix WwmfpzNqlvAOD1tThSuzDmlZfImrS9sVJu+Co54WCz+6JADsVjqnWnve9TVVmR5lK1Vg pjFrkNbcZtGQcqVB4DwDE6N/CmOM7ijLIvJcjlO+5DJviO5rZiMXwEnvAdfcDa8flHHp LZ+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=I4TH2XxPoRqCQAiVceMrJ6JF2Ars1jAhN+GkKLq+qBA=; b=MA5sfBU36hFO90dJy9hN1/5Y4YIWrhMrAk8MTWnwbx3wwQUThm3mSp9V6Q/xWxVCnE 0z1+fDMW2Cb5QbcC45kRZOnz9q/yXPXBP8NKFVgM6vbhhFeeYEy30EUVWi5HkqdsgT4Z k5FOZte7+uEnE5yIW972HfLe1k6rZ2TqDOgNmZgIFwPi3o5//DX6OQKeYahGk3ZMRVw/ U5JYlSBqi9G+izyh0K2a8kmgPRAMgPI5ZKGUP+oxA+PZuE466q1pAo138jDyMK6w1wA6 lcoHHLN9oJsifAdLp0ibsagZ8Wx1pY3/tgAo9Zrifk2caoll4JbeduBs3xzGLmUFJuCD J4CA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=vDno9PVL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g20si4448712edm.43.2020.04.17.20.40.15; Fri, 17 Apr 2020 20:40:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=vDno9PVL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725949AbgDRDir (ORCPT + 99 others); Fri, 17 Apr 2020 23:38:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725320AbgDRDiq (ORCPT ); Fri, 17 Apr 2020 23:38:46 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADCFFC061A0C for ; Fri, 17 Apr 2020 20:38:46 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id hi11so1228598pjb.3 for ; Fri, 17 Apr 2020 20:38:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=I4TH2XxPoRqCQAiVceMrJ6JF2Ars1jAhN+GkKLq+qBA=; b=vDno9PVLultcm6YIs0lgt1nHx8S+GaUz2rUcccr2W+TcwDwEU06i7IFQ6I4FamebXD phJTlHBda+hMxHcxYHWBYgZeCPjbDYetGVDyFzosCtx5Kkm0pbH6cNvXYSJtINDqJV+X c3L+ZeP2HXsJuA9wEK3GRMWt39segDCz7I8GCMzYBaRUwPwuM3drd4leZiDbOMs3hyiq tFFbp+eZEv16CUzpFED47BkVxtMalx9qV1aUp1lkR36Pj3kk6KVt1RR61U/TxSdRwMg1 GwBhcrimkOAEsQNynzGmMyIZooleRS9aES8XVSbSMmA4LiOS+YOC/AMbyzKHwa59jLLZ fgKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=I4TH2XxPoRqCQAiVceMrJ6JF2Ars1jAhN+GkKLq+qBA=; b=W4cVZ7pca+LfzlkRl3FeG0m+UmeB0HaXIZ513N4/dbdaBt0Uqs/IwNvcGu7Yf14/NV lAnKjo0faeNN0yC68dncidwSLo2T8hsKP0LbSRi/enfzrHmxJQoQl8AjU48NmO4qXQiJ MK/KSU+ZI8MG7uxi3ol6UAzt2XBUmhMDTChG1SAW3fSA4lZm4D2r06Y3ACO0Uw8Dx5ZT h2UH0x6Q00C27WylLS6+53ZuPccMx9vUe1pOcydcz23NOr+cHrTEr5/MwonrXGaBJiOx 8HUMzwIVpLSErgRBB38m9Zmz0U0M9UeuLRwcmuncZ4rZmcnXVxYtxckIDD6nalloYU2a GNpA== X-Gm-Message-State: AGi0PubsIn67m1hKkfd+i/bv/qa3kJ5Kud/XtXRyN9BfvnbLPQTGz67z GHsRO3OvY5nC/SBgnm3AJtN+nA== X-Received: by 2002:a17:90b:2388:: with SMTP id mr8mr8078215pjb.107.1587181125903; Fri, 17 Apr 2020 20:38:45 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id v67sm17068790pfb.83.2020.04.17.20.38.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2020 20:38:45 -0700 (PDT) Subject: Re: [PATCH] buffer: remove useless comment and WB_REASON_FREE_MORE_MEM, reason. To: Zhiqiang Liu , viro@zeniv.linux.org.uk, rostedt@goodmis.org, mingo@redhat.com, "linux-kernel@vger.kernel.org" , linux-fsdevel@vger.kernel.org Cc: jack@suse.cz, tj@kernel.org, bigeasy@linutronix.de, linfeilong , Yanxiaodan , Mingfangsen , renxudong References: <5844aa66-de1e-278b-5491-b7e6839640e9@huawei.com> From: Jens Axboe Message-ID: Date: Fri, 17 Apr 2020 21:38:42 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <5844aa66-de1e-278b-5491-b7e6839640e9@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/12/20 11:12 PM, Zhiqiang Liu wrote: > From: Zhiqiang Liu > > free_more_memory func has been completely removed in commit bc48f001de12 > ("buffer: eliminate the need to call free_more_memory() in __getblk_slow()") > > So comment and `WB_REASON_FREE_MORE_MEM` reason about free_more_memory > are no longer needed. Applied, with: Fixes: bc48f001de12 ("buffer: eliminate the need to call free_more_memory() in __getblk_slow()") added. -- Jens Axboe