Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1399895ybz; Fri, 17 Apr 2020 23:42:42 -0700 (PDT) X-Google-Smtp-Source: APiQypII5NBdG7kNiAXXGe2nABSl+5n79Q7mIouY6Njb1JFw1WxdvghBGmG1kLkq8DDxdnyNDaKi X-Received: by 2002:aa7:d685:: with SMTP id d5mr5828780edr.340.1587192162106; Fri, 17 Apr 2020 23:42:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587192162; cv=none; d=google.com; s=arc-20160816; b=qkbLOw3HgiwSMGpQCHkXJCjudRg9H6KRu7+OJSh0HVbbwDUSoOszZmxetIoeyR4o+d jAM1MnKrsc/JLF8ZLfTUFkMNNvDlkPc1FGylQeFW0ZbcPht2RQ/FV3/oc+0ashtnLXW+ diURlWhnbjb/wa01Zux3o4h0fUCBM6S2fInciRRxdT/Jv8UD7UXTs5Vgd9GGG+/GdeLw Cs5QMzJR1LFdHVE8vMbgyYtUCEtmP/aPP2/rGinTRnPRFe16c8AFUyp5xgp9oT7kH+GM W1Y3WMmC+y4rREbgmAa2LcRYx6SBlnphDn/Ls+JPe/C0w6Q1o0czVyG8uww7gJ053yYS EuYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=B7SA3T1/jEEOezL2YTnbNcS9QiGwAOYFxyw+ExeHgRo=; b=kR9A4uvCxa4AMxdbOPkBrc/RThiFI8KAtg7UFrKRykCbY4WiP+sBCCwZCMRjGc9RE+ I+EXarmCD8sSS1D/4h5R8nB5+AVtDJUWbUZjapd3nTyY5fqT5o9T1QXdLTBzdHAvLjJG elq+9R/QxPx3qtRTI2ZJLEDZM9QxJPs1KgEZUV0snUVwu3K+RcXuppc4Mk7XD3QPUEYR 0yx/agE5h5uh6YI9sbAueyef4gKfrpYpm8lH7Wyf1aHpAAWNzkSb8yJGsGFi8e+9Pf5Z xO9/purV10qxtsgzXDSnIDx2WZ4ji5gBin0zL+W1rCWMzc8UUDyTwacpm3x57wtMxchr TFJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a24si8656115eds.168.2020.04.17.23.41.44; Fri, 17 Apr 2020 23:42:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726069AbgDRGju (ORCPT + 99 others); Sat, 18 Apr 2020 02:39:50 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:46642 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725856AbgDRGjt (ORCPT ); Sat, 18 Apr 2020 02:39:49 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 50F7E2C517DEDF7A82E2; Sat, 18 Apr 2020 14:39:48 +0800 (CST) Received: from huawei.com (10.175.124.28) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Sat, 18 Apr 2020 14:39:39 +0800 From: Jason Yan To: , , , , , CC: Jason Yan , Hulk Robot Subject: [PATCH] scsi: st: remove unneeded variable 'result' in st_release() Date: Sat, 18 Apr 2020 15:06:05 +0800 Message-ID: <20200418070605.11450-1-yanaijie@huawei.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Also remove a strange '^L' after this function. Fix the following coccicheck warning: drivers/scsi/st.c:1460:5-11: Unneeded variable: "result". Return "0" on line 1473 Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/scsi/st.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index c5f9b348b438..4bf4ab3b70f4 100644 --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c @@ -1457,7 +1457,6 @@ static int st_flush(struct file *filp, fl_owner_t id) accessing this tape. */ static int st_release(struct inode *inode, struct file *filp) { - int result = 0; struct scsi_tape *STp = filp->private_data; if (STp->door_locked == ST_LOCKED_AUTO) @@ -1470,9 +1469,9 @@ static int st_release(struct inode *inode, struct file *filp) scsi_autopm_put_device(STp->device); scsi_tape_put(STp); - return result; + return 0; } - + /* The checks common to both reading and writing */ static ssize_t rw_checks(struct scsi_tape *STp, struct file *filp, size_t count) { -- 2.21.1