Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1465510ybz; Sat, 18 Apr 2020 01:22:48 -0700 (PDT) X-Google-Smtp-Source: APiQypJtXb62Um7t2P679pVH30h+H7tzsoDSDHo3RPg9NeCYmDcnkG6Rp5zHf7v7adygLSmnTsjN X-Received: by 2002:a17:907:1199:: with SMTP id uz25mr6807788ejb.131.1587198167890; Sat, 18 Apr 2020 01:22:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587198167; cv=none; d=google.com; s=arc-20160816; b=O+EIaiJvMNEfN9t97G7esTZffZmCDVIUe7F9nQSDkj7jSUA3oYieH4oF3r07+DcAv5 BTV4cfMCykOEbuJ0LWjKpaIjjqVDE3IFQregMZTks3JKdSqa6the0zNiyO7LUG/M6t5g L3CqvNWZO1sG53DJlcZLEsVeJX8XKn00noyYdxKx4A6LevIQaPwXI94QiN9+mJVJ2l2X z9NreG3BXofVXQ6rxWWwj3waAS65YzpILdCsaXUgl/AbjtNzrW/n5sHSj4w414REWVNd KLMD4aBMOsS3qcSmddgSXzJPJOOnAHDK7LXIFZfUchGr4B6OUKvTzCacP4aawGDOOb/Z aw0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=v8RC3lM119mByCUSuLXagf8GpGwfc/WMlIE01WyWCOs=; b=sn4yFNLswhBRwPxxCHqkwJ4qTjfI57L9uW/qdanwW80D9eJ2AGiOrlpNFiA1n/9aM9 68BI01Eyx/lXRVBk/hC5b5zff6bO9iZnXkR4dL3p61hHJ9qfQX2l2O3XvsJ5vyM2Yrn6 cir9Tivxa0hC6V0r1nnsXrNkE/ii4pjnmbzDLPBbJx1ki1Q/KYxABn/i6RyzYOXF7wt2 eV1JLoRSBV5ZDvhxG5aUzvWvwMi5JKjF+sLUUm0gCaDQpueWvdij46OC0o+bUhIug+Nj B3CK2gaQK7rID8eKv6uT6+lV4GozKLdAi8sTqgh4YC7JH6NjczMEmWfVDU4Vs0Wqnpju ZQYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cumulusnetworks.com header.s=google header.b=fQQWygvZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cumulusnetworks.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a17si987006edb.590.2020.04.18.01.22.24; Sat, 18 Apr 2020 01:22:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cumulusnetworks.com header.s=google header.b=fQQWygvZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cumulusnetworks.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725950AbgDRIVO (ORCPT + 99 others); Sat, 18 Apr 2020 04:21:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbgDRIVO (ORCPT ); Sat, 18 Apr 2020 04:21:14 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10737C061A0F for ; Sat, 18 Apr 2020 01:21:14 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id 198so3721554lfo.7 for ; Sat, 18 Apr 2020 01:21:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=v8RC3lM119mByCUSuLXagf8GpGwfc/WMlIE01WyWCOs=; b=fQQWygvZdTVZSiMjo5o7XeQUoM+r88ifUrZY5qcYmS5MSOBJsI6NG/x/KcLgAs7pKC +UtywlGEvqt5PyAoD9LP4b+hT+YsBmFXRssL8RTWccsXzIsOPuMNsHJ+bYu3Eqpvys06 /B2cadDy0q+EXXzpNmj3viN7DaOg/1weiy3g4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=v8RC3lM119mByCUSuLXagf8GpGwfc/WMlIE01WyWCOs=; b=QPNDVfhYng4DUTWwSn56se5GDH4dREmwfKUcb1/SKgL03MtWq7FQHIA83G9Id6GQex 9lpXG5f6QHkABObr95kMCE+p8ziVgbkNnmOjNwlvlClUM2qQ4QNRUgBLIIEn4jotJeR6 53CbnP+Blje7zAB1TdXgUUodTXRUhSVD+4U4AZM5TUgGdfoB7/PwrVCLtTuJ/4kHR3TH HC8kDl3KH2FuhnAGcuEHEefdw4DKxkBdBROEJuyOKPFwxO8gKUfDh7X1FKSVHK/1ZDZa fWQxwos2ITVAkPoj6gKqEmkJITRVscKLNrOCJcjC7rbHqyMYUdKIyhcPb7F/B5pHXEZb JL4A== X-Gm-Message-State: AGi0PuZCBiu+tc9xzJhXY2rkiFpRQBwg92gLaSqhnrMZ0YNRE2XJB2z/ 5WJ6iZ6Y5eQycLZTXlIjELiyNQ== X-Received: by 2002:a05:6512:3b0:: with SMTP id v16mr4457346lfp.213.1587198072400; Sat, 18 Apr 2020 01:21:12 -0700 (PDT) Received: from [192.168.0.109] (84-238-136-197.ip.btc-net.bg. [84.238.136.197]) by smtp.gmail.com with ESMTPSA id w24sm20024957lfe.58.2020.04.18.01.21.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Apr 2020 01:21:11 -0700 (PDT) Subject: Re: [RFC net-next v5 8/9] bridge: mrp: Implement netlink interface to configure MRP To: Horatiu Vultur , davem@davemloft.net, jiri@resnulli.us, ivecera@redhat.com, kuba@kernel.org, roopa@cumulusnetworks.com, olteanv@gmail.com, andrew@lunn.ch, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, UNGLinuxDriver@microchip.com References: <20200414112618.3644-1-horatiu.vultur@microchip.com> <20200414112618.3644-9-horatiu.vultur@microchip.com> From: Nikolay Aleksandrov Message-ID: Date: Sat, 18 Apr 2020 11:21:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200414112618.3644-9-horatiu.vultur@microchip.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/04/2020 14:26, Horatiu Vultur wrote: > Implement netlink interface to configure MRP. The implementation > will do sanity checks over the attributes and then eventually call the MRP > interface. > > Signed-off-by: Horatiu Vultur > --- > net/bridge/br_mrp_netlink.c | 164 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 164 insertions(+) > create mode 100644 net/bridge/br_mrp_netlink.c > > diff --git a/net/bridge/br_mrp_netlink.c b/net/bridge/br_mrp_netlink.c > new file mode 100644 > index 000000000000..0d8253311595 > --- /dev/null> +++ b/net/bridge/br_mrp_netlink.c > @@ -0,0 +1,164 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > + > +#include > + > +#include > +#include "br_private.h" > +#include "br_private_mrp.h" > + > +static const struct nla_policy br_mrp_policy[IFLA_BRIDGE_MRP_MAX + 1] = { > + [IFLA_BRIDGE_MRP_UNSPEC] = { .type = NLA_REJECT }, > + [IFLA_BRIDGE_MRP_INSTANCE] = { .type = NLA_EXACT_LEN, > + .len = sizeof(struct br_mrp_instance)}, > + [IFLA_BRIDGE_MRP_PORT_STATE] = { .type = NLA_U32 }, > + [IFLA_BRIDGE_MRP_PORT_ROLE] = { .type = NLA_EXACT_LEN, > + .len = sizeof(struct br_mrp_port_role)}, > + [IFLA_BRIDGE_MRP_RING_STATE] = { .type = NLA_EXACT_LEN, > + .len = sizeof(struct br_mrp_ring_state)}, > + [IFLA_BRIDGE_MRP_RING_ROLE] = { .type = NLA_EXACT_LEN, > + .len = sizeof(struct br_mrp_ring_role)}, > + [IFLA_BRIDGE_MRP_START_TEST] = { .type = NLA_EXACT_LEN, > + .len = sizeof(struct br_mrp_start_test)}, > +}; > + > +int br_mrp_parse(struct net_bridge *br, struct net_bridge_port *p, > + struct nlattr *attr, int cmd, struct netlink_ext_ack *extack) > +{ > + struct nlattr *tb[IFLA_BRIDGE_MRP_MAX + 1]; > + int err; > + > + if (br->stp_enabled != BR_NO_STP) { > + br_warn(br, "MRP can't be enabled if STP is already enabled\n"); Use extack. > + return -EINVAL; > + } > + > + err = nla_parse_nested(tb, IFLA_BRIDGE_MRP_MAX, attr, > + NULL, extack); > + if (err) > + return err; > + > + if (tb[IFLA_BRIDGE_MRP_INSTANCE]) { > + struct br_mrp_instance *instance = > + nla_data(tb[IFLA_BRIDGE_MRP_INSTANCE]); > + > + if (cmd == RTM_SETLINK) > + err = br_mrp_add(br, instance); > + else > + err = br_mrp_del(br, instance); > + if (err) > + return err; > + } > + > + if (tb[IFLA_BRIDGE_MRP_PORT_STATE]) { > + enum br_mrp_port_state_type state = > + nla_get_u32(tb[IFLA_BRIDGE_MRP_PORT_STATE]); > + > + err = br_mrp_set_port_state(p, state); > + if (err) > + return err; > + } > + > + if (tb[IFLA_BRIDGE_MRP_PORT_ROLE]) { > + struct br_mrp_port_role *role = > + nla_data(tb[IFLA_BRIDGE_MRP_PORT_ROLE]); > + > + err = br_mrp_set_port_role(p, role); > + if (err) > + return err; > + } > + > + if (tb[IFLA_BRIDGE_MRP_RING_STATE]) { > + struct br_mrp_ring_state *state = > + nla_data(tb[IFLA_BRIDGE_MRP_RING_STATE]); > + > + err = br_mrp_set_ring_state(br, state); > + if (err) > + return err; > + } > + > + if (tb[IFLA_BRIDGE_MRP_RING_ROLE]) { > + struct br_mrp_ring_role *role = > + nla_data(tb[IFLA_BRIDGE_MRP_RING_ROLE]); > + > + err = br_mrp_set_ring_role(br, role); > + if (err) > + return err; > + } > + > + if (tb[IFLA_BRIDGE_MRP_START_TEST]) { > + struct br_mrp_start_test *test = > + nla_data(tb[IFLA_BRIDGE_MRP_START_TEST]); > + > + err = br_mrp_start_test(br, test); > + if (err) > + return err; > + } > + > + return 0; > +} > + > +static inline size_t br_mrp_nlmsg_size(void) > +{ > + return NLMSG_ALIGN(sizeof(struct ifinfomsg)) > + + nla_total_size(4); /* IFLA_BRIDGE_MRP_RING_OPEN */ > +} > + > +int br_mrp_port_open(struct net_device *dev, u8 loc) > +{ > + struct nlattr *af, *mrp; > + struct ifinfomsg *hdr; > + struct nlmsghdr *nlh; > + struct sk_buff *skb; > + int err = -ENOBUFS; > + struct net *net; > + > + net = dev_net(dev); > + > + skb = nlmsg_new(br_mrp_nlmsg_size(), GFP_ATOMIC); > + if (!skb) > + goto errout; > + > + nlh = nlmsg_put(skb, 0, 0, RTM_NEWLINK, sizeof(*hdr), 0); > + if (!nlh) > + goto errout; > + > + hdr = nlmsg_data(nlh); > + hdr->ifi_family = AF_BRIDGE; > + hdr->__ifi_pad = 0; > + hdr->ifi_type = dev->type; > + hdr->ifi_index = dev->ifindex; > + hdr->ifi_flags = dev_get_flags(dev); > + hdr->ifi_change = 0; > + > + af = nla_nest_start_noflag(skb, IFLA_AF_SPEC); > + if (!af) { > + err = -EMSGSIZE; > + goto nla_put_failure; > + } > + > + mrp = nla_nest_start_noflag(skb, IFLA_BRIDGE_MRP); > + if (!mrp) { > + err = -EMSGSIZE; > + goto nla_put_failure; > + } > + > + err = nla_put_u32(skb, IFLA_BRIDGE_MRP_RING_OPEN, loc); > + if (err) > + goto nla_put_failure; > + > + nla_nest_end(skb, mrp); > + nla_nest_end(skb, af); > + nlmsg_end(skb, nlh); > + > + rtnl_notify(skb, net, 0, RTNLGRP_LINK, NULL, GFP_ATOMIC); > + return 0; > + > +nla_put_failure: > + nlmsg_cancel(skb, nlh); > + kfree_skb(skb); > + > +errout: > + rtnl_set_sk_err(net, RTNLGRP_LINK, err); > + return err; > +} > +EXPORT_SYMBOL(br_mrp_port_open); > Why do you need this function when you already have br_ifinfo_notify() ?