Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Avri Altman'" <Avri.Altman@wdc.com>, <robh@kernel.org>
Cc:     <devicetree@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
        <krzk@kernel.org>, <martin.petersen@oracle.com>,
        <kwmad.kim@samsung.com>, <stanley.chu@mediatek.com>,
        <cang@codeaurora.org>, <linux-samsung-soc@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
In-Reply-To: <SN6PR04MB46402211952BC3D427AADA00FCD60@SN6PR04MB4640.namprd04.prod.outlook.com>
Subject: RE: [PATCH v6 0/10] exynos-ufs: Add support for UFS HCI
Date:   Sat, 18 Apr 2020 18:38:21 +0530
Message-ID: <002a01d61582$72250990$566f1cb0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQJ+JYn7iegE7csgtlAtGJi8waFUgQJQDPilAZpCPd2nD2XiwA==
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <CGME20200417181006epcas5p269f8c4b94e60962a0b0318ef64a65364@epcas5p2.samsung.com>
        <20200417175944.47189-1-alim.akhtar@samsung.com>
        <SN6PR04MB46402211952BC3D427AADA00FCD60@SN6PR04MB4640.namprd04.prod.outlook.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Avri,

> -----Original Message-----
> From: Avri Altman <Avri.Altman=40wdc.com>
> Sent: 18 April 2020 18:09
> To: Alim Akhtar <alim.akhtar=40samsung.com>; robh=40kernel.org
> Cc: devicetree=40vger.kernel.org; linux-scsi=40vger.kernel.org; krzk=40ke=
rnel.org;
> martin.petersen=40oracle.com; kwmad.kim=40samsung.com;
> stanley.chu=40mediatek.com; cang=40codeaurora.org; linux-samsung-
> soc=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org; linux-
> kernel=40vger.kernel.org
> Subject: RE: =5BPATCH v6 0/10=5D exynos-ufs: Add support for UFS HCI
>=20
>=20
> >
> > This patch-set introduces UFS (Universal Flash Storage) host
> > controller support for Samsung family SoC. Mostly, it consists of UFS
> > PHY and host specific driver.
> >
> > - Changes since v5:
> > * re-introduce various quicks which was removed because of no driver
> > * consumer of those quirks, initial 4 patches does the same.
> You forgot to add those quirks to ufs_fixups.

ufs_fixups are for ufs __device__ related quirks, what I have posted are al=
l host controller quirks.
Please have a look on the other quirks related to HCI like UFSHCD_QUIRK_BRO=
KEN_UFS_HCI_VERSION
Which is used in other vendor HCI driver.=20
Let me know if I am missing anything here.

> Each patch that introduces a quirk needs to introduce its users as well -=
 This is
> the reason it was removed in the first place.
>=20
> Thanks,
> Avri