Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1723169ybz; Sat, 18 Apr 2020 07:11:26 -0700 (PDT) X-Google-Smtp-Source: APiQypLf5ig78af9zOL4zlkvkxogdxdPLrsym/HcqWjo80aKPzRYdZJmoESSUzCJ+DUNUQd2szr8 X-Received: by 2002:a05:6402:712:: with SMTP id w18mr7379510edx.386.1587219086631; Sat, 18 Apr 2020 07:11:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587219086; cv=none; d=google.com; s=arc-20160816; b=NSbxclKxUSEJYaOv6xgwFVP84Q0+fFcsl/RbHmCGlT9NI6MAQ9LF+Tjua+I4gTYfUr C/vqPDgMsCHLIjzgETCde8oc6OFUicBnL95pBoFYrAQz53exiWM2QuZNMK3+fYD4VDU4 aNY+jGm0g+zd973hIRMMdaiiaGmcUxF995v15KPX1WqpxVgqLX99BNZytf6T6JJZmo+B 4ylDA4beS38zF7R77Vmi/UnqmSn/c4q7SKS3WucOzhd+No9u8I/kY71Tv8r8dUSQ8IHs UhVD7T9riHVNZPnDNiaBx0Lu2ojYUZlqI5vejmAoM7SRcDbijJgGmUAPNuyMcEKIVzgD rtKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fSqx9QqFFlyM5xqwgXeqQ+WdjXMOjDGY/j6ULRQqZKA=; b=wRP99Y8XL9OFLpBoIseZlPqbk4Q54WxYWlurNgOmdeXvQD6proTcvmMXAzgx2EugRZ 9A+tjjDwkB8vKF0OKhWnpm02FeTu68WtQGTSUkcVbKQsbe8kcbJDJVy2lohbo59jILuO ET7zYpf0DQBIgocP33MUMF9bBdeCbWw4eh3di8pMJV8OOd8P74Cc2C+A9TNZ1aaccZ87 Xn/aN+tDGOp5OE8WSgwyZENwDu9/hogsYAbzsYgVIs8fXTveb5c5oIpC23ivhq1ahggo iDa3IaajWxYf/G21YEddi96y2pn4HyLKXxBuuu8iyCMge5w8pbyUTSIevO0jbR08zVIe hn6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CrwTugD8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p16si11599348eja.354.2020.04.18.07.11.04; Sat, 18 Apr 2020 07:11:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CrwTugD8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726660AbgDROJp (ORCPT + 99 others); Sat, 18 Apr 2020 10:09:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:37264 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726606AbgDROJm (ORCPT ); Sat, 18 Apr 2020 10:09:42 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0561821D82; Sat, 18 Apr 2020 14:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587218981; bh=no3knKj15K/kqw5BYs/rcA1+Ow+Jsr8lPJT0094hSSg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CrwTugD8JOtgd72UNzju6gCK+sfNCjOF0suyH17+BrjQxXstVJcP7QAyoJBkZ11BQ F6rYtqGHQ37u3C6T2pU2B2CKcTy063hCfB/fvNkZOMo18ESzY+NzSlXqDZyM0uP05f 6jntwZxBftNKFOsS3uqV1s69Sp5ll1U9a2cDXQOE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Vasily Averin , Andrew Morton , Peter Oberparleiter , Al Viro , Davidlohr Bueso , Ingo Molnar , Manfred Spraul , NeilBrown , Steven Rostedt , Waiman Long , Linus Torvalds , Sasha Levin Subject: [PATCH AUTOSEL 5.5 25/75] kernel/gcov/fs.c: gcov_seq_next() should increase position index Date: Sat, 18 Apr 2020 10:08:20 -0400 Message-Id: <20200418140910.8280-25-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200418140910.8280-1-sashal@kernel.org> References: <20200418140910.8280-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasily Averin [ Upstream commit f4d74ef6220c1eda0875da30457bef5c7111ab06 ] If seq_file .next function does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: Andrew Morton Acked-by: Peter Oberparleiter Cc: Al Viro Cc: Davidlohr Bueso Cc: Ingo Molnar Cc: Manfred Spraul Cc: NeilBrown Cc: Steven Rostedt Cc: Waiman Long Link: http://lkml.kernel.org/r/f65c6ee7-bd00-f910-2f8a-37cc67e4ff88@virtuozzo.com Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- kernel/gcov/fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c index e5eb5ea7ea598..cc4ee482d3fba 100644 --- a/kernel/gcov/fs.c +++ b/kernel/gcov/fs.c @@ -108,9 +108,9 @@ static void *gcov_seq_next(struct seq_file *seq, void *data, loff_t *pos) { struct gcov_iterator *iter = data; + (*pos)++; if (gcov_iter_next(iter)) return NULL; - (*pos)++; return iter; } -- 2.20.1