Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1729801ybz; Sat, 18 Apr 2020 07:19:13 -0700 (PDT) X-Google-Smtp-Source: APiQypKbvOwhgIw8KTZbetdSRQdQIi8GzbSoRWSNQlfP50yaGNgMoOvkCiQq4YsKmFqw9O8S56pI X-Received: by 2002:a17:906:4cd2:: with SMTP id q18mr726161ejt.70.1587219553126; Sat, 18 Apr 2020 07:19:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587219553; cv=none; d=google.com; s=arc-20160816; b=zEb2CZfDYYfjZGqD8k9XSF5yNWkepcorfWA97F4Q/QgP7/uxZIZ2FLI0p4EDFcojz+ /T80+HBKfpXGsCuD1l5/9OeFoL5rfqlpBhKlnPug4ggo5VjfJGH3WVEgzu6OjywyqQhq s8AMiJhTUkJDGf0FM+RjtjazqznpOeHFq1ZsNHcm+uxmVObdkx7NXr5w95iEoISBcasF XGce1kiNOLNXGBGs6egagXdSTQVPylmB6qELBLfRLLpxTe1/nrAiOnlM+S3/6laBmH3Q HILpEa6LZ7YlcAvcIwkQjASeMUdczMLtJweO40Q7S1Q0vJrLvSegH4yAlsHVvd0zhFZb VJUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xuds0JCz9wI0A2fNxFtAYUE5lMEn4eC7v80KaQ/LXFM=; b=LDNkCFOfHQnu4Dxv8mOfYUDSYI1sOz00ipzvBhJ9mBtpP3D4mo+bh+IGsc3oBsgySV eEM0m6kEwHHQiMpHoK2OIT/UEmSZXR5P/ci4KqIOzayhgd27lfHYfCua6UbQtzKC2CLa YafCAYfcoRVS5FkjLGuouYJreTuUP7xX+9m2nODiZ7TlMxzT+Oh1jI55wh+JrOwsrGoR exJ1Nex+Jzcvid4OjM319zXuxV/0ovjgxeVwXamRwkk+cOTqLfiyJ+rkEADFtOdYxbnm /DE/d4rd+1rUK1HpBQKG69oBcfn8AtNvWtIRPzBE4yrr6/hNkugWHC22pG3H/8ZbVjKj Hi3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=H9NJTnNY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r15si15855675edx.362.2020.04.18.07.18.50; Sat, 18 Apr 2020 07:19:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=H9NJTnNY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726116AbgDROJP (ORCPT + 99 others); Sat, 18 Apr 2020 10:09:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:36428 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725873AbgDROJO (ORCPT ); Sat, 18 Apr 2020 10:09:14 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C07EA21D6C; Sat, 18 Apr 2020 14:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587218954; bh=ddR3lY7X7Py94OEnLYZZsrm3gr2MaNXEqKJZwflfaEg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H9NJTnNYBSAOZR2vCSdgGYf7vlYvrp8G0ZbrzCw5S+AlL0xzUQv/vGErGBZ21VmE1 gphoihsO/uj4cAbJx6c+8LU09lHqE/oD2qGKox7fAvwNIdpT1MwPNlXRowR6Zw4sey 75bGAR0DEsv4gQICiCnvUrjwQdaZ9xf2La/mXchw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tero Kristo , Guenter Roeck , Wim Van Sebroeck , Sasha Levin , linux-watchdog@vger.kernel.org Subject: [PATCH AUTOSEL 5.5 03/75] watchdog: reset last_hw_keepalive time at start Date: Sat, 18 Apr 2020 10:07:58 -0400 Message-Id: <20200418140910.8280-3-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200418140910.8280-1-sashal@kernel.org> References: <20200418140910.8280-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tero Kristo [ Upstream commit 982bb70517aef2225bad1d802887b733db492cc0 ] Currently the watchdog core does not initialize the last_hw_keepalive time during watchdog startup. This will cause the watchdog to be pinged immediately if enough time has passed from the system boot-up time, and some types of watchdogs like K3 RTI does not like this. To avoid the issue, setup the last_hw_keepalive time during watchdog startup. Signed-off-by: Tero Kristo Reviewed-by: Guenter Roeck Link: https://lore.kernel.org/r/20200302200426.6492-3-t-kristo@ti.com Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck Signed-off-by: Sasha Levin --- drivers/watchdog/watchdog_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c index 8b5c742f24e81..7e4cd34a8c20e 100644 --- a/drivers/watchdog/watchdog_dev.c +++ b/drivers/watchdog/watchdog_dev.c @@ -282,6 +282,7 @@ static int watchdog_start(struct watchdog_device *wdd) if (err == 0) { set_bit(WDOG_ACTIVE, &wdd->status); wd_data->last_keepalive = started_at; + wd_data->last_hw_keepalive = started_at; watchdog_update_worker(wdd); } -- 2.20.1