Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1749296ybz; Sat, 18 Apr 2020 07:43:09 -0700 (PDT) X-Google-Smtp-Source: APiQypJf1XDABEthF6Lm6x1IbNX9PBDq2BnUAI4nhmnr5v9an6AQCH3ebU1E48ZfjA02kQ8JycwV X-Received: by 2002:a17:906:7f0c:: with SMTP id d12mr7967070ejr.40.1587220989209; Sat, 18 Apr 2020 07:43:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587220989; cv=none; d=google.com; s=arc-20160816; b=skuuJqIfilqsNYN4ePcb9orBRkqel5AdsOigYsk5Q8gNf7srx6vUikc4rnGT2kEzqX xrQc/DDPu/+J8vTPKuPKrqwXGSEoZ0qlQI4HUHj544zEg8LYD5LCc2xT9q3UpwT6NR8b 6UQMGeVkm8XtXsQEYE75StbR1OHKx5atYVQqFxSioXJDgjcCAGAdUxP0KUM7vPfJcQWa ZwBOKEiSUcvZ6nJucmraF+YjMMvvnzou/n0ILPti0RPQPjDQy97u83xVGCp47LeLmXxm Dd71aGCX0D2l+vvVi7HSeiQF1azqrPXn9tPbT0N1U79sledVdwe52GMwXnjyK/faEAOF DGbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fSqx9QqFFlyM5xqwgXeqQ+WdjXMOjDGY/j6ULRQqZKA=; b=fm0Qa34g5/LHPmzkqCqI81RRTyOA1llCxNUv7+Quymv9XMxv4hM4S0+xm6ry4iK/0e lXBepULGMt7O8a0HgBWU+r1X0EBU+fGwGz+S97elf20ggvf3GuEdh7wJqBMmSrgsOtEs P8kI5Jj0xDoNy9AyM5nTHXUByi6y5+jOunsuw0QrkcrJLRFoT+FCnT9hWbsXd4Ix7DIv Ihd/qQjMg9S8wdZ2mpe2beEVUWrdzxTweevg6nYyFmOyoN/D1/Ovmupf32vqGrAdPyy8 rwcgf88BiZQjVUXfqSDsw9jrrWFY3d5dCZE54/ANiMsuPH22pgkxeaKY4JbIbE/cfMQC 4B8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iySti++s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y1si18099687edp.606.2020.04.18.07.42.46; Sat, 18 Apr 2020 07:43:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iySti++s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727896AbgDROlU (ORCPT + 99 others); Sat, 18 Apr 2020 10:41:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:50282 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727856AbgDROlS (ORCPT ); Sat, 18 Apr 2020 10:41:18 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 174A921D7E; Sat, 18 Apr 2020 14:41:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587220877; bh=no3knKj15K/kqw5BYs/rcA1+Ow+Jsr8lPJT0094hSSg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iySti++sYQWWoBlbmAVCzgk9VIuww8G2z2u5KQkCrF72x/tgUQHXmbUX7/MB2GCg6 YvHAPGwGaZ1KwxRMdaJXUHW1JpqKDKebGgDEU8HK1lHGliGpgi4WCIXX8CTz0jFLPd kWP6xgxKlaPWDVy5B49TnemqK/RsORD2TPbcqWE0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Vasily Averin , Andrew Morton , Peter Oberparleiter , Al Viro , Davidlohr Bueso , Ingo Molnar , Manfred Spraul , NeilBrown , Steven Rostedt , Waiman Long , Linus Torvalds , Sasha Levin Subject: [PATCH AUTOSEL 5.4 24/78] kernel/gcov/fs.c: gcov_seq_next() should increase position index Date: Sat, 18 Apr 2020 10:39:53 -0400 Message-Id: <20200418144047.9013-24-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200418144047.9013-1-sashal@kernel.org> References: <20200418144047.9013-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasily Averin [ Upstream commit f4d74ef6220c1eda0875da30457bef5c7111ab06 ] If seq_file .next function does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: Andrew Morton Acked-by: Peter Oberparleiter Cc: Al Viro Cc: Davidlohr Bueso Cc: Ingo Molnar Cc: Manfred Spraul Cc: NeilBrown Cc: Steven Rostedt Cc: Waiman Long Link: http://lkml.kernel.org/r/f65c6ee7-bd00-f910-2f8a-37cc67e4ff88@virtuozzo.com Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- kernel/gcov/fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c index e5eb5ea7ea598..cc4ee482d3fba 100644 --- a/kernel/gcov/fs.c +++ b/kernel/gcov/fs.c @@ -108,9 +108,9 @@ static void *gcov_seq_next(struct seq_file *seq, void *data, loff_t *pos) { struct gcov_iterator *iter = data; + (*pos)++; if (gcov_iter_next(iter)) return NULL; - (*pos)++; return iter; } -- 2.20.1