Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1757790ybz; Sat, 18 Apr 2020 07:53:17 -0700 (PDT) X-Google-Smtp-Source: APiQypJ9lSmzH1rsqrZVKlAV/VdWQdtJjSsYBieWxeSenlqvj6Q+qP8Rj3FefPbNGyxsT7qMH0d0 X-Received: by 2002:aa7:d1d6:: with SMTP id g22mr7669471edp.36.1587221597232; Sat, 18 Apr 2020 07:53:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587221597; cv=none; d=google.com; s=arc-20160816; b=M+0HpB1lkR4m2tk2x/5m21oDDYBaVOeqCJeSqcnHAr/zmgQMZG9iJOgULH/TDM2yUR FbsSvrqBm+aRsAuGPHVgmZl31QW/ao5ZIHuiEC4Cgyq4zUZoPxQCoKNaPHv8HMaKuIdZ m6kY+j1xnTkzkyMyYmDfXlWyI7x8ZQJuz7OlMv4Mm3zV7ujKOKmGJcV3J3UO3EoIrKDJ JeQfapyP1w/mhMc0myR1yDCtaY/uAl513/kBRnTXEKCICs0xhfr0sQwrey2f7guRunv6 P9pBC6b7SqRDDiKDQVzMhuoGcpu40OpIg1THf47SQaXPjex1e3XkWAiOiUHLQJ15ThLI xmLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CI+VoLw9I2BcAIbf9cUudvoRb/kdIutkppeRUeWlJKI=; b=ADVJDt9aSANjxuDHju2jbWyw6DK2T0IaUWsv9qjo3XHRAbsn0DPVJdV9UIZYDVgSDa aJczT00UB3Qd4hZS2+fub10ndyFjj6GsDHP1fY5OUjdPrzQe2lBNdQgh8DbQt7ZtBEhu xk7VFhJVxKzRQbyB/TCl5/wV94lMszrKq2Ft8n6g17yA9o+NCdraqB4s5no76d3FQu4G pwCA02JLPlE7uYJfFOYDSvGSoH6CmyqL9z5achRvg5aNlOVZ1b0g8ibIYMm61uacBYbN m/p9wbumlk+gr82BIHEJyZhrd2A+gAMzS819ZGPMj7TCGUOJliuYmnEhEsnC/C4ulPKY ErRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="l9y4jgV/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y97si16049428ede.246.2020.04.18.07.52.54; Sat, 18 Apr 2020 07:53:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="l9y4jgV/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728843AbgDROtt (ORCPT + 99 others); Sat, 18 Apr 2020 10:49:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:54348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728554AbgDROnU (ORCPT ); Sat, 18 Apr 2020 10:43:20 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 92C3222244; Sat, 18 Apr 2020 14:43:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587221000; bh=Zsp2N1+48JS7KFufw1gDwPeSfJKcUBMY7IcuWQWeEjo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l9y4jgV/940iJeT5MmHY85eQOIQb6nSOdAKpqE49QnQOrZhuAttNJUeGuNreHasX8 raTt5+vPpfOPObTB7lm8NHlmdhY19ZrLFq4U1Nab+iYP2enWjU2wXrlV5SONCAceGL IBxXPBjp8xzJw45dgeB0QkO5VDyToB0NX2C2Sgjc= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Frederic Barrat , Alastair D'Silva , Andrew Donnellan , Michael Ellerman , Sasha Levin , linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 42/47] pci/hotplug/pnv-php: Remove erroneous warning Date: Sat, 18 Apr 2020 10:42:22 -0400 Message-Id: <20200418144227.9802-42-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200418144227.9802-1-sashal@kernel.org> References: <20200418144227.9802-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frederic Barrat [ Upstream commit 658ab186dd22060408d94f5c5a6d02d809baba44 ] On powernv, when removing a device through hotplug, the following warning is logged: Invalid refcount <.> on <...> It may be incorrect, the refcount may be set to a higher value than 1 and be valid. of_detach_node() can drop more than one reference. As it doesn't seem trivial to assert the correct value, let's remove the warning. Reviewed-by: Alastair D'Silva Reviewed-by: Andrew Donnellan Signed-off-by: Frederic Barrat Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20191121134918.7155-7-fbarrat@linux.ibm.com Signed-off-by: Sasha Levin --- drivers/pci/hotplug/pnv_php.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/pci/hotplug/pnv_php.c b/drivers/pci/hotplug/pnv_php.c index 3276a5e4c430b..deb09cca4b4b3 100644 --- a/drivers/pci/hotplug/pnv_php.c +++ b/drivers/pci/hotplug/pnv_php.c @@ -151,17 +151,11 @@ static void pnv_php_rmv_pdns(struct device_node *dn) static void pnv_php_detach_device_nodes(struct device_node *parent) { struct device_node *dn; - int refcount; for_each_child_of_node(parent, dn) { pnv_php_detach_device_nodes(dn); of_node_put(dn); - refcount = kref_read(&dn->kobj.kref); - if (refcount != 1) - pr_warn("Invalid refcount %d on <%pOF>\n", - refcount, dn); - of_detach_node(dn); } } -- 2.20.1