Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1758623ybz; Sat, 18 Apr 2020 07:54:24 -0700 (PDT) X-Google-Smtp-Source: APiQypKg4ylxfkk1UFXAiWG7byuFdnLGiEd9+lv1NOr+0QWqElZnbZ1S1MEJ/f99eTTIjnF+VMD1 X-Received: by 2002:a17:906:fc3:: with SMTP id c3mr8257695ejk.28.1587221664498; Sat, 18 Apr 2020 07:54:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587221664; cv=none; d=google.com; s=arc-20160816; b=TBsLGrnctPYf82+uc8i/nGlx5uxWW0l0zH1jG/3HsjZveYBe853k5q/CPAEpl7s7Gt DVQE/cpmAY8dmv2BZwX3JdXgMn95L1nN0o/9axoXQMtXShhZjxC9uUC4gFBC90zRNeh0 aZ/VCVW7QtgkhzoxdTeY9B6KQjmRhAB89OLCwbmWGTrxQGNCHlzAtGlivbucpUyLnY71 mnVrZvZY82tiD0wGuJyNtUq9wMHxI88CnONSLdqXaKfS3QX7VK1uafQH/fr2QXopwtnI ZZRVYkjUm3/okpJ0pye+ZVs8YZT/nk0QQHQL/PKpHFdsAXLAdD8SdDCIuRSQyXiASqHN 8X2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6E7pma5m9M4NcZ9Yhzz4l4XvqJwnGiI80hoDsqSfZls=; b=BGWEo2SvmuG1+JQUiBC1fTmJpvP8fKCfmGn7PvHBYQyUQwAZY4BJCnG8HjoSBXCdGt FviE/HJF1GKQx0O3fF/xdrIiobbndPBCbkQnQxAwohzHByA0QTv8EC97jI65JhwueFnm ObtH0xJaddo1WK1OvfXR3uV87W3JPQWXHQqFb8KNuJNbzxi8yPmUkWQa58JlRAVUUbV0 7r0YEVOyZeDxXvtHM+SjbLiE5RkCiVNqda49LRCGUpEow4F8yDhNZ1/63SyKRAT49yWh 29S5oalJwXypB37RSfpnR3jsnwxOkRZiDnZrrp7+h36XYLZLHf48kxSBf9uc+jHBwAeV WgIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vho8deI5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a15si8591531edk.298.2020.04.18.07.54.02; Sat, 18 Apr 2020 07:54:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vho8deI5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728648AbgDROv6 (ORCPT + 99 others); Sat, 18 Apr 2020 10:51:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:52600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728345AbgDROmb (ORCPT ); Sat, 18 Apr 2020 10:42:31 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C6EC721D6C; Sat, 18 Apr 2020 14:42:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587220950; bh=e3Ix0CKQnO2vFrhw8s5qjaLhbJuDinvzEZLMlqEOCsc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vho8deI5/tV6KinOFwXMTnY8nqvtBwsKkHdrIjWQWkv6ZjbNUr1dtwCDgajUyFJGB UxoV2/ZYKC4UviFh2lwb0GjKJfmQW80XpT6WSe3plRc1UvCM60mUNgIOJJNfqrJuWY pI3cs/vKSz9fvkDL+yR9PVkNXaAYImcE62aIhKuY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tero Kristo , Guenter Roeck , Wim Van Sebroeck , Sasha Levin , linux-watchdog@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 02/47] watchdog: reset last_hw_keepalive time at start Date: Sat, 18 Apr 2020 10:41:42 -0400 Message-Id: <20200418144227.9802-2-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200418144227.9802-1-sashal@kernel.org> References: <20200418144227.9802-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tero Kristo [ Upstream commit 982bb70517aef2225bad1d802887b733db492cc0 ] Currently the watchdog core does not initialize the last_hw_keepalive time during watchdog startup. This will cause the watchdog to be pinged immediately if enough time has passed from the system boot-up time, and some types of watchdogs like K3 RTI does not like this. To avoid the issue, setup the last_hw_keepalive time during watchdog startup. Signed-off-by: Tero Kristo Reviewed-by: Guenter Roeck Link: https://lore.kernel.org/r/20200302200426.6492-3-t-kristo@ti.com Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck Signed-off-by: Sasha Levin --- drivers/watchdog/watchdog_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c index e64aa88e99dab..10b2090f3e5e7 100644 --- a/drivers/watchdog/watchdog_dev.c +++ b/drivers/watchdog/watchdog_dev.c @@ -264,6 +264,7 @@ static int watchdog_start(struct watchdog_device *wdd) if (err == 0) { set_bit(WDOG_ACTIVE, &wdd->status); wd_data->last_keepalive = started_at; + wd_data->last_hw_keepalive = started_at; watchdog_update_worker(wdd); } -- 2.20.1