Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1759456ybz; Sat, 18 Apr 2020 07:55:35 -0700 (PDT) X-Google-Smtp-Source: APiQypKqKPTQOo9R8a5CQ6HbZI/ZjnwmIAQL0DEZAc9XAJAnjJAGBl/5gh/c2pShFac9qtfgZMl9 X-Received: by 2002:a17:906:7045:: with SMTP id r5mr8174646ejj.29.1587221735222; Sat, 18 Apr 2020 07:55:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587221735; cv=none; d=google.com; s=arc-20160816; b=IPSEVWNGr1rjceV2eIdRPQND50r1UiywsfZGqQRxoUjyCCZf6wTcaol25p6ncl/5zg bOyhtGH0Bcp1LBQpekYU78UjFu4pU+nFaEA5oJ30QDCuM16T1eEkmVs2h07+Z9tKz6cm SGMPhMr0Xp7sf7i5I73DLQ7aLPEvZLJPmMy8hPrCQp/fED6qoAInj6T1t8dzB0yLA8aY QwTXJgytyrB20Tc1dh32cQV1pJhkmcV7cDTDSlLWUhSRKjHjSRKaGe8P97TdBALaTt6k zdnZrlzULWbyvBCQPwOekLUVQzPLA5H+EA2o1ghqovxiduv66yWWksj3GvQ4M8yKEsgL DIvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xIlnej2Lyu/gsS7pSYzahtCQnJKaFoPjEsN8/RFx7AM=; b=LJVGEdwWc8p3VYA9/cObzCDOAQuFtixZglcQjQ1atm0yY6ilVzTFaqeq2J1q9Bbl4T eDcqzbSiG9m1bY1YwveNu1Hsm+rx3uzDOZ9LrRgF8oI80oEBZwg0HzG55tV23evHuVIu 9NppO0ue9pDs4kEgkhjqlSg3gB13G43sNhMfOFzgpAOacnYqNu831JvM9dfYCz2cpCsU wPkmksU7MI8gKomrC3DNJx18Eoo+klkytf6Y2Wl/SlJrzPFsXPzcezxO2yUKOVVJozyr 6aeIGtILDFawbMPXBiGmLg0ZMjA0dcOjLr8uvp53YUIxhYZN5KYLXHOEhOp+X5AMoIZ9 sp/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Rxfu24of; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v24si17065374edr.501.2020.04.18.07.55.12; Sat, 18 Apr 2020 07:55:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Rxfu24of; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728274AbgDROvV (ORCPT + 99 others); Sat, 18 Apr 2020 10:51:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:53046 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728418AbgDROmp (ORCPT ); Sat, 18 Apr 2020 10:42:45 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7A0522250; Sat, 18 Apr 2020 14:42:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587220965; bh=qh+rRQ26snjET7PSeU8hJK8HLdSc6NZMY9RE8q3qkKs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rxfu24ofc7lpcp49YJET/5tHbvJt4Wk9Ek4V72eiBOJZtm1aRdz2qXrFwFx3xkj/L WuWpwg43ZlAh+k2EyfMh2DNNPh7uKc2dtf4hiHuPHJnc/ySmhcDfxMLNWQW87r0Y/Q qAram/QKvOlKF5CoCP2xGslppby9rJ43Z76SzTc4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Vasily Averin , Andrew Morton , Peter Oberparleiter , Al Viro , Davidlohr Bueso , Ingo Molnar , Manfred Spraul , NeilBrown , Steven Rostedt , Waiman Long , Linus Torvalds , Sasha Levin Subject: [PATCH AUTOSEL 4.19 14/47] kernel/gcov/fs.c: gcov_seq_next() should increase position index Date: Sat, 18 Apr 2020 10:41:54 -0400 Message-Id: <20200418144227.9802-14-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200418144227.9802-1-sashal@kernel.org> References: <20200418144227.9802-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasily Averin [ Upstream commit f4d74ef6220c1eda0875da30457bef5c7111ab06 ] If seq_file .next function does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: Andrew Morton Acked-by: Peter Oberparleiter Cc: Al Viro Cc: Davidlohr Bueso Cc: Ingo Molnar Cc: Manfred Spraul Cc: NeilBrown Cc: Steven Rostedt Cc: Waiman Long Link: http://lkml.kernel.org/r/f65c6ee7-bd00-f910-2f8a-37cc67e4ff88@virtuozzo.com Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- kernel/gcov/fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c index 6e40ff6be083d..291e0797125b6 100644 --- a/kernel/gcov/fs.c +++ b/kernel/gcov/fs.c @@ -109,9 +109,9 @@ static void *gcov_seq_next(struct seq_file *seq, void *data, loff_t *pos) { struct gcov_iterator *iter = data; + (*pos)++; if (gcov_iter_next(iter)) return NULL; - (*pos)++; return iter; } -- 2.20.1