Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1803860ybz; Sat, 18 Apr 2020 08:48:35 -0700 (PDT) X-Google-Smtp-Source: APiQypJ9AKP/OqBjwFphK12HlvrLxQoEr17twwaRQEEQ25TqrVpRqVn+tIQ9LjnyhsWHSP8Mmee/ X-Received: by 2002:aa7:d0d8:: with SMTP id u24mr7868629edo.138.1587224915052; Sat, 18 Apr 2020 08:48:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587224915; cv=none; d=google.com; s=arc-20160816; b=0kvv0axRdNCK4FN6Cf/m/tuIU+AsoHQuv1qQp0GffNpbIif8ig7XMiRY7BJ1UDgAc1 8UMt2tqF4FSISEhzGeEa9sFCbpCGoCBTiy3Pb0ZYhMRESEOuAXHZuqhkv+wGL25hKgN5 k6Oji1LkWhSPpK72n4yphZrINaI1AFqDdIA7StWQd9RP4noU4UNBIdJZQJHX0AXXQ5nP kvbdQlFw8/HdVKuGzod4btzl3VEDOyhPQwHTmucIDAVOzl/Z6GJ9epLJo4NQ7KPfuTFr AsLMBARjRfQwIAzKGSoP8eyDhEUZOEYP23Ag8gGNyN6+ibYHFAEPDu0i2eM+XXK5FCuG 1VVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=oXlaAlTOZ3RLb/vS/mMTSxaZoYfGINL3iQmbu/1xG74=; b=JRUm5Fx4OVkLtR6bFPRHQUdrn5zDYVnzV7HNDYWMAeNnnGw4agRPnlG9d67dPCrN1J uF5aiD9Dk0kxMNn4ZQHmDFunz1+P2BCd+YUZEB7Wps00HHSa0Zez7Q4qOigXAsoqwQ+j BQcDFGpbQMgfbQuex5+aGMLOGtzLKCHA3j5k+Q/WgjNVC2s8mSvog5dbc1hRQF+xhPT2 qkzL/r9NuIuhvWm0NUcNT5P8foGae2Nzmedcb7UL0uESd/msba6Tpw8Jmout0Ul9LUlv q8u5j449rxXOnWshxgfpaTYQhZ4YJOyezBAILh2n1BTY+GX0wGBqGjhVpT6zAc3NcuQr cIkg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id di17si5119768edb.593.2020.04.18.08.48.12; Sat, 18 Apr 2020 08:48:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726795AbgDRPqO (ORCPT + 99 others); Sat, 18 Apr 2020 11:46:14 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:44130 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbgDRPqN (ORCPT ); Sat, 18 Apr 2020 11:46:13 -0400 Received: by mail-pl1-f194.google.com with SMTP id h11so2174615plr.11; Sat, 18 Apr 2020 08:46:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=oXlaAlTOZ3RLb/vS/mMTSxaZoYfGINL3iQmbu/1xG74=; b=bNaMfx5yiEXbluNa8D7LMMpuCVVM2rpPCq//i5R9Vx+3RQ1rlxidUBLto46N/IuZOt dukQ7Xo5DMGFNZCQ5Mn0wkfh6mrA8+l2HftMgN9hB2izR8l5YqSZmPXOLEOZsAKvxguB +bS/ua1xC/wybv/e66CSTJbhs8YSJXeWq6ZJBAaol8+hsk6O/WAtikwZZ6qTkuBTL+XM 6kp+aXlV4IlH7tilsAA3IVtMytHA/LL3so55kEnHyxupbyRTp7+Jls9o1I17b3KOGpm+ bTYXW6Kl07osyEztgNoi9h6Tb4hDIrZr93HpZtFoPsXU0DBig5AnFweduFN2BMPBpRXV HUYA== X-Gm-Message-State: AGi0Pua8ndQbhlF9P0v9h3onGw7j8qo9WGyIMfVJzjy5VJ7LRXy1bW6C /70C7fBYm5eehxE7ITCsDka2FD5l9j4= X-Received: by 2002:a17:902:8643:: with SMTP id y3mr8633914plt.149.1587224772675; Sat, 18 Apr 2020 08:46:12 -0700 (PDT) Received: from ?IPv6:2601:647:4000:d7:551:c132:d476:f445? ([2601:647:4000:d7:551:c132:d476:f445]) by smtp.gmail.com with ESMTPSA id m14sm21002534pgk.56.2020.04.18.08.46.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Apr 2020 08:46:11 -0700 (PDT) Subject: Re: [PATCH] loop: Call loop_config_discard() only after new config is applied. To: Martijn Coenen , axboe@kernel.dk, hch@lst.de Cc: ming.lei@redhat.com, Chaitanya.Kulkarni@wdc.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com References: <20200331114116.21642-1-maco@android.com> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: <3cd82069-0ed6-688f-0d7c-bb0c5ccb0e5b@acm.org> Date: Sat, 18 Apr 2020 08:46:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200331114116.21642-1-maco@android.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-03-31 04:41, Martijn Coenen wrote: > loop_set_status() calls loop_config_discard() to configure discard for > the loop device; however, the discard configuration depends on whether > the loop device uses encryption, and when we call it the encryption > configuration has not been updated yet. Move the call down so we apply > the correct discard configuration based on the new configuration. Reviewed-by: Bart Van Assche