Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1915465ybz; Sat, 18 Apr 2020 11:10:11 -0700 (PDT) X-Google-Smtp-Source: APiQypKTfUMaY5iVxudu82bIzh9AqVihnSpwwkf1taBGiGoJOrIQlw04xybrVuX9erkRYI7zJ6nZ X-Received: by 2002:a17:906:3047:: with SMTP id d7mr8928108ejd.141.1587233410771; Sat, 18 Apr 2020 11:10:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587233410; cv=none; d=google.com; s=arc-20160816; b=MirRcYiqqwfv3eNP8m+YjxsSq9842o8SzlTCmyi6a/6noKgvMlRB3fWWU5Q1jZJgbm Vt5uO8+KIU1PkLEhbpwDAKB83vGl49+l3Tfp7jYOWRmo2qJHekGs+iltwkfTirQmbN02 ean4pnSbsHPw+heR5X6oSlBOX2rLwCQYDNarxi0BHrfsI9ukoTFept8iKMOCZHKsZ/V8 dKKAmci5/AAs/JtPxsLpnzShTKzq6qD/iY4Iu/g/Thjt8pIXXbzrse9XJDqh4/27n2CB +sxsrQ3chRZt4/z9njuOC1Kk/naQjykk4WhuYukjYdIQVByOjzAKH+wdM3LG/cCd9ouA S6TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=O4U+IPm6wwBCRpajIFNeENCy2/QtAFa0dBn73KPuzS0=; b=jvfdnxkl9Jk6Virv7JQ4ltcoNuJrtcpPjDa1c2zWqfbgiutJ5JP3JZoCRLR1IBU4Je fAkNBwYZ/lytjdzTZmqESr+iZqSNRY5R014csSRCig2Vwk8MryRL/gs/jzp2H6CWuj10 65mMJacKPYb15L+UKeYLX3B2VO3Da7Ye+XMYEZqTL/U5Zwo1V5Gwg7sQX5KV8OtjNSOV I2OozIEj/Iuul2wLb5sCgE8gz7ps5wLqApmSgK/CagAxWAbxWAcLwN0zQS2qw8jt2Euy iZe/MN7IDiCfnUzzZltdFXIGzYdf9QIpWOSIIblDWh02c6Z4qtCIBr6wyK3ksp/4LcJG /yxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=N9DcK5Q5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q25si17279303ejb.274.2020.04.18.11.09.48; Sat, 18 Apr 2020 11:10:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=N9DcK5Q5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726916AbgDRSF6 (ORCPT + 99 others); Sat, 18 Apr 2020 14:05:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725824AbgDRSF6 (ORCPT ); Sat, 18 Apr 2020 14:05:58 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18668C061A0C for ; Sat, 18 Apr 2020 11:05:58 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id 188so64237wmc.2 for ; Sat, 18 Apr 2020 11:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=O4U+IPm6wwBCRpajIFNeENCy2/QtAFa0dBn73KPuzS0=; b=N9DcK5Q5c7dscVTCmHncEZHvn9QX4LIQaYHTtnxcIQKGlCtdhSrUgAhl0wMSl+iurf 6qigTMAIFf3Yitgkkd+sYYo6Fh30a+MNeVvFsP8AOi1DSiiu2AUzZbyAzDO53C+M7mPt 2PXCZmav3ZFOA41sUWI26R1eWAkpMX9btDsJAlucku1yMp0dZvvu8ehgisWPK9DwuvO4 uTwVoTSvll/dgvx4vbUyVpc2D+5o7VPOzWn6KiSr+2CkGQwnREuI9xqOJ70CUnyaf7Gb Q1kQojGVlpukIr2KkNux5t4b3whWlEIRZi5LOcsyeeGI8OV9k3P+aylBTRtuHEIgUlak q5jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=O4U+IPm6wwBCRpajIFNeENCy2/QtAFa0dBn73KPuzS0=; b=cOf4AxF1r05orPOylkhwGqltEy0qU8IDlkq4piSuA2twE5vsMh7awkBFhxYGZhwjAs vJd1Ci2tpMeMlclGrX/K1p7vPV9OwTfaqO+81/WZlA3v0xB8WuWijyuuemzzzppG1rR4 Iu+Q8++wDdjx/EZ5iA7r1bX5/jJoPqkAykxi7Ma6FprGYslXkj21/qRZr9OzuZgFR8lJ jsIzyHnV1h6GAHq7DmudbcU3kZ6BKjmSMmDspF7F6TpdvddQTengGVp8V4pF/Rg598Ge UgqzCPThm36gTTevpY8P5m9w/+bh9bf08W91lG/9XTqdpkQUXe9v8w8r1/FEIX4nLUF0 dPGA== X-Gm-Message-State: AGi0PuYNBXsPWATPRQhJGHV0zIi+lc6W1ScM41+ttCmPOvvS9W8R0lLg x0YfiMho5MeRhqiVbYTQWLsddxy8 X-Received: by 2002:a1c:2002:: with SMTP id g2mr8755746wmg.109.1587233156597; Sat, 18 Apr 2020 11:05:56 -0700 (PDT) Received: from [192.168.43.18] (188.29.165.57.threembb.co.uk. [188.29.165.57]) by smtp.gmail.com with ESMTPSA id l19sm12514363wmj.14.2020.04.18.11.05.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Apr 2020 11:05:56 -0700 (PDT) Subject: Re: [PATCH 2/2] staging: vt6656: Fix functions' documentation To: Oscar Carter , Forest Bond , Greg Kroah-Hartman Cc: Quentin Deslandes , Amir Mahdi Ghorbanian , Stefano Brivio , "John B. Wyatt IV" , Colin Ian King , Dan Carpenter , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20200418123659.4475-1-oscar.carter@gmx.com> <20200418123659.4475-3-oscar.carter@gmx.com> From: Malcolm Priestley Message-ID: Date: Sat, 18 Apr 2020 19:05:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200418123659.4475-3-oscar.carter@gmx.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Actually I don't really think the function descriptions are needed at all the names of the functions are enough. card.c needs to be removed the bss callers to baseband.c, the tbtt's to power.c and the rest to mac.c Regards Malcolm