Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2266098ybz; Sat, 18 Apr 2020 20:21:30 -0700 (PDT) X-Google-Smtp-Source: APiQypJn9Qxli+nKAEY79UrxfZOTjpQpij7k6mb9qMZzZfgHp021bOXPXtDbkYibT7OuiE2SJ2e6 X-Received: by 2002:a17:906:3296:: with SMTP id 22mr10321249ejw.195.1587266490421; Sat, 18 Apr 2020 20:21:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587266490; cv=none; d=google.com; s=arc-20160816; b=iiaYn+gkPTatznVV3D6s3Vvm9/BDW1WxV+tXC9diOzrzmoPCk2S5UFJNAUEfNEssdL jS2Vqp1OBJTPIkKyRRp07KSK/EQh3HtuGZbVxZxLlVqGLgMAm+RlTJIVG97UTpZukDjH VNwYcf1H7JzrrG2JhwpTJINWzFuE9pehO/62CpdS+gjO/t4xIWCACI9KZvPAS8NoHwLp 292+v2THtdkMbjyfI+4YjufHFVLqS8fB4EHG5CpIq3nxPI+l6ZK1uZKobzF+Kwa91YUz dO0htXeti9JqbjgSGvXbRVurB/bBtWwsnbR8cojfYFj25HLRfzNKZD0M/i9w+wUxrM0r W1/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=UWnX+UK8PS9D6Blnp9qomQpDHS6Z4/z5RK+QGw2Oby0=; b=jpIFUHOzHRRXl6QpI3Fg16F3Nb/KmabWnTuIhAzgiQ2LPBgyKRTjEC3jVkDO8Da0O+ yL0E9WnqOMOIgzrfuvGxXCVkGvurjMi0ynMmb4oH0kE60Ln+VGOgVf3Vx5J8S4FHb32E ilgQdRGHj6u1FV/quQw8Q54EKSgHPzel4Ph6BaX7tt5f/OmyZvJnRVga5GbTOeFqOpgH Yx0hovgBKDCFQw8GDhnh93XkBHVODmepkpYl7aHljVR4eqWcRH5lyCiiQvFBhxewOLqO CDasAIhlbrw/6xDfA1v3G4pF3TqS3s9BKq4Cdd/+Kb6ziLHZH5fwoVZ+BxxJ1OJOjTBe 3sSA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id aq11si16949892ejc.307.2020.04.18.20.21.07; Sat, 18 Apr 2020 20:21:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726063AbgDSDRw (ORCPT + 99 others); Sat, 18 Apr 2020 23:17:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725877AbgDSDRw (ORCPT ); Sat, 18 Apr 2020 23:17:52 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10F07C061A0C; Sat, 18 Apr 2020 20:17:52 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 555ED127B391F; Sat, 18 Apr 2020 20:17:49 -0700 (PDT) Date: Sat, 18 Apr 2020 20:17:46 -0700 (PDT) Message-Id: <20200418.201746.783676213458110248.davem@davemloft.net> To: tanhuazhong@huawei.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, salil.mehta@huawei.com, yisen.zhuang@huawei.com, linuxarm@huawei.com, kuba@kernel.org, shenjian15@huawei.com Subject: Re: [PATCH net-next 01/10] net: hns3: split out hclge_fd_check_ether_tuple() From: David Miller In-Reply-To: <1587192429-11463-2-git-send-email-tanhuazhong@huawei.com> References: <1587192429-11463-1-git-send-email-tanhuazhong@huawei.com> <1587192429-11463-2-git-send-email-tanhuazhong@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 18 Apr 2020 20:17:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huazhong Tan Date: Sat, 18 Apr 2020 14:47:00 +0800 > +static int hclge_fd_check_spec(struct hclge_dev *hdev, > + struct ethtool_rx_flow_spec *fs, > + u32 *unused_tuple) > +{ > + int ret = 0; There is no code path that uses 'ret' without it first being assigned. If I let this code in, then someone is going to submit a fixup patch removing the initialization.