Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2418314ybz; Sun, 19 Apr 2020 00:49:51 -0700 (PDT) X-Google-Smtp-Source: APiQypL4JxXfTacRmigF/6v8e9JAxCegoCRJ0HD4JkdMkcAE2d3IUHfbMkOU36dHXOwKUvyIEHhP X-Received: by 2002:a17:906:4c98:: with SMTP id q24mr10432599eju.140.1587282591211; Sun, 19 Apr 2020 00:49:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587282591; cv=none; d=google.com; s=arc-20160816; b=O827GAucI4iaFoXayhPXQdhwXF0c1fu8IkwH0lcGWjuPe+IdE8x7qDMr4Bq+1Rk7R7 ifMpzEfDGinDFacmJ0tGb+ts04HweEf4SYumRPYVsL4mBleojdtaK1jDBAn46gdZVRsw oiVMfo/yDyxSS01P0/em2z5AP8TuAoHRxpMsCDCPHZ8iS/kOKo7VJqevp62A7YGhl+yq 1ca2ZhqLl9S+EUNaGSjYhIEQpaEbUmiyB1zmuf5FWW7v8MMsww7S83+wK+v0ZTDs6KWL OE69LpOWd1mcU0dkmvTUdUCiLTj+gwQQDXGuVUctNbIg7GnC5H/iXm5NdBE9lLnCPSff IKTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:user-agent :in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:dkim-signature; bh=vUSOECUk4A1mxf1ROMn314fFRK9fMORoG5b7Bw2RiDE=; b=WpAHNIcq7XnzjWmcSWmEoKPYGQAmjCdUD6RafvzHAqCVNjMWro/IYtBPQCJW5jfQns Y6jfzYeeaAPCHmT+2Mk4QGowd1JLqML6qBYczmQs2JXmGROpxifDW9K1VZfahRLvgcK9 SbMXRvGNtv9EoSuGFE0qHH0e5lTGGDNgqDjXvG0jSyG1Q1y5L9c7uvl3Y+0BNr3lKRPi MEaw5/ZN6nXTWhztqwTgkDunX11iYQywz25Wu09djlMPSsSIM+asY2Sr+TrsTafHqCrn J83Y3NIKiN1J4fnIj7UiBrfYbpoIl4zGQqAW7ITi9663RKdt4HOYMbcmH4R+OcGp+ktX RXQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=L88xN24A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v26si10123489ejq.460.2020.04.19.00.49.28; Sun, 19 Apr 2020 00:49:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=L88xN24A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726100AbgDSHrn (ORCPT + 99 others); Sun, 19 Apr 2020 03:47:43 -0400 Received: from mout.gmx.net ([212.227.17.22]:55645 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725903AbgDSHrn (ORCPT ); Sun, 19 Apr 2020 03:47:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1587282450; bh=vUSOECUk4A1mxf1ROMn314fFRK9fMORoG5b7Bw2RiDE=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=L88xN24AYqj90BWGl/q2KoIEmUQBg9VI9P377qLfYrtGRzd2BycuRy3r2pnP9kaj3 I4QgbDPnvoXLIXwzcXhOhwBVtQ0wrl04h+rnqgq/yumEoOZet5mkjgJjyjcAzWMp5Q SwzA1awLY6+T65DOcmYAh8ULPyKAX4iOdza6FDtY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from ubuntu ([83.52.229.196]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mwwdf-1j2vsn0M6F-00yTuy; Sun, 19 Apr 2020 09:47:30 +0200 Date: Sun, 19 Apr 2020 09:47:17 +0200 From: Oscar Carter To: Malcolm Priestley Cc: Oscar Carter , Forest Bond , Greg Kroah-Hartman , Quentin Deslandes , Amir Mahdi Ghorbanian , Stefano Brivio , "John B. Wyatt IV" , Colin Ian King , Dan Carpenter , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: vt6656: Fix functions' documentation Message-ID: <20200419074717.GA3244@ubuntu> References: <20200418123659.4475-1-oscar.carter@gmx.com> <20200418123659.4475-3-oscar.carter@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Provags-ID: V03:K1:C+eQwfMRlP9LtW3tNHYP23t/9OFkChviWB5f1D306aNEAqLQh/f PZq2e+MsIGdN5uaBB//2rSMKODQt3trR63byvjSBzXjQZp6GGdFHgSKSI890l5I4WYXVu/M SF67fTyzYlFK8evNfdqjSWxro4t4MZrBmtBPfQaDM+pbdFN4Y9WF2xAOQ8/FDt+dh/3If2E lFTPH9rS0aLBMiWv8d8YA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:LMwP+G4IPtI=:j736PCtEgPykBb0xF2qwnY 0TgUwgJv8SbU5ltOB9UImauPJ2uSmbsFHiPnBX+udnnR1Tp/jkfFYIQ2PqKJVMy5g5+CYNDeU DCWwUx+avuF8CCZgOYd0ROEFy0JM+sNc8j6zvXhhpRNaSgCJkEPllCBDM6DJXa8QzB/VMoV8n kIIzqUvKRbWn+SZLncD8iEJGx+A8KV2sbci0tNSzc8m9qKX6lA1bRy5Gnq/btlMKwKueVfMKH vtRwjCaWM7X0eWdpXA1JdyciVkBMlv5XSb4uh+xUlv7HM08BEd7xpr1DGBzmecV+h8RTr5GI8 AdVvs51UeFnwhfyeBbi28iOmiBXPZEtJN/dBdK99eK9IDFVRTffBblClcfaQa9bCxd9FtIeXZ j5KG7opdj52/m5QOeaFGCr+c+hX+m6D25BiiXgtOZdgckFmFVPh/nAxF8CZ9W7zjYdxndy4i9 KXr7WZU2GXim2Yc2QsLEXNpqunGPJZakysFE5KJ+nIoMSULSUf8tN9Iwd/lc6HcsmqQxxDkQu SruE/mlZrAmXAspwhSt1OvF8qAOayIvWrAwXBHB1viRxLSaEdoKkgxD95JlSK0SgZ+4pdRwuw KJnYD1MFIStcIZN5+zK+wUaTIVLcWiL/ZShbrci8Laz6jEdEns894856zHTZHhsz0lZhmmp6m yHcoIR45xUdVlOsGG1TgSlmUKayWyjitOaztf6dscXCyLLRK+quECuADuqdKzusYl8Sgpl7HY d19u1E99/cBaw2nMYsKPt08/qzVcPW6HflnQ1qThGz84S4L64omHvremoqwp9uQIgBgrnSAS7 MNGQ2lcDxpDDCSKEkxVjtXKifQNPDKKXcyEQ7aqriz2AEHXrV6YXsAeg+0C861GIQSUG541yb kYoQZHBZJ/sv3ovPtHeU7mm+4fJTBuQPa5tO3Gm6KkF824F8AyxL/al28xx4pEVIxfzNq5I0+ Gj+dv4G6TqebTgzXsRVGe85YlYwAL3ku6/r2fqYPnKUohSLh45afpetZ34Hkk9IYf17qLa+R4 QLOE28iubMHH04Ti1YrX8fiBbQmXyopINcUh4gKDEjaeEsoqFZRNbJjPosUsr4MddB6XxbLvH Pacjy2rOc+IqmfWcWsw2QFJPNNo41WLxY3J0M4kBWouh1T/auhnosi/KbExPTVvY0+4a3Lv1H oByUJIYLNh46JzcZpeP+c9EFDL5PJRE5VBn0DIeH3bt4Imh9IPBm9c6Qqf7NfqUD7KWoyKsMM k3jmHouw+vYGtSUVg Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 18, 2020 at 07:05:53PM +0100, Malcolm Priestley wrote: > Actually I don't really think the function descriptions are needed at al= l the > names of the functions are enough. > Then, it would be better leave the documentation as it was before or remov= e it? > card.c needs to be removed the bss callers to baseband.c, the tbtt's to = power.c > and the rest to mac.c > > Regards > > Malcolm Thanks, Oscar Carter