Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2480577ybz; Sun, 19 Apr 2020 02:26:31 -0700 (PDT) X-Google-Smtp-Source: APiQypLJfYHwUv0pAfrFx/Bm3MoMClx9wNN4CJnb++SzlqpGumg96ytCPjclNs8Dsk9hWghYbV4k X-Received: by 2002:a17:906:11c9:: with SMTP id o9mr11335772eja.64.1587288390846; Sun, 19 Apr 2020 02:26:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587288390; cv=none; d=google.com; s=arc-20160816; b=xwVj7ewIvhsPwJcTLBteqv+m/xSAQ4ApsXv7KUw1dAwo/9eUGZAMs3gCwhW+WWFukN F+QU9xUkNxjXsMqbhFs1AUi0JIluKPGim7piKFd8HuQ6pT4iujGUgqBgbPcFWwRLGnWw nvMaScw1QaIS9fI+bm3wZEwwjjHn1A8+2nwA7w71OlR/VzAAPWTL/ZNxqDCmX1LnWKr2 28jXlNGbs0w4tfHLVOUBXWhr4tW/X1bL79DnS05WC4C1UPo9KQvOvkgdhU8qvcsvqL0S pDOBSxyhgkIk7b9HiMSycD6zvdncqWsT7Bv7BoP6cyJBSGCpz6tyqFqkQUpnPlAEPjcn AEpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=UdyUdSW1ErJ1sElWqPc011PRfio7esFxjS/Km3qvG0I=; b=sh9YESqA8vuXF9urs3o9/0K5ZuoPEIdq2dNQWBYmnAYUgoIi/1NVqz86+Jc4OweXEs w89FWS5Ba4DZGJ+D9fAS2tqkpdWt+Um+tfi63oe3La8L3Vrw6fnGkBRDCIN6Xr0602eB bbI0XWcK1sgX5ynsoFW9hnWGbsFDHnKPg1aisVKk6VyDP5bke/pE78crxzWj60yymzgE ln6X5b59FK++TqdJyEU5jytaPR+OWtEep688VDncUY6UNecTO2PWUTdZIyeiiK1yhE+u Ap/B3W3T86/GoJ5fKMqE0skjNICgLdu9sOTbw0OVf+6KBqCUIByKes3bKQGEInJT74pl MnXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="urIkt/9S"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g7si13979020ejf.410.2020.04.19.02.26.07; Sun, 19 Apr 2020 02:26:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="urIkt/9S"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725939AbgDSJXB (ORCPT + 99 others); Sun, 19 Apr 2020 05:23:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725832AbgDSJXB (ORCPT ); Sun, 19 Apr 2020 05:23:01 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC43AC061A0C for ; Sun, 19 Apr 2020 02:23:00 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id d17so8183607wrg.11 for ; Sun, 19 Apr 2020 02:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UdyUdSW1ErJ1sElWqPc011PRfio7esFxjS/Km3qvG0I=; b=urIkt/9STP283VXro1YX6bE/Tjw2e0+xM5LL0yYDlxCuudFZPlMm7xvAdTV80SyCJD s41QmoDr6wRN5mCjGr5PEIoywNUxoYMku4DajUBRxUCIxAcbTwfTHQUJOcehXra5DV5w BMIs0wrY+tynpoaoZQZlwhJOhVzkj+aMEGN9dUYVAuMtoNbDa9CXTOv9TsXt2sXx23cv N19VIdO4mwkBJoEZZ6gGZFNQoaVEtSItyYgKEJ4F+TSCMbj6FJnP7zDeZBVCxrL365u/ yFzgBGfw6LSKLKdpz37FnVBEyvEaty4E//m8isB3WP79DyY/jff6zTyBBHqEknush/Id z41g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UdyUdSW1ErJ1sElWqPc011PRfio7esFxjS/Km3qvG0I=; b=dPhzohNhQpEPpmf8yqJQEp/D0TQ7uM5B1MxBcA5PtuKA9l5js4ZxqTjWJHbJ15Bo7p ePqUVr8QiAK0euUWm56be1s/ndabE1RDm6F9GpVdoX5Pr2Cryx4kggXXofkxOZsUzB5P 4ze7OI9DJ2pCikCwZ/F1rdzV2W6rMLvRuVpM5DZw4Kz9GevRoCjSVVHSCVz46L9Jb6cp UuJVp2Ta55dABGK/jsIpRy6atIRNnh/Xo6+Rq3RiIuWCd39VE32zxdkNWQ0syggRzDNE /GItbrkVTOXntMdiDyvcPiMmsmt8wVOhi5NXN1OztJvswYTgWzb7Se4Cl4OV4Mn6vacg D/pQ== X-Gm-Message-State: AGi0Pubzl/6CAQVaTVxVIuSNqZ9Zc9zkna4WsKvHgDCnZ1kJXOSO8L1Z JmnFfm4ci096RR3yr4R8Wb0JKfQ8 X-Received: by 2002:adf:d0c5:: with SMTP id z5mr2836782wrh.410.1587288178362; Sun, 19 Apr 2020 02:22:58 -0700 (PDT) Received: from [192.168.43.18] (188.29.165.57.threembb.co.uk. [188.29.165.57]) by smtp.gmail.com with ESMTPSA id u3sm29420682wrt.93.2020.04.19.02.22.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Apr 2020 02:22:57 -0700 (PDT) Subject: Re: [PATCH 2/2] staging: vt6656: Fix functions' documentation To: Oscar Carter Cc: Forest Bond , Greg Kroah-Hartman , Quentin Deslandes , Amir Mahdi Ghorbanian , Stefano Brivio , "John B. Wyatt IV" , Colin Ian King , Dan Carpenter , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20200418123659.4475-1-oscar.carter@gmx.com> <20200418123659.4475-3-oscar.carter@gmx.com> <20200419074717.GA3244@ubuntu> From: Malcolm Priestley Message-ID: <42190e0e-4167-3cd6-0e52-d240ae67a502@gmail.com> Date: Sun, 19 Apr 2020 10:22:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200419074717.GA3244@ubuntu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/04/2020 08:47, Oscar Carter wrote: > On Sat, Apr 18, 2020 at 07:05:53PM +0100, Malcolm Priestley wrote: >> Actually I don't really think the function descriptions are needed at all the >> names of the functions are enough. >> > Then, it would be better leave the documentation as it was before or remove it? > I would remove them all except for comments inside functions. Regards Malcolm